• Joined on 2026-05-20
bot commented on pull request commons/bot-agents#21 2026-10-17 18:47:35 +00:00
Document that package.json aliases may target only direct subfolders of src

This new rule says ../ is banned in every file, but it remains in tests/entrypoints.test.ts, tests/workflow.test.ts, and src/run.ts; the listed import rule does not check URL strings. Remove those traversals or narrow and enforce the rule to match its actual scope.

bot suggested changes for commons/bot-agents#21 2026-10-17 18:47:35 +00:00
Document that package.json aliases may target only direct subfolders of src

🛑 Changes requested

bot commented on pull request commons/bot-agents#21 2026-10-17 18:37:48 +00:00
Document that package.json aliases may target only direct subfolders of src

AGENTS.md says every test imports #testing, but src/credentials.test.ts, src/opencode.test.ts, and src/profiles.test.ts do not. Limit this to tests/ (or make the statement true) so the alias policy stays accurate.

bot approved commons/bot-agents#20 2026-10-15 23:43:22 +00:00
Move the action from Deno to Node.js and Vite+

✅ Approved

bot approved commons/bot-agents#20 2026-10-15 17:25:23 +00:00
Move the action from Deno to Node.js and Vite+

✅ Approved

bot commented on pull request commons/bot-agents#19 2026-10-12 02:39:57 +00:00
Recognize sign-in failures for every agent and fall through

AI bot failed.

Profile: none · all profiles failed

bot commented on pull request commons/memona-plugin-ftp#1 2026-09-30 11:47:37 +00:00
FTP connections preserve passwords and filenames, with CI checking every change

The stage counter always starts at zero, so another FTP client can create this known name after MLST but before STOR. STOR can then truncate that client's file and cleanup can delete it. Use an unguessable suffix and add a collision regression.

bot suggested changes for commons/memona-plugin-ftp#1 2026-09-30 11:47:37 +00:00
FTP connections preserve passwords and filenames, with CI checking every change

🛑 Changes requested

bot commented on pull request commons/memona-plugin-ftp#1 2026-09-30 11:34:12 +00:00
FTP connections preserve passwords and filenames, with CI checking every change

A data write can fail after the server accepted a prefix. Clearing the socket makes Drop skip its cleanup, so that partial remote file remains, violating the writer contract. Stage uploads under a temporary name and promote only after a confirmed completion, or otherwise ensure cleanup before exposing the target.

bot suggested changes for commons/memona-plugin-ftp#1 2026-09-30 11:34:12 +00:00
FTP connections preserve passwords and filenames, with CI checking every change

🛑 Changes requested

bot commented on pull request commons/memona-plugin-ftp#1 2026-09-30 11:27:00 +00:00
FTP connections preserve passwords and filenames, with CI checking every change

An upload data-write failure returns OutcomeUnknown but leaves CONTROL cached. The server may still be awaiting this transfer's completion, so a later operation can send NOOP or a mutation on a desynchronized session. Clear the control slot when this error (or a zero-byte write) occurs, and add a regression that proves the next operation reconnects rather than reusing it.