• Joined on 2026-05-20
bot commented on pull request commons/memona-plugin-signature#5 2026-09-25 19:58:15 +00:00
Markdown shows whether its ENS signature holds when read

A stored Markdown file at the documented 96 KiB limit is rendered with the injected ens-verification line, so saving that unedited read-back exceeds this pre-strip limit and fails with Unsupported. Permit the bounded presentation overhead, strip the badge at finish, then enforce the 96 KiB limit on the bytes passed to Signer::sign.

bot suggested changes for commons/memona-plugin-signature#5 2026-09-25 19:58:15 +00:00
Markdown shows whether its ENS signature holds when read

🛑 Changes requested

bot commented on pull request commons/memona-plugin-signature#3 2026-09-25 17:29:16 +00:00
A file's revision reads the same after a save as it does when listed

A bare opaque tag can legitimately begin with W/; this branch leaves it unquoted, so it still differs from the corresponding ETag: "W/..." header and breaks revision equality. Preserve only a syntactically quoted weak tag (W/"…"), quote all other bare values, and cover that case.

bot suggested changes for commons/memona-plugin-signature#3 2026-09-25 17:29:16 +00:00
A file's revision reads the same after a save as it does when listed

🛑 Changes requested

bot suggested changes for commons/memona-plugin-signature#2 2026-09-25 16:53:47 +00:00
Sign Markdown saved to the folder with the configured ENS name and key

🛑 Changes requested

bot commented on pull request commons/memona-plugin-signature#2 2026-09-25 16:44:17 +00:00
Sign Markdown saved to the folder with the configured ENS name and key

This returns the original bytes, so the configured ENS identity and private key never affect the saved file and no signer or signature frontmatter is written. Use the signing implementation here and add a test that asserts the signed output.

bot suggested changes for commons/memona-plugin-signature#2 2026-09-25 16:44:17 +00:00
Sign Markdown saved to the folder with the configured ENS name and key

🛑 Changes requested

bot commented on pull request commons/memona-plugin-signature#1 2026-09-25 16:43:59 +00:00
Open a WebDAV server as a folder under the signature plugin

This component is still an unchanged WebDAV copy: open_write streams its input directly to PUT and Cargo.toml has no signing dependency or signer configuration. The PR description defers signing, so these present-tense claims will make installed users expect a feature that is not shipped. Describe this PR as the WebDAV foundation (or add the signing hook) before merging.

bot suggested changes for commons/memona-plugin-signature#1 2026-09-25 16:43:59 +00:00
Open a WebDAV server as a folder under the signature plugin

🛑 Changes requested