Replace NodeJS dict aliases with maps and named field reads

Co-authored-by: Danny Kim <temeddix@gmail.com>
Co-committed-by: Danny Kim <temeddix@gmail.com>

.agents/memory/bot-agents-lint-opt-outs.md

@@ -1,21 +0,0 @@
----
-description: bot-agents lint has prefer-readonly-parameter-types and the size/complexity rules off (Deno had no limits) and no overrides; nothing else
----
-
-The repo follows [[lint-config-shape]] with one recorded exception, present
-when the migration PR was approved:
-
-- `typescript/prefer-readonly-parameter-types` is `"off"` in
-  `scripts/project-lint.ts`, as in the explicit-types template, because
-  Node/web types (`Response`, `Stats`, `RequestInit`) can never satisfy it.
-- `vite.config.ts` has no `overrides`. The `scripts/**` override for
-  `typescript/no-unsafe-enum-comparison` was removed (2026-10-16):
-  `scripts/project-lint.ts` compares node types with `AST_NODE_TYPES` members
-  from `@typescript-eslint/types` instead of string literals
-  ([[lint-overrides-policy]]).
-
-Size and complexity limits match Deno, which had none here, so every Oxlint
-limit rule is `"off"` ([[lint-config-shape]]). `src/run/index.ts` and `src/post/index.ts` keep
-main's single-file layout (2026-10-17 revert of the size splits). Sequential
-awaits in loops became recursion or a `reduce` chain (`no-await-in-loop`) to
-stay sequential. Add no other opt-out without the user.

.agents/memory/bot-agents-migration-decisions.md

@@ -21,13 +21,11 @@ Node + Vite+ migration (PR #20, `node-migration`, 2026-10-15/16):
 - **Published lint plugins** (2026-10-18, after they reached npm):
   `eslint-plugin-import-structure` (`modules` config) and
   `eslint-plugin-explicit-types` (`concrete` and `absence` configs) are
-  devDependencies, enabled in `vite.config.ts`. explicit-types' `naming`
-  config is left off: its `upper-snake-string-unions` and
-  `no-upper-snake-object-keys` rules fire on wire tokens this repo does not
-  name (profile types such as `"claude"`, failure reasons posted to Gitea,
-  environment variable names), which cannot change without changing
-  behavior. Open question for the user. `eslint-plugin-lit-robust` does not apply
-  (no Lit).
+  devDependencies, enabled in `vite.config.ts` through their `all` configs.
+  `upper-snake-string-unions` was off while the user decided; since
+  2026-10-19 it is on and profile types, failure reasons, and anchor sides
+  are `UPPER_SNAKE` ([[enum-values-upper-snake]]). `eslint-plugin-lit-robust`
+  does not apply (no Lit).
 - **Stricter input checks were accepted** in the migration: Gitea `/user` and
   comment responses, the runtime manifest, and the outcome's profile type are
   validated; some type errors became `TypeError` with the same messages.

.agents/memory/enum-values-upper-snake.md

@@ -0,0 +1,48 @@
+---
+description: Enum-like string values are UPPER_SNAKE everywhere this repo owns the format, JSON included; external standards are converted at the boundary with explicit switch functions
+---
+
+Decided 2026-10-19 (all repos). An enum-like string value, a member of a
+string-literal union, is `UPPER_SNAKE` wherever this repo owns the format:
+TypeScript unions, `profiles.json`, the runtime outcome file, and the
+`anchors.json` the agent writes per `prompt.md`. explicit-types
+`upper-snake-string-unions` enforces it and stays on.
+
+A value an outside party defines (a CLI flag, an environment variable name,
+an HTTP API field, a human-readable message) is converted at the boundary by
+an explicit `switch` function, never by renaming our own values to match it:
+
+```ts
+export interface ProfileIdentity {
+  type: "CLAUDE" | "CODEX" | "OPENCODE";
+  model: string;
+}
+
+// The agent name the skills installer knows each profile type by.
+function skillsAgent(type: RuntimeProfile["type"]): string {
+  switch (type) {
+    case "CLAUDE":
+      return "claude-code";
+    case "CODEX":
+      return "codex";
+    case "OPENCODE":
+      return "opencode";
+  }
+}
+```
+
+In this repo:
+
+- Profile `type`: `CLAUDE`, `CODEX`, `OPENCODE` (also in `profiles.json`).
+  `skillsAgent()` (run phase) and `tokenVariable()` (profiles) map them to the
+  installer's agent name and the credential environment variable;
+  `defaultModel()` (credentials) picks a model.
+- `FailureReason`: `SIGN_IN_FAILED`, `USAGE_EXHAUSTED`, `FAILED`; `toMessage()`
+  gives the words that logs and posted comments show.
+- Anchor `side`: `NEW` or `OLD` (`prompt.md` tells the agent so); the Gitea
+  review call turns it into `new_position` / `old_position`.
+
+A lookup object keyed by enum values would need `UPPER_SNAKE` keys, which
+explicit-types `no-upper-snake-object-keys` bans, so use a `switch`. TypeScript
+checks such a switch for exhaustiveness through the declared return type; no
+`default:` branch ([[lint-config]]).

.agents/memory/imports-aliases-barrels.md

@@ -72,7 +72,7 @@ import { x } from "../x.ts"; // no: no ../ anywhere
 - An area used from outside exposes its API through its alias target, and
   callers import the alias (`#ui`), not files inside it.
 - Barrels are also the standard fix for `import/max-dependencies`: one barrel
-  import replaces many direct ones ([[lint-overrides-policy]]).
+  import replaces many direct ones ([[lint-config]]).
 - `import/no-cycle` is on; a barrel must not create a cycle.
 
 Relative imports are written with the `.ts` extension.

.agents/memory/lint-config-shape.md

@@ -1,48 +0,0 @@
----
-description: vite.config.ts lint uses Oxlint categories at error with Deno size limits, names no rule itself, and spreads configs from the plugins and scripts/project-lint.ts
----
-
-The lint config is short and category-driven (user decisions 2026-10-14/15):
-turn on whole categories, then list only what parity or a real need adds.
-
-```ts
-lint: {
-  plugins: ["typescript", "unicorn", "oxc", "import"],
-  jsPlugins: ["eslint-plugin-explicit-types", "./scripts/project-lint.ts"],
-  categories: { correctness: "error", suspicious: "error", pedantic: "error", perf: "error" },
-  rules: { ...explicitTypes.configs.concrete.rules, ...projectLint.configs.project.rules },
-  ignorePatterns: ["src/generated/**"], // generated files only, see below
-  options: { typeAware: true, typeCheck: true, maxWarnings: 0, reportUnusedDisableDirectives: "error" },
-},
-```
-
-- **Categories:** `correctness`, `suspicious`, `pedantic`, `perf` at `error`.
-  `style` and `restriction` are never turned on wholesale; pick single rules
-  from them in `configs.project`. Extra rules that categories bring are fine.
-- **Size limits match Deno** (2026-10-17, replaces the 2026-10-16 "default
-  limits stay"): repos behave as they did on Deno. bot-agents ran `deno lint`
-  with no config, so it had no size or complexity limit, and every Oxlint
-  limit rule (`complexity`, `max-lines`, `max-params`, `id-length`,
-  `no-nested-ternary`, `max-lines-per-function`, `max-classes-per-file`,
-  `max-depth`, `max-nested-callbacks`, `max-statements`,
-  `import/max-dependencies`, `unicorn/max-nested-calls`) is `"off"` in
-  `configs.project`. No file is split for size. Do not add new opt-outs
-  anywhere without asking the user.
-- **`vite.config.ts` names no rule.** Every rule id, built-in ones included,
-  lives in `configs.project` of `scripts/project-lint.ts`
-  ([[project-lint-plugin]]). `vite.config.ts` only spreads configs.
-- **Published plugins are consumed through their configs**: ESLint flat config
-  uses `plugin.configs.<name>`; Oxlint lists the package in `jsPlugins` and
-  spreads `plugin.configs.<name>.rules`, since Oxlint plugins carry no configs.
-  Use the configs equivalent to what the repo enabled under Deno.
-- **`maxWarnings: 0`** keeps Deno's "every diagnostic fails" behaviour.
-- **`ignorePatterns`** is only for generated files (compiled output, codegen).
-  Hand-written code is never ignored.
-- **No lint disable comments**: [[lint-no-disable-comments]].
-- **Parity:** [[lint-parity-never-shrinks]]. **Naming:** [[naming-id-match]].
-- Don't add a second import sorter; the import-structure plugin's
-  `enforce-import-order` is the only one, and Oxfmt's `sortImports` stays off.
-
-`perf` came last: in the template it flagged nine `.includes` on constant
-arrays, fixed as `ReadonlySet` + `.has()` rather than by turning a rule off.
-That is the expected response to any new rule: change the code.

.agents/memory/lint-config.md

@@ -0,0 +1,102 @@
+---
+description: Lint config shape: every non-nursery Oxlint category on, plugins via `all`, a blacklist of offs in configs.project, per-file exceptions only in projectOverrides, ignorePatterns only for generated output
+---
+
+Policy (2026-10-19): a blacklist, not a whitelist. Replaces the older
+category-subset and "no overrides" notes.
+
+- **Categories:** `correctness`, `suspicious`, `pedantic`, `perf`, `style`,
+  `restriction` at `error`. `nursery` stays off (no line for it).
+- **Plugins** are enabled whole through their `all` config
+  (`explicitTypes.configs.all.rules`, `importStructure.configs.all.rules`).
+- **Blacklist:** repo-wide offs and option tweaks live in
+  `projectLint.configs.project.rules` in `scripts/project-lint.ts`, spread
+  last in `rules`, each with a one-line reason. Never re-list a rule a
+  category already turns on. bot-agents runs on Node everywhere, so
+  `import/no-nodejs-modules`, `unicorn/no-process-exit`, and `no-console` are
+  off repo-wide.
+- **Per-file exceptions** only via `projectOverrides`, the whole `overrides`
+  array exported from `scripts/project-lint.ts`: the Node code entry
+  (`vite.config.ts`, `scripts/**`, `nodeRules`) first, then one entry per
+  exception with a why-comment. `vite.config.ts` has exactly
+  `overrides: projectOverrides`.
+- **No `allowFiles`** options in custom rules, and no disable comments
+  ([[lint-no-disable-comments]]).
+- **`ignorePatterns`** only for generated or build output, never hand-written
+  code. A hand-written file is linted, with override entries for only what it
+  legitimately breaks. bot-agents has no generated code, so none.
+- **Precedence:** categories < `rules` (a later spread wins) < `overrides` (a
+  later entry wins).
+- Size and complexity limits (`complexity`, `max-lines`, ...) are set to the
+  smallest value the current code passes.
+
+```ts
+// scripts/project-lint.ts
+export const projectOverrides: OxlintOverride[] = [
+  { files: ["vite.config.ts", "scripts/**"], rules: nodeRules },
+  // Why: src/example.ts must ... (a per-file exception, if one is ever needed)
+  // { files: ["src/example.ts"], rules: { "some-rule": "off" } },
+];
+
+// vite.config.ts
+rules: {
+  ...explicitTypes.configs.all.rules,
+  ...importStructure.configs.all.rules,
+  ...projectLint.configs.project.rules,
+},
+overrides: projectOverrides,
+```
+
+## Rule decisions (2026-10-19, all repos)
+
+- `typescript/promise-function-async` is on with `require-await` and
+  `typescript/return-await`. A function that returns a promise is `async`
+  and awaits it: `async f() { const x = await g(); return x; }`. Test
+  doubles do the same (`const resolved = await Promise.resolve(v); return
+  resolved;`), and `expect(promise).rejects` takes the promise itself.
+  `src/processes/child.ts` is exempt in `projectOverrides`: `exitCode` must
+  return the very promise it marks handled, or a failed spawn would surface
+  as an unhandled rejection before callers await it.
+- `init-declarations` is on: an uninitialized `let` becomes
+  `let x: T | null = null;` (`unknown` already includes `null`); a `try` that
+  assigns and a `catch` that exits still narrow it.
+- `no-use-before-define` is on with only `{ functions: false }`.
+- `no-await-in-loop` is off (sequential awaits are intentional) and
+  `unicorn/no-array-reduce` is on: sequential steps are plain `for` loops,
+  never `reduce` chains or recursion.
+- `consistent-return`, `typescript/switch-exhaustiveness-check`, and
+  `default-case` are off: TypeScript's checks cover them, and no `default:`
+  branch is added to an exhaustive switch.
+- `unknown` is allowed; `any` is banned and the `typescript/no-unsafe-*`
+  rules are on. Untrusted data is `unknown` plus a type guard.
+- `unicorn/no-array-for-each` (use `for...of`),
+  `unicorn/prefer-structured-clone`, and `typescript/prefer-nullish-coalescing`
+  (defaults) stay on.
+- explicit-types `upper-snake-string-unions` is on
+  ([[enum-values-upper-snake]]); `unicorn/custom-error-definition` is on, so a
+  custom error has a constructor that sets `this.name`.
+- `src/post/` and `src/profiles/` (code and tests) are exempt from
+  `project/prefer-ascii` in `projectOverrides`: posted Gitea text shows emoji
+  verdict marks and a middle dot.
+
+## Rule decisions (2026-10-20, all repos)
+
+- `unicorn/number-literal-case` is off: Oxfmt lowercases hex digits back.
+- `typescript/consistent-return` is off too: it misfires on complete
+  switches, like `consistent-return`.
+- On with defaults, no offs: `prefer-object-spread`, `unicorn/prefer-spread`,
+  `unicorn/no-useless-spread`, `typescript/no-misused-spread`, `no-plusplus`
+  (`x += 1`), `unicorn/no-array-method-this-argument`,
+  `typescript/method-signature-style` ("property"),
+  `typescript/unified-signatures`.
+- `unicorn/import-style` uses its default: `import nodePath from "node:path"`
+  and `nodePath.join(...)` (`nodePath`, since `path` is a common variable).
+- `no-template-curly-in-string` is on; only `tests/workflow.test.ts`, which
+  checks literal Gitea `${{ }}` expressions, is exempt in `projectOverrides`.
+- Rule defaults are preferred over option tweaks unless a tweak is needed.
+- `fmt` matches `deno fmt`: `printWidth: 80`, `quoteProps: "preserve"`,
+  `embeddedLanguageFormatting: "off"`. `max-lines-per-function` is 124 after
+  the narrower width.
+
+A new category hit is fixed in the code; an off or exception is added only
+for a real collision or churn, with its reason. Rules: [[project-lint-plugin]].

.agents/memory/lint-overrides-policy.md

@@ -1,33 +0,0 @@
----
-description: No lint overrides for source files; narrow ones only for scripts/**; generated files go in ignorePatterns; size limits match Deno, so nothing is split for size
----
-
-Final policy (2026-10-16). The user considers per-file `overrides` bad
-practice.
-
-- **Source files: never.** No `overrides` entry may target `src/**` or any
-  other hand-written production or test code.
-- **The one exception** is in lint-plugin repos: `import/max-dependencies`
-  off for `src/rules/index.ts`, the rule registry, which must import every
-  rule. It is not a precedent for apps.
-- **`scripts/**`:** a narrow override is allowed when a tooling script truly
-  needs it, e.g. `no-console` in a CLI script.
-- **Generated files:** list them in `ignorePatterns`, never `overrides`.
-- **Anything else needs the user's approval first.** When the user is away,
-  don't add it: refactor, or leave the violation failing and log the question.
-
-## Fix the code instead
-
-Category rule violations are fixed in the code without behavior change,
-covered by the tests, inside the same migration PR; e.g. `prefer-set-has`
-becomes `const K: ReadonlySet<string> = new Set([...])` with `.has`.
-
-Size and complexity limits are not refactored for: they match what Deno
-enforced (2026-10-17, replacing the earlier "refactor to Oxlint's defaults"),
-which for bot-agents is none, so those rules are `"off"`
-([[lint-config-shape]]).
-
-Alias rule: an alias may point anywhere and owns its target (a folder's
-`index.ts` owns the folder and below, any other file owns only itself); no
-two aliases may own the same file, and `../` is banned everywhere
-([[imports-aliases-barrels]]).

.agents/memory/project-lint-plugin.md

@@ -11,12 +11,19 @@ Oxlint plugin with `meta.name` `"project"`, loaded through `jsPlugins` in
   plugin configs: Deno parity rules, extras, per-rule options, and opt-outs,
   built-in Oxlint ids included (`curly`, `id-match`, `import/no-cycle`, ...).
 - **Custom rules**, enabled as `project/<rule>`. Every repo has
-  `no-disable-comments` and `no-asset-imports`; bot-agents has no others.
+  `no-disable-comments` and `no-asset-imports`. Since 2026-10-19 every repo
+  also has `prefer-ascii`, `no-nan` (a "no number" value is `null`, never
+  `NaN`), and the hugoalh `recommended` ports from
+  eslint-plugin-import-structure's own lint: `no-duplicate-typeofs`,
+  `no-empty-yield`, `no-unsafe-number`, `no-useless-continue`,
+  `no-duplicate-interfaces`, `no-duplicate-types`, `no-useless-type`, and
+  `no-modifier-private`. `no-duplicate-awaits` and `no-duplicate-voids` are
+  covered by `unicorn/no-unnecessary-await` and
+  `typescript/no-meaningless-void-operator`, and `no-enum` by explicit-types.
 
-`scripts/` stays flat; don't add `scripts/rules/`. If the plugin ever needs
-more files, they sit flat beside it and share the prefix
-(`project-lint-modules.ts`, ...); `scripts/project-lint.ts` keeps the plugin
-object and the rule list.
+`scripts/` stays flat; don't add `scripts/rules/`. All rules live in the one
+`scripts/project-lint.ts` (no file splitting), next to the plugin object and
+the rule list.
 
 ```ts
 import type { DummyRuleMap } from "vite-plus/lint";
@@ -52,5 +59,5 @@ export default plugin;
   and every repo should look the same.
 
 `scripts/` is tooling, not production code: never packed or published, and
-no tests. Narrow `overrides` for `scripts/**` are allowed when a script truly
-needs one (e.g. `no-console`); see [[lint-overrides-policy]].
+no tests. Its offs sit in the Node code entry of `projectOverrides`; see
+[[lint-config]].