From 2b51793c92a81fe26d75651b89dc852297f998d6 Mon Sep 17 00:00:00 2001 From: bot Date: Sun, 13 Sep 2026 23:48:04 +0000 Subject: [PATCH] Review on request (#9) A pull request comment that asks for a review now posts a real review, not a plain comment: the review file decides, the event no longer does. Verified with deno fmt, lint and check. Reviewed-on: https://git.capsulizers.com/commons/bot-agents/pulls/9 Co-authored-by: bot Co-committed-by: bot --- prompt.md | 3 ++- run.ts | 19 +++++++++++-------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/prompt.md b/prompt.md index 5398e75..ec16792 100644 --- a/prompt.md +++ b/prompt.md @@ -18,7 +18,8 @@ the head of the pull request when there is one, with full history and the author's push credentials. Read the code there, run its checks and tests when they bear on the task, and push from there. -For a `pull_request` event, review the PR without changing code, using the +For a `pull_request` event, and for a comment on a pull request that asks you to +review it, review the PR without changing code, using the `requesting-code-review` skill from superpowers: run its code reviewer template against the PR's base and head. Run the project's checks on the head and treat a failure as at least Important. Check the whole repository against the code rules diff --git a/run.ts b/run.ts index aa8f948..6c67a3b 100644 --- a/run.ts +++ b/run.ts @@ -59,10 +59,10 @@ async function postComment(body: string): Promise { }); } -// A pull request event is a review request, so the review is posted instead -// of the response. It comes through a file, because a final chat message picks -// up narration while a file's first line is written on purpose. That line is -// the verdict, matched whole; anything unexpected only comments, never +// A review is posted whenever the agent wrote one, whether a review request or +// a comment asked for it. It comes through a file, because a final chat message +// picks up narration while a file's first line is written on purpose. That line +// is the verdict, matched whole; anything unexpected only comments, never // approves. The mark in front is added here, so it is never part of the match. const REVIEW_PATH = `${await Deno.makeTempDir()}/review.md`; const VERDICTS: Record = { @@ -71,10 +71,13 @@ const VERDICTS: Record = { }; async function postResult(body: string): Promise { - if (EVENT !== "pull_request") return postComment(body); - const review = await Deno.readTextFile(REVIEW_PATH).catch(() => { - throw new Error(`no review was written to ${REVIEW_PATH}`); - }); + const review = await Deno.readTextFile(REVIEW_PATH).catch(() => null); + if (review === null) { + if (EVENT === "pull_request") { + throw new Error(`no review was written to ${REVIEW_PATH}`); + } + return postComment(body); + } const [verdict, ...rest] = review.split("\n"); const [event, mark] = VERDICTS[verdict.trim()] ?? ["COMMENT", "💬"]; await gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, {