Make bot review setup self-contained
Check / deno (pull_request) Successful in 34s

This commit is contained in:
2026-09-14 16:16:36 +09:00
parent 70d71aa4fd
commit 419439baf6
2 changed files with 18 additions and 34 deletions
+18 -19
View File
@@ -19,25 +19,24 @@ author's push credentials. Read the code there, run its checks and tests when
they bear on the task, and push from there. they bear on the task, and push from there.
For a `pull_request` event, and for a comment on a pull request that asks you to For a `pull_request` event, and for a comment on a pull request that asks you to
review it, review the PR without changing code, using the review it, review the PR without changing code against its base and head. Run
`requesting-code-review` skill from superpowers: run its code reviewer template the project's checks on the head and treat a failure as at least Important.
against the PR's base and head. Run the project's checks on the head and treat a Check the whole repository against the code rules at the end of this prompt, not
failure as at least Important. Check the whole repository against the code rules only the diff; a violation is at least Important even when the diff did not
at the end of this prompt, not only the diff; a violation is at least Important cause it. Write the complete review, and nothing else, to the file
even when the diff did not cause it. Write the complete review, and nothing `${REVIEW_PATH}`: it is posted verbatim as a pull request review from the bot
else, to the file `${REVIEW_PATH}`: it is posted verbatim as a pull request account, and your final response is not posted at all. The file's first line
review from the bot account, and your final response is not posted at all. The must be exactly the verdict and nothing else: `Approved` when the head is ready
file's first line must be exactly the verdict and nothing else: `Approved` when to merge, `Changes requested` otherwise. The mark in front of it is added when
the template's answer is yes, `Changes requested` otherwise. The mark in front posting, so write the words alone; any other first line is posted as a plain
of it is added when posting, so write the words alone; any other first line is comment, which wastes the run. Minor issues alone never block, and neither does
posted as a plain comment, which wastes the run. Minor issues alone never block, a finding the author has answered in the comment history below as intended or a
and neither does a finding the author has answered in the comment history below false alarm, once the code or docs make that clear. When the verdict is
as intended or a false alarm, once the code or docs make that clear. When the `Changes requested`, the second line names what must change in one line,
verdict is `Changes requested`, the second line names what must change in one addressed to the author; the author's own agent picks the fixes up, so never ask
line, addressed to the author; the author's own agent picks the fixes up, so `@bot` to make them. For UI changes, check that the result is aligned, clean,
never ask `@bot` to make them. For UI changes, check that the result is aligned, and pixel-perfect, and that included screenshots prove the intended result was
clean, and pixel-perfect, and that included screenshots prove the intended achieved.
result was achieved.
Every finding that belongs to one line of the diff goes on that line instead of Every finding that belongs to one line of the diff goes on that line instead of
into the body. Write those to `${ANCHORS_PATH}` as a JSON array, each entry into the body. Write those to `${ANCHORS_PATH}` as a JSON array, each entry
-15
View File
@@ -153,19 +153,6 @@ async function configureGitAuthor(): Promise<void> {
} }
} }
// The superpowers plugin gives the agent its skills, including the code review
// one that the prompt asks for. Both installs are idempotent on the persisted
// home.
async function installSuperpowers(bot: string): Promise<void> {
const commands = bot === "claude"
? [
["plugin", "marketplace", "add", "obra/superpowers-marketplace"],
["plugin", "install", "-y", "superpowers@superpowers-marketplace"],
]
: [["plugin", "add", "superpowers@openai-curated-remote"]];
for (const args of commands) await run(bot, args);
}
async function renderPrompt(): Promise<string> { async function renderPrompt(): Promise<string> {
const comments: GiteaComment[] = await (await gitea( const comments: GiteaComment[] = await (await gitea(
REVIEWER_TOKEN, REVIEWER_TOKEN,
@@ -200,7 +187,6 @@ async function runClaude(prompt: string): Promise<string> {
"Run `claude setup-token` locally and set the `bot-token` action input.", "Run `claude setup-token` locally and set the `bot-token` action input.",
); );
} }
await installSuperpowers("claude");
const claude = new Deno.Command("claude", { const claude = new Deno.Command("claude", {
args: [ args: [
"--print", "--print",
@@ -265,7 +251,6 @@ async function runCodex(prompt: string): Promise<string> {
}) })
.output(); .output();
if (!loggedIn.success) await codexDeviceLogin(); if (!loggedIn.success) await codexDeviceLogin();
await installSuperpowers("codex");
const file = await Deno.makeTempFile(); const file = await Deno.makeTempFile();
const status = await new Deno.Command("codex", { const status = await new Deno.Command("codex", {
args: [ args: [