Set the agreed tsconfig strictness flags and drop exactOptionalPropertyTypes

tests/entrypoints.test.ts

@@ -16,7 +16,7 @@ const PHASES: [phase: string, firstVariable: string][] = [
 
 test.each(PHASES)("Node loads the %s phase", async (phase, firstVariable) => {
   const path = fileURLToPath(new URL(`../src/${phase}.ts`, import.meta.url));
-  const result = await runCommand(process.execPath, [path], { PATH: process.env.PATH ?? "" });
+  const result = await runCommand(process.execPath, [path], { PATH: process.env["PATH"] ?? "" });
   expect(result.success).toBe(false);
   expect(result.stderr).toContain(`${firstVariable} is not set`);
 });

tests/workflow.test.ts

@@ -48,11 +48,11 @@ test("all committed YAML parses", async () => {
 
 test("the action exposes only the master key and scopes it to preparation", async () => {
   const action = await yaml("action.yml");
-  expect(Object.keys(mapping(action.inputs, "inputs"))).toStrictEqual(["master-key"]);
-  const steps = sequence(mapping(action.runs, "runs").steps, "runs.steps");
+  expect(Object.keys(mapping(action["inputs"], "inputs"))).toStrictEqual(["master-key"]);
+  const steps = sequence(mapping(action["runs"], "runs")["steps"], "runs.steps");
   for (const step of steps) {
-    if (typeof step.run === "string") {
-      expect(step.run.includes("\n"), String(step.name)).toBe(false);
+    if (typeof step["run"] === "string") {
+      expect(step["run"].includes("\n"), String(step["name"])).toBe(false);
     }
   }
   const checkout = findStep(steps, "uses", "actions/checkout@v4");
@@ -60,16 +60,16 @@ test("the action exposes only the master key and scopes it to preparation", asyn
   const agent = findStep(steps, "id", "agent");
   const post = findStep(steps, "id", "post");
   findStep(steps, "id", "source");
-  expect(mapping(checkout.with, "checkout.with").token).toBe("${{ gitea.token }}");
-  expect(mapping(prepare.env, "prepare.env").BOT_AGENTS_MASTER_KEY).toBe(
+  expect(mapping(checkout["with"], "checkout.with")["token"]).toBe("${{ gitea.token }}");
+  expect(mapping(prepare["env"], "prepare.env")["BOT_AGENTS_MASTER_KEY"]).toBe(
     "${{ inputs.master-key }}",
   );
   expect(JSON.stringify(agent).includes("BOT_AGENTS_MASTER_KEY")).toBe(false);
   expect(JSON.stringify(post).includes("BOT_AGENTS_MASTER_KEY")).toBe(false);
-  expect(mapping(agent.env, "agent.env").GITEA_TOKEN).toBe("${{ gitea.token }}");
-  assert(String(post.if).includes("always()"));
+  expect(mapping(agent["env"], "agent.env")["GITEA_TOKEN"]).toBe("${{ gitea.token }}");
+  assert(String(post["if"]).includes("always()"));
   for (const step of [prepare, agent, post]) {
-    assert(String(step.run).includes("steps.source.outputs.path"));
+    assert(String(step["run"]).includes("steps.source.outputs.path"));
   }
 });
 
@@ -118,17 +118,17 @@ test("module-relative runtime assets exist", async () => {
 
 test("the repository uses its trusted main action", async () => {
   const workflow = await yaml(".gitea/workflows/agents.yml");
-  const job = mapping(mapping(workflow.jobs, "jobs").agent, "jobs.agent");
-  const permissions = mapping(job.permissions, "jobs.agent.permissions");
+  const job = mapping(mapping(workflow["jobs"], "jobs")["agent"], "jobs.agent");
+  const permissions = mapping(job["permissions"], "jobs.agent.permissions");
   expect(permissions).toStrictEqual({
     code: "write",
     issues: "write",
     "pull-requests": "write",
   });
-  const steps = sequence(job.steps, "jobs.agent.steps");
-  expect(steps.findIndex((step) => step.uses === "./")).toStrictEqual(-1);
+  const steps = sequence(job["steps"], "jobs.agent.steps");
+  expect(steps.findIndex((step) => step["uses"] === "./")).toStrictEqual(-1);
   const trusted = findStep(steps, "uses", "https://git.capsulizers.com/commons/bot-agents@main");
-  expect(mapping(trusted.with, "trusted.with")["master-key"]).toBe(
+  expect(mapping(trusted["with"], "trusted.with")["master-key"]).toBe(
     "${{ secrets.BOT_AGENTS_MASTER_KEY }}",
   );
   expect(JSON.stringify(workflow).includes("gitea.actor != 'bot'")).toBe(true);
@@ -136,9 +136,9 @@ test("the repository uses its trusted main action", async () => {
 
 test("CI checks every phase and the root isolation suite", async () => {
   const workflow = await yaml(".gitea/workflows/check.yml");
-  const job = mapping(mapping(workflow.jobs, "jobs").check, "jobs.check");
-  const commands = sequence(job.steps, "jobs.check.steps")
-    .map((step) => (typeof step.run === "string" ? step.run : ""))
+  const job = mapping(mapping(workflow["jobs"], "jobs")["check"], "jobs.check");
+  const commands = sequence(job["steps"], "jobs.check.steps")
+    .map((step) => (typeof step["run"] === "string" ? step["run"] : ""))
     .join("\n");
   // `vp check` type-checks every phase, and `vp test` runs each of them under
   // Node as well as the root-only isolation tests.
@@ -170,8 +170,8 @@ test("profile preparation does not receive provider credentials", async () => {
 
 test("central profiles fall back from Codex to Claude to OpenCode", async () => {
   const credentials: unknown = JSON.parse(await readFile("profiles.json", "utf8"));
-  const profiles = sequence(mapping(credentials, "profiles.json").profiles, "profiles");
-  expect(profiles.map((profile) => profile.type)).toStrictEqual(["codex", "claude", "opencode"]);
-  expect(profiles[2]?.model).toBe("openrouter/qwen/qwen3.8-27b");
-  assert(String(profiles[2]?.token).startsWith("v1:"));
+  const profiles = sequence(mapping(credentials, "profiles.json")["profiles"], "profiles");
+  expect(profiles.map((profile) => profile["type"])).toStrictEqual(["codex", "claude", "opencode"]);
+  expect(profiles[2]?.["model"]).toBe("openrouter/qwen/qwen3.8-27b");
+  assert(String(profiles[2]?.["token"]).startsWith("v1:"));
 });