Turn off no-await-in-loop, consistent-return and switch-exhaustiveness-check, turn on no-array-reduce, and restore the plain loops

src/profiles/profiles.ts

@@ -53,37 +53,26 @@ export function failureFooter(failures: ProfileFailure[]): string {
     .join(", ")}`;
 }
 
-// Tries the profiles from `index` on, moving on only after a sign-in failure
-// or exhausted usage, and records every profile it tried.
-async function attemptFrom<T, P extends ProfileIdentity>(
-  profiles: P[],
-  attempt: (profile: P) => Promise<T>,
-  failures: ProfileFailure[],
-  index: number,
-): Promise<T> {
-  const profile = profiles[index];
-  if (profile === undefined) {
-    throw new Error("profiles must contain at least one profile");
-  }
-  try {
-    return await attempt(profile);
-  } catch (error) {
-    const reason = failureReason(error);
-    failures.push({ type: profile.type, model: profile.model, reason });
-    if (reason === "failed" || index === profiles.length - 1) {
-      throw error;
-    }
-    console.error(`${profile.type} ${reason}; trying next profile`);
-    return attemptFrom(profiles, attempt, failures, index + 1);
-  }
-}
-
-export function runProfiles<T, P extends ProfileIdentity>(
+// Tries the profiles in order, moving on only after a sign-in failure or
+// exhausted usage, and records every profile it tried.
+export async function runProfiles<T, P extends ProfileIdentity>(
   profiles: P[],
   attempt: (profile: P) => Promise<T>,
   failures: ProfileFailure[] = [],
 ): Promise<T> {
-  return attemptFrom(profiles, attempt, failures, 0);
+  for (const [index, profile] of profiles.entries()) {
+    try {
+      return await attempt(profile);
+    } catch (error) {
+      const reason = failureReason(error);
+      failures.push({ type: profile.type, model: profile.model, reason });
+      if (reason === "failed" || index === profiles.length - 1) {
+        throw error;
+      }
+      console.error(`${profile.type} ${reason}; trying next profile`);
+    }
+  }
+  throw new Error("profiles must contain at least one profile");
 }
 
 // Environments are maps from variable name to value, converted to the object