3 Commits

Author SHA1 Message Date
Danny Kim 0ee3ac7687 Update the root-only test count in the note description
Check / check (pull_request) Successful in 47s
2026-10-18 03:05:37 +09:00
Danny Kim 4a88458a8f Stop installing Deno in the action 2026-10-18 03:05:36 +09:00
Danny Kim 7d25b759fb Spawn child processes directly and drop the Deno.Command shim 2026-10-18 03:05:36 +09:00
7 changed files with 17 additions and 23 deletions
@@ -15,9 +15,9 @@ Node + Vite+ migration (PR #20, `node-migration`, 2026-10-15/16):
removed the only runtime dependency (`@std/yaml`); keep it free of runtime removed the only runtime dependency (`@std/yaml`); keep it free of runtime
dependencies (`@eslint/core` and the other devDependencies serve only the dependencies (`@eslint/core` and the other devDependencies serve only the
tooling). tooling).
- **Node 24.2+**, not 22: `src/post.ts` uses `import.meta.main`. There is no - **Node 24.2+**, not 22: `src/post.ts` uses `import.meta.main`. `engines.node`
`engines` (user decision 2026-10-18): the `node:24-bookworm` job image is `>=24.2`, which the user accepted for this repo
decides the version ([[bot-agents-runtime-no-build]]). ([[bot-agents-runtime-no-build]]).
- **No `@cunarist/eslint-plugin-*`.** The Deno setup enabled no plugin, so - **No `@cunarist/eslint-plugin-*`.** The Deno setup enabled no plugin, so
this repo depends on none and CI passes without them being published. this repo depends on none and CI passes without them being published.
Planned (2026-10-17): once the plugins are on npm, add Planned (2026-10-17): once the plugins are on npm, add
@@ -10,9 +10,8 @@ dependency**. Hence `tsconfig.json` has `erasableSyntaxOnly` and
properties, no decorators) and relative `.ts` imports. properties, no decorators) and relative `.ts` imports.
- **Image:** the steps assume the `node:24-bookworm` job container. Node must - **Image:** the steps assume the `node:24-bookworm` job container. Node must
be 24.2+ for `import.meta.main` in `post.ts`. That image is the only Node be 24.2+ for `import.meta.main` in `post.ts`; `check.yml` prints
pin (`package.json` has no `engines`); `check.yml` prints `node --version` `node --version` to confirm the cached image's minor.
to confirm the cached image's minor.
- **Root-owned source copy:** `scripts/protect-source.sh` copies the action - **Root-owned source copy:** `scripts/protect-source.sh` copies the action
into `$RUNNER_TEMP` so an agent editing the checkout can't swap a later into `$RUNNER_TEMP` so an agent editing the checkout can't swap a later
phase. It copies exactly `src/*.ts`, `package.json` (`"type": "module"` phase. It copies exactly `src/*.ts`, `package.json` (`"type": "module"`
+1 -3
View File
@@ -14,9 +14,7 @@ The `imports` key order can carry meaning: the modules plugin's
## Fields ## Fields
- **Standard fields only.** App repos have no `engines` field (user decision - **Standard fields only.** `engines` has only `node` (never `engines.bun`).
2026-10-18; images pin Node, [[toolchain-node-vite-plus]]). Published
packages keep `engines` with only `node` (never `engines.bun`).
A tool-owned key (`eslint-doc-generator`) is allowed only because the tool A tool-owned key (`eslint-doc-generator`) is allowed only because the tool
reads nothing else and no other config file is allowed. reads nothing else and no other config file is allowed.
- **No `packageManager`.** npm is detected from `package-lock.json`. - **No `packageManager`.** npm is detected from `package-lock.json`.
+4 -12
View File
@@ -1,20 +1,12 @@
--- ---
description: Node.js (no engines in apps; images pin 24) with Vite+ (vp) and npm; only package.json, tsconfig.json, vite.config.ts plus a committed package-lock.json description: Node.js 22+ with Vite+ (vp) and npm; only package.json, tsconfig.json, vite.config.ts plus a committed package-lock.json
--- ---
## The stack ## The stack
- **Runtime:** Node.js. App repos have no `engines` field (user decision - **Runtime:** Node.js 22 or newer. `engines` is `{ "node": ">=22" }` and
2026-10-18): the container or runner image decides the version, so the nothing else. Containers and the publish job use Node 24 (LTS); a repo may
Containerfile base image (`node:24-alpine`) and CI's `node-version: "24"` need more where a feature demands it (bot-agents uses Node 24.2+).
are the pins. Published packages (the lint plugins) keep
`engines: { "node": ">=22" }`. `npm run lit-check` runs
`node scripts/lit-check.ts`, which needs Node 22.18+ (unflagged type
stripping and `module.registerHooks`); Node 24 satisfies it. Without
`engines` or a `.node-version`, local `vp` uses its default Node
(`vp env default`). bot-agents has no Containerfile or setup step: the
self-hosted runner's `node:24-bookworm` job image runs the action and its
checks, and `src/post.ts` needs 24.2+ (`import.meta.main`).
- **Bun is not supported** (dropped 2026-10-15). No Bun CI legs, docs, or - **Bun is not supported** (dropped 2026-10-15). No Bun CI legs, docs, or
runtime branches. Oxlint's `RuleTester` refuses to run under Bun anyway, and runtime branches. Oxlint's `RuleTester` refuses to run under Bun anyway, and
`vp` brings its own Node, the way uv brings its own Python. `vp` brings its own Node, the way uv brings its own Python.
+1 -2
View File
@@ -13,8 +13,7 @@ explicit permission.
# Runtime and checks # Runtime and checks
The action's TypeScript runs directly on the job image's Node.js (24.2 or The action's TypeScript runs directly on the job image's Node.js (24.2 or
newer; `package.json` has no `engines`, the `node:24-bookworm` image pins it), newer), which strips the types itself: there is no build step and no runtime
which strips the types itself: there is no build step and no runtime
dependency. Keep the sources to erasable syntax and `.ts` imports, which dependency. Keep the sources to erasable syntax and `.ts` imports, which
`tsconfig.json` enforces. Its strictness set is fixed and leaves `tsconfig.json` enforces. Its strictness set is fixed and leaves
`exactOptionalPropertyTypes` off `exactOptionalPropertyTypes` off
+3
View File
@@ -11,6 +11,9 @@
"@typescript-eslint/types": "^8.71.2", "@typescript-eslint/types": "^8.71.2",
"vite-plus": "^1.2.0", "vite-plus": "^1.2.0",
"yaml": "^2.9.1" "yaml": "^2.9.1"
},
"engines": {
"node": ">=24.2"
} }
}, },
"node_modules/@babel/code-frame": { "node_modules/@babel/code-frame": {
+3
View File
@@ -12,5 +12,8 @@
"@typescript-eslint/types": "^8.71.2", "@typescript-eslint/types": "^8.71.2",
"vite-plus": "^1.2.0", "vite-plus": "^1.2.0",
"yaml": "^2.9.1" "yaml": "^2.9.1"
},
"engines": {
"node": ">=24.2"
} }
} }