Compare commits
15 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 0920a4e91b | |||
| 627458fb5f | |||
| 50df193a8c | |||
| 5b568f9ea6 | |||
| 60c63dee98 | |||
| 0a31dbb820 | |||
| 6ad859be62 | |||
| 8b5c249248 | |||
| 5af53b0882 | |||
| eba9b9c57c | |||
| 3cbe4171ea | |||
| cd1864e1a9 | |||
| 0c5059e3b4 | |||
| c6fc183ad6 | |||
| 1f54518320 |
@@ -1,5 +1,5 @@
|
|||||||
---
|
---
|
||||||
description: bot-agents lint has prefer-readonly-parameter-types off (Node/web types can't satisfy it) and no overrides; nothing else
|
description: bot-agents lint has prefer-readonly-parameter-types and the size/complexity rules off (Deno had no limits) and no overrides; nothing else
|
||||||
---
|
---
|
||||||
|
|
||||||
The repo follows [[lint-config-shape]] with one recorded exception, present
|
The repo follows [[lint-config-shape]] with one recorded exception, present
|
||||||
@@ -14,8 +14,8 @@ when the migration PR was approved:
|
|||||||
from `@typescript-eslint/types` instead of string literals
|
from `@typescript-eslint/types` instead of string literals
|
||||||
([[lint-overrides-policy]]).
|
([[lint-overrides-policy]]).
|
||||||
|
|
||||||
Oxlint's default size limits apply to `src/`; the migration split `run.ts`
|
Size and complexity limits match Deno, which had none here, so every Oxlint
|
||||||
into `run-context.ts`, `agents.ts`, and `agent-{claude,codex,opencode}.ts`,
|
limit rule is `"off"` ([[lint-config-shape]]). `run.ts` and `post.ts` keep
|
||||||
and `post.ts` into `post.ts` + `post-artifacts.ts`, rather than raising them.
|
main's single-file layout (2026-10-17 revert of the size splits). Sequential
|
||||||
Sequential awaits in loops became recursion or a `reduce` chain to stay
|
awaits in loops became recursion or a `reduce` chain (`no-await-in-loop`) to
|
||||||
sequential. Add no other opt-out without the user.
|
stay sequential. Add no other opt-out without the user.
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
---
|
---
|
||||||
description: bot-agents migration decisions: live @main action for six repos, JSON profiles, Node 24.2+, Deno kept only for agents, no @cunarist plugins needed
|
description: bot-agents migration decisions: live @main action for six repos, JSON profiles, Node 24.2+, Deno kept only for agents, no eslint-plugin-* packages needed
|
||||||
---
|
---
|
||||||
|
|
||||||
Decisions for `commons/bot-agents` (Capsulizers Gitea), from the Deno to
|
Decisions for `commons/bot-agents` (Capsulizers Gitea), from the Deno to
|
||||||
@@ -15,15 +15,20 @@ Node + Vite+ migration (PR #20, `node-migration`, 2026-10-15/16):
|
|||||||
removed the only runtime dependency (`@std/yaml`); keep it free of runtime
|
removed the only runtime dependency (`@std/yaml`); keep it free of runtime
|
||||||
dependencies (`@eslint/core` and the other devDependencies serve only the
|
dependencies (`@eslint/core` and the other devDependencies serve only the
|
||||||
tooling).
|
tooling).
|
||||||
- **Node 24.2+**, not 22: `src/post.ts` uses `import.meta.main`. `engines.node`
|
- **Node 24.2+**, not 22: `src/post.ts` uses `import.meta.main`. There is no
|
||||||
is `>=24.2`, which the user accepted for this repo
|
`engines` (user decision 2026-10-18): the `node:24-bookworm` job image
|
||||||
([[bot-agents-runtime-no-build]]).
|
decides the version ([[bot-agents-runtime-no-build]]).
|
||||||
- **Deno stays in the action's global npm install** (`action.yml`), only
|
- **Deno stays in the action's global npm install** (`action.yml`), only
|
||||||
because the agents still check Deno-based consumer repos (memona,
|
because the agents still check Deno-based consumer repos (memona,
|
||||||
memona-home). Remove it once those repos have moved; it is not a
|
memona-home). Remove it once those repos have moved; it is not a
|
||||||
dependency of this repo's TypeScript.
|
dependency of this repo's TypeScript.
|
||||||
- **No `@cunarist/eslint-plugin-*`.** The Deno setup enabled no plugin, so
|
- **No `eslint-plugin-*` packages** (`eslint-plugin-explicit-types`,
|
||||||
this repo depends on none and CI passes without them being published.
|
`eslint-plugin-import-structure`, `eslint-plugin-lit-robust`; unscoped
|
||||||
|
since 2026-10-18, formerly `@cunarist/...`). The Deno setup enabled no
|
||||||
|
plugin, so this repo depends on none and CI passes without them being
|
||||||
|
published. Planned (2026-10-17): once the plugins are on npm, add
|
||||||
|
`eslint-plugin-import-structure` (rule prefix `import-structure/`) here for
|
||||||
|
its import checks.
|
||||||
- **Stricter input checks were accepted** in the migration: Gitea `/user` and
|
- **Stricter input checks were accepted** in the migration: Gitea `/user` and
|
||||||
comment responses, the runtime manifest, and the outcome's profile type are
|
comment responses, the runtime manifest, and the outcome's profile type are
|
||||||
validated; some type errors became `TypeError` with the same messages.
|
validated; some type errors became `TypeError` with the same messages.
|
||||||
|
|||||||
@@ -10,8 +10,9 @@ dependency**. Hence `tsconfig.json` has `erasableSyntaxOnly` and
|
|||||||
properties, no decorators) and relative `.ts` imports.
|
properties, no decorators) and relative `.ts` imports.
|
||||||
|
|
||||||
- **Image:** the steps assume the `node:24-bookworm` job container. Node must
|
- **Image:** the steps assume the `node:24-bookworm` job container. Node must
|
||||||
be 24.2+ for `import.meta.main` in `post.ts`; `check.yml` prints
|
be 24.2+ for `import.meta.main` in `post.ts`. That image is the only Node
|
||||||
`node --version` to confirm the cached image's minor.
|
pin (`package.json` has no `engines`); `check.yml` prints `node --version`
|
||||||
|
to confirm the cached image's minor.
|
||||||
- **Root-owned source copy:** `scripts/protect-source.sh` copies the action
|
- **Root-owned source copy:** `scripts/protect-source.sh` copies the action
|
||||||
into `$RUNNER_TEMP` so an agent editing the checkout can't swap a later
|
into `$RUNNER_TEMP` so an agent editing the checkout can't swap a later
|
||||||
phase. It copies exactly `src/*.ts`, `package.json` (`"type": "module"`
|
phase. It copies exactly `src/*.ts`, `package.json` (`"type": "module"`
|
||||||
|
|||||||
@@ -11,23 +11,25 @@ unbuilt. `vp pack` inlines them, so they never reach package consumers.
|
|||||||
|
|
||||||
One rule for every file, never tied to folder or file names (user rule
|
One rule for every file, never tied to folder or file names (user rule
|
||||||
2026-10-17; it replaces the earlier "aliases only point at direct `src/`
|
2026-10-17; it replaces the earlier "aliases only point at direct `src/`
|
||||||
subfolders" rule as the general rule, and the "modules plugin checks only
|
subfolders" rule as the general rule, and the "import-structure plugin
|
||||||
aliased folders" scope; this repo keeps the stricter rule as a local
|
checks only aliased folders" scope; this repo keeps the stricter rule as a
|
||||||
convention, see the last section):
|
local convention, see the last section):
|
||||||
|
|
||||||
- **An alias may point anywhere** and owns its target. An alias to a
|
- **An alias may point anywhere** and owns its target. An alias to a
|
||||||
folder's `index.ts` owns that folder and everything below it; an alias to
|
folder's `index.ts` owns that folder and everything below it; an alias to
|
||||||
any other file owns only that file.
|
any other file owns only that file.
|
||||||
- **No overlap.** No file may be owned by 2 aliases: no alias inside another
|
- **No overlap.** No file may be owned by 2 aliases: no alias inside another
|
||||||
alias's area, and no 2 aliases with the same target. the modules plugin's
|
alias's area, and no 2 aliases with the same target. The import-structure
|
||||||
`enforce-layer-order` reports it once at the top of every file 2 aliases
|
plugin's `enforce-layer-order` reports it once at the top of every file 2
|
||||||
claim. Fix by merging the aliases or moving files apart.
|
aliases claim. Fix by merging the aliases or moving files apart.
|
||||||
- **Outside an area, only the exact alias reaches it.** A deeper alias
|
- **Outside an area, only the exact alias reaches it.** A deeper alias
|
||||||
specifier (`#a/one.ts`, `no-barrel-bypass`) and a relative path into the
|
specifier (`#a/one.ts`, `no-barrel-bypass`) and a relative path into the
|
||||||
area (`./a/one.ts`, `no-relative-bypass`; `./b/f.ts` to a file alias,
|
area (`./a/one.ts`, `no-relative-bypass`; `./b/f.ts` to a file alias,
|
||||||
`prefer-alias-import`, fixed to the alias) are bypasses.
|
`prefer-alias-import`, fixed to the alias) are bypasses.
|
||||||
- **Inside an area, relative imports of siblings and subfolders are free.**
|
- **Inside an area, relative imports of siblings and subfolders are free.**
|
||||||
- **`../` is banned in every file**, owned or not (`no-parent-import`).
|
- **A `../` import is banned in every file**, owned or not (`no-parent-import`).
|
||||||
|
Runtime file URLs (`new URL("../prompt.md", import.meta.url)`) are not
|
||||||
|
imports and are allowed.
|
||||||
Anything above a file needs an alias.
|
Anything above a file needs an alias.
|
||||||
- **Files no alias owns** need no `index.ts` and no alias, and import `./`
|
- **Files no alias owns** need no `index.ts` and no alias, and import `./`
|
||||||
siblings and subfolders freely.
|
siblings and subfolders freely.
|
||||||
@@ -89,8 +91,8 @@ Relative imports are written with the `.ts` extension.
|
|||||||
## Local convention: aliases target direct `src/` subfolders
|
## Local convention: aliases target direct `src/` subfolders
|
||||||
|
|
||||||
This is a convention of this repo only, stricter than the general rule above
|
This is a convention of this repo only, stricter than the general rule above
|
||||||
(which the published modules plugin checks and which allows more). It is not
|
(which the published import-structure plugin checks and which allows more).
|
||||||
a plugin rule.
|
It is not a plugin rule.
|
||||||
|
|
||||||
- Every `package.json` `imports` alias points only at the `index.ts` of a
|
- Every `package.json` `imports` alias points only at the `index.ts` of a
|
||||||
direct subfolder of `src/`, e.g. `"#helpers": "./src/helpers/index.ts"`.
|
direct subfolder of `src/`, e.g. `"#helpers": "./src/helpers/index.ts"`.
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
---
|
---
|
||||||
description: vite.config.ts lint uses Oxlint categories at error with default limits, names no rule itself, and spreads configs from the plugins and scripts/project-lint.ts
|
description: vite.config.ts lint uses Oxlint categories at error with Deno size limits, names no rule itself, and spreads configs from the plugins and scripts/project-lint.ts
|
||||||
---
|
---
|
||||||
|
|
||||||
The lint config is short and category-driven (user decisions 2026-10-14/15):
|
The lint config is short and category-driven (user decisions 2026-10-14/15):
|
||||||
@@ -8,7 +8,7 @@ turn on whole categories, then list only what parity or a real need adds.
|
|||||||
```ts
|
```ts
|
||||||
lint: {
|
lint: {
|
||||||
plugins: ["typescript", "unicorn", "oxc", "import"],
|
plugins: ["typescript", "unicorn", "oxc", "import"],
|
||||||
jsPlugins: ["@cunarist/eslint-plugin-explicit-types", "./scripts/project-lint.ts"],
|
jsPlugins: ["eslint-plugin-explicit-types", "./scripts/project-lint.ts"],
|
||||||
categories: { correctness: "error", suspicious: "error", pedantic: "error", perf: "error" },
|
categories: { correctness: "error", suspicious: "error", pedantic: "error", perf: "error" },
|
||||||
rules: { ...explicitTypes.configs.concrete.rules, ...projectLint.configs.project.rules },
|
rules: { ...explicitTypes.configs.concrete.rules, ...projectLint.configs.project.rules },
|
||||||
ignorePatterns: ["src/generated/**"], // generated files only, see below
|
ignorePatterns: ["src/generated/**"], // generated files only, see below
|
||||||
@@ -19,13 +19,15 @@ lint: {
|
|||||||
- **Categories:** `correctness`, `suspicious`, `pedantic`, `perf` at `error`.
|
- **Categories:** `correctness`, `suspicious`, `pedantic`, `perf` at `error`.
|
||||||
`style` and `restriction` are never turned on wholesale; pick single rules
|
`style` and `restriction` are never turned on wholesale; pick single rules
|
||||||
from them in `configs.project`. Extra rules that categories bring are fine.
|
from them in `configs.project`. Extra rules that categories bring are fine.
|
||||||
- **Default limits stay** (2026-10-16): pedantic's `max-lines` 300,
|
- **Size limits match Deno** (2026-10-17, replaces the 2026-10-16 "default
|
||||||
`max-lines-per-function` 50, `max-classes-per-file` 1,
|
limits stay"): repos behave as they did on Deno. bot-agents ran `deno lint`
|
||||||
`max-dependencies` 10, `max-params` 3, `complexity` 20. Don't raise them to
|
with no config, so it had no size or complexity limit, and every Oxlint
|
||||||
make code pass; refactor (see [[lint-overrides-policy]]). `max-lines` stays
|
limit rule (`complexity`, `max-lines`, `max-params`, `id-length`,
|
||||||
at 300 everywhere, `scripts/` included, with no override (2026-10-16): split
|
`no-nested-ternary`, `max-lines-per-function`, `max-classes-per-file`,
|
||||||
a long file by theme instead. Do not add new opt-outs anywhere without
|
`max-depth`, `max-nested-callbacks`, `max-statements`,
|
||||||
asking the user.
|
`import/max-dependencies`, `unicorn/max-nested-calls`) is `"off"` in
|
||||||
|
`configs.project`. No file is split for size. Do not add new opt-outs
|
||||||
|
anywhere without asking the user.
|
||||||
- **`vite.config.ts` names no rule.** Every rule id, built-in ones included,
|
- **`vite.config.ts` names no rule.** Every rule id, built-in ones included,
|
||||||
lives in `configs.project` of `scripts/project-lint.ts`
|
lives in `configs.project` of `scripts/project-lint.ts`
|
||||||
([[project-lint-plugin]]). `vite.config.ts` only spreads configs.
|
([[project-lint-plugin]]). `vite.config.ts` only spreads configs.
|
||||||
@@ -38,8 +40,8 @@ lint: {
|
|||||||
Hand-written code is never ignored.
|
Hand-written code is never ignored.
|
||||||
- **No lint disable comments**: [[lint-no-disable-comments]].
|
- **No lint disable comments**: [[lint-no-disable-comments]].
|
||||||
- **Parity:** [[lint-parity-never-shrinks]]. **Naming:** [[naming-id-match]].
|
- **Parity:** [[lint-parity-never-shrinks]]. **Naming:** [[naming-id-match]].
|
||||||
- Don't add a second import sorter; the modules plugin's `enforce-import-order` is
|
- Don't add a second import sorter; the import-structure plugin's
|
||||||
the only one, and Oxfmt's `sortImports` stays off.
|
`enforce-import-order` is the only one, and Oxfmt's `sortImports` stays off.
|
||||||
|
|
||||||
`perf` came last: in the template it flagged nine `.includes` on constant
|
`perf` came last: in the template it flagged nine `.includes` on constant
|
||||||
arrays, fixed as `ReadonlySet` + `.has()` rather than by turning a rule off.
|
arrays, fixed as `ReadonlySet` + `.has()` rather than by turning a rule off.
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
---
|
---
|
||||||
description: No lint overrides for source files; narrow ones only for scripts/**; generated files go in ignorePatterns; refactor (barrels, splits) instead of raising limits
|
description: No lint overrides for source files; narrow ones only for scripts/**; generated files go in ignorePatterns; size limits match Deno, so nothing is split for size
|
||||||
---
|
---
|
||||||
|
|
||||||
Final policy (2026-10-16). The user considers per-file `overrides` bad
|
Final policy (2026-10-16). The user considers per-file `overrides` bad
|
||||||
@@ -18,31 +18,14 @@ practice.
|
|||||||
|
|
||||||
## Fix the code instead
|
## Fix the code instead
|
||||||
|
|
||||||
Oxlint's defaults stay; violations are refactored without behavior change,
|
Category rule violations are fixed in the code without behavior change,
|
||||||
covered by the tests, inside the same migration PR.
|
covered by the tests, inside the same migration PR; e.g. `prefer-set-has`
|
||||||
|
becomes `const K: ReadonlySet<string> = new Set([...])` with `.has`.
|
||||||
|
|
||||||
| Rule | Usual fix |
|
Size and complexity limits are not refactored for: they match what Deno
|
||||||
| ------------------------- | ------------------------------------------------------- |
|
enforced (2026-10-17, replacing the earlier "refactor to Oxlint's defaults"),
|
||||||
| `import/max-dependencies` | import a barrel (`#ui`) instead of many direct modules |
|
which for bot-agents is none, so those rules are `"off"`
|
||||||
| `max-lines` | split the file by responsibility |
|
([[lint-config-shape]]).
|
||||||
| `max-lines-per-function` | extract helpers |
|
|
||||||
| `max-classes-per-file` | one class per file |
|
|
||||||
| `max-params` | pass one options object |
|
|
||||||
| `prefer-set-has` | `const K: ReadonlySet<string> = new Set([...])`, `.has` |
|
|
||||||
|
|
||||||
```ts
|
|
||||||
// before: 14 imports, over the limit of 10
|
|
||||||
import { a } from "#ui/button";
|
|
||||||
import { b } from "#ui/dialog";
|
|
||||||
// after: one barrel
|
|
||||||
import { a, b } from "#ui";
|
|
||||||
```
|
|
||||||
|
|
||||||
Measured on memona before the move (Oxlint 1.87, default limits): 921
|
|
||||||
pedantic hits in 274 files, of which `max-lines-per-function` 206,
|
|
||||||
`max-lines` 145, `max-classes-per-file` 59, `max-dependencies` 45 (median 14
|
|
||||||
imports, worst 29). The user chose refactoring over raising limits or
|
|
||||||
matching memona's old hugoalh limits (2048 lines per file, no function limit).
|
|
||||||
|
|
||||||
Alias rule: an alias may point anywhere and owns its target (a folder's
|
Alias rule: an alias may point anywhere and owns its target (a folder's
|
||||||
`index.ts` owns the folder and below, any other file owns only itself); no
|
`index.ts` owns the folder and below, any other file owns only itself); no
|
||||||
|
|||||||
@@ -9,19 +9,21 @@ Oxfmt's standard `package.json` sorting is accepted: there is no
|
|||||||
replaces the earlier hand-written order (metadata, `scripts`, `exports`,
|
replaces the earlier hand-written order (metadata, `scripts`, `exports`,
|
||||||
`imports`, `devDependencies`, `dependencies`).
|
`imports`, `devDependencies`, `dependencies`).
|
||||||
|
|
||||||
The `imports` key order can carry meaning: the modules plugin's
|
The `imports` key order can carry meaning: the import-structure plugin's
|
||||||
`enforce-layer-order` reads it as the layer order. Never reorder it casually.
|
`enforce-layer-order` reads it as the layer order. Never reorder it casually.
|
||||||
|
|
||||||
## Fields
|
## Fields
|
||||||
|
|
||||||
- **Standard fields only.** `engines` has only `node` (never `engines.bun`).
|
- **Standard fields only.** App repos have no `engines` field (user decision
|
||||||
|
2026-10-18; images pin Node, [[toolchain-node-vite-plus]]). Published
|
||||||
|
packages keep `engines` with only `node` (never `engines.bun`).
|
||||||
A tool-owned key (`eslint-doc-generator`) is allowed only because the tool
|
A tool-owned key (`eslint-doc-generator`) is allowed only because the tool
|
||||||
reads nothing else and no other config file is allowed.
|
reads nothing else and no other config file is allowed.
|
||||||
- **No `packageManager`.** npm is detected from `package-lock.json`.
|
- **No `packageManager`.** npm is detected from `package-lock.json`.
|
||||||
- **No `peerDependencies`, ever** (user preference, 2026-10-14). If something
|
- **No `peerDependencies`, ever** (user preference, 2026-10-14). If something
|
||||||
is needed at runtime, it goes in `dependencies`.
|
is needed at runtime, it goes in `dependencies`.
|
||||||
- **`dependencies`** = what runs or is type-referenced at runtime by consumers
|
- **`dependencies`** = what runs or is type-referenced at runtime by consumers
|
||||||
(the lit plugin ships `parse5`, `oxc-parser`, `oxc-resolver`, and
|
(the lit-robust plugin ships `parse5`, `oxc-parser`, `oxc-resolver`, and
|
||||||
`@eslint/core` for its public types; they stay external, never bundled).
|
`@eslint/core` for its public types; they stay external, never bundled).
|
||||||
- **`devDependencies`** = everything else: `vite-plus`, `eslint`,
|
- **`devDependencies`** = everything else: `vite-plus`, `eslint`,
|
||||||
`@typescript-eslint/parser`, `eslint-doc-generator`, `esbuild`,
|
`@typescript-eslint/parser`, `eslint-doc-generator`, `esbuild`,
|
||||||
|
|||||||
@@ -13,10 +13,10 @@ Oxlint plugin with `meta.name` `"project"`, loaded through `jsPlugins` in
|
|||||||
- **Custom rules**, enabled as `project/<rule>`. Every repo has
|
- **Custom rules**, enabled as `project/<rule>`. Every repo has
|
||||||
`no-disable-comments` and `no-asset-imports`; bot-agents has no others.
|
`no-disable-comments` and `no-asset-imports`; bot-agents has no others.
|
||||||
|
|
||||||
`scripts/` stays flat; don't add `scripts/rules/`. A file that would pass
|
`scripts/` stays flat; don't add `scripts/rules/`. If the plugin ever needs
|
||||||
`max-lines` (300) splits into flat themed files sharing the prefix:
|
more files, they sit flat beside it and share the prefix
|
||||||
`scripts/project-lint.ts` keeps the plugin object and the rule list and
|
(`project-lint-modules.ts`, ...); `scripts/project-lint.ts` keeps the plugin
|
||||||
imports the others (`project-lint-modules.ts`, `project-lint-types.ts`, ...).
|
object and the rule list.
|
||||||
|
|
||||||
```ts
|
```ts
|
||||||
import type { DummyRuleMap } from "vite-plus/lint";
|
import type { DummyRuleMap } from "vite-plus/lint";
|
||||||
|
|||||||
@@ -1,12 +1,20 @@
|
|||||||
---
|
---
|
||||||
description: Node.js 22+ with Vite+ (vp) and npm; only package.json, tsconfig.json, vite.config.ts plus a committed package-lock.json
|
description: Node.js (no engines in apps; images pin 24) with Vite+ (vp) and npm; only package.json, tsconfig.json, vite.config.ts plus a committed package-lock.json
|
||||||
---
|
---
|
||||||
|
|
||||||
## The stack
|
## The stack
|
||||||
|
|
||||||
- **Runtime:** Node.js 22 or newer. `engines` is `{ "node": ">=22" }` and
|
- **Runtime:** Node.js. App repos have no `engines` field (user decision
|
||||||
nothing else. Containers and the publish job use Node 24 (LTS); a repo may
|
2026-10-18): the container or runner image decides the version, so the
|
||||||
need more where a feature demands it (bot-agents uses Node 24.2+).
|
Containerfile base image (`node:24-alpine`) and CI's `node-version: "24"`
|
||||||
|
are the pins. Published packages (the lint plugins) keep their own
|
||||||
|
`engines.node` floor. `npm run lit-check` runs
|
||||||
|
`node scripts/lit-check.ts`, which needs Node 22.18+ (unflagged type
|
||||||
|
stripping and `module.registerHooks`); Node 24 satisfies it. Without
|
||||||
|
`engines` or a `.node-version`, local `vp` uses its default Node
|
||||||
|
(`vp env default`). bot-agents has no Containerfile or setup step: the
|
||||||
|
self-hosted runner's `node:24-bookworm` job image runs the action and its
|
||||||
|
checks, and `src/post.ts` needs 24.2+ (`import.meta.main`).
|
||||||
- **Bun is not supported** (dropped 2026-10-15). No Bun CI legs, docs, or
|
- **Bun is not supported** (dropped 2026-10-15). No Bun CI legs, docs, or
|
||||||
runtime branches. Oxlint's `RuleTester` refuses to run under Bun anyway, and
|
runtime branches. Oxlint's `RuleTester` refuses to run under Bun anyway, and
|
||||||
`vp` brings its own Node, the way uv brings its own Python.
|
`vp` brings its own Node, the way uv brings its own Python.
|
||||||
|
|||||||
@@ -6,11 +6,17 @@ The user's rule, from the Deno days and restated for Node (2026-10-12): "No
|
|||||||
JS, not even JSX/TSX, only TS." Source, scripts, tests, and configs are all
|
JS, not even JSX/TSX, only TS." Source, scripts, tests, and configs are all
|
||||||
plain `.ts`. Build output in a gitignored folder is the only JS.
|
plain `.ts`. Build output in a gitignored folder is the only JS.
|
||||||
|
|
||||||
`tsconfig.json`: no `allowJs`, no `jsx`, and the template's strict flags
|
`tsconfig.json`: no `allowJs`, no `jsx`, and exactly this strictness set (user
|
||||||
(`verbatimModuleSyntax`, `erasableSyntaxOnly`, `allowImportingTsExtensions`,
|
decision, 2026-10-18): `strict` (written out), `noUncheckedIndexedAccess`,
|
||||||
`isolatedDeclarations` in packages, `exactOptionalPropertyTypes`,
|
`noPropertyAccessFromIndexSignature`, `noImplicitReturns`, `noUnusedLocals`,
|
||||||
`noUncheckedIndexedAccess`). If a tool or framework seems to need a JS or TSX
|
`noUnusedParameters`, `noImplicitOverride`, `noFallthroughCasesInSwitch`,
|
||||||
file, stop and flag it instead of adding one.
|
`erasableSyntaxOnly`, and `allowUnreachableCode: false` plus
|
||||||
|
`allowUnusedLabels: false` (user decision, 2026-10-18; on in the Deno setup),
|
||||||
|
plus the mechanical `verbatimModuleSyntax`, `allowImportingTsExtensions`, and
|
||||||
|
`noEmit` (packages also keep `declaration` and `isolatedDeclarations`).
|
||||||
|
`exactOptionalPropertyTypes` is off everywhere: write `{ key: maybeUndefined }`
|
||||||
|
rather than leaving the key out to please it. If a tool or framework seems to
|
||||||
|
need a JS or TSX file, stop and flag it instead of adding one.
|
||||||
|
|
||||||
## No asset imports (2026-10-14, widened 2026-10-16 and 2026-10-17)
|
## No asset imports (2026-10-14, widened 2026-10-16 and 2026-10-17)
|
||||||
|
|
||||||
|
|||||||
@@ -13,11 +13,15 @@ explicit permission.
|
|||||||
# Runtime and checks
|
# Runtime and checks
|
||||||
|
|
||||||
The action's TypeScript runs directly on the job image's Node.js (24.2 or
|
The action's TypeScript runs directly on the job image's Node.js (24.2 or
|
||||||
newer), which strips the types itself: there is no build step and no runtime
|
newer; `package.json` has no `engines`, the `node:24-bookworm` image pins it),
|
||||||
|
which strips the types itself: there is no build step and no runtime
|
||||||
dependency. Keep the sources to erasable syntax and `.ts` imports, which
|
dependency. Keep the sources to erasable syntax and `.ts` imports, which
|
||||||
`tsconfig.json` enforces. Checks use Vite+: `vp check` formats, lints, and
|
`tsconfig.json` enforces. Its strictness set is fixed and leaves
|
||||||
type-checks, and `vp test` runs Vitest. Unit tests sit next to the code as
|
`exactOptionalPropertyTypes` off
|
||||||
`src/*.test.ts`; repository-level tests live in `tests/`.
|
([.agents/memory/ts-only-files-and-imports.md](.agents/memory/ts-only-files-and-imports.md)).
|
||||||
|
Checks use Vite+: `vp check` formats, lints, and type-checks, and `vp test`
|
||||||
|
runs Vitest. Unit tests sit next to the code as `src/*.test.ts`;
|
||||||
|
repository-level tests live in `tests/`.
|
||||||
|
|
||||||
A `#` alias in `package.json` `imports` may point anywhere and owns its
|
A `#` alias in `package.json` `imports` may point anywhere and owns its
|
||||||
target: an alias to a folder's `index.ts` owns that folder and everything
|
target: an alias to a folder's `index.ts` owns that folder and everything
|
||||||
@@ -25,16 +29,17 @@ below it; an alias to any other file owns only that file. No overlap: no file
|
|||||||
may be owned by 2 aliases, so no alias inside another alias's area and no 2
|
may be owned by 2 aliases, so no alias inside another alias's area and no 2
|
||||||
aliases with the same target. Outside an area, only the exact alias reaches
|
aliases with the same target. Outside an area, only the exact alias reaches
|
||||||
it; a deeper alias specifier or a relative path into the area is a bypass.
|
it; a deeper alias specifier or a relative path into the area is a bypass.
|
||||||
Inside an area, relative imports of siblings and subfolders are free. `../`
|
Inside an area, relative imports of siblings and subfolders are free. A `../`
|
||||||
is banned in every file, owned or not
|
import is banned in every file, owned or not
|
||||||
(`import/no-relative-parent-imports`). Files no alias owns need no `index.ts`
|
(`import/no-relative-parent-imports`); runtime file URLs such as
|
||||||
and no alias, and import `./` siblings and subfolders freely. The one alias
|
`new URL("../prompt.md", import.meta.url)` are paths, not imports, and stay.
|
||||||
is `#testing` (`./src/testing/index.ts`): every test imports it by alias, and
|
Files no alias owns need no `index.ts` and no alias, and import `./` siblings
|
||||||
`tests/` reaches `src/` only through it. Local convention, stricter than the
|
and subfolders freely. The one alias is `#testing` (`./src/testing/index.ts`):
|
||||||
general rule above: in this repo, aliases point only at a direct subfolder of
|
tests that use its helpers import it by alias, and `tests/` imports `src/`
|
||||||
`src/` (`"#helpers": "./src/helpers/index.ts"`), and code outside `src/` uses
|
only through it. Local convention, stricter than the general rule above: in
|
||||||
`./` relative imports. `scripts/` is flat: one file per
|
this repo, aliases point only at a direct subfolder of `src/`
|
||||||
tool, no subfolders and no `index.ts`, imported directly by file path
|
(`"#helpers": "./src/helpers/index.ts"`), and code outside `src/` uses `./`
|
||||||
|
relative imports. `scripts/` is flat: one file per tool, no subfolders and no `index.ts`, imported directly by file path
|
||||||
([.agents/memory/imports-aliases-barrels.md](.agents/memory/imports-aliases-barrels.md)).
|
([.agents/memory/imports-aliases-barrels.md](.agents/memory/imports-aliases-barrels.md)).
|
||||||
|
|
||||||
The only config files are `package.json`, `tsconfig.json`, and
|
The only config files are `package.json`, `tsconfig.json`, and
|
||||||
|
|||||||
Generated
-3
@@ -11,9 +11,6 @@
|
|||||||
"@typescript-eslint/types": "^8.71.2",
|
"@typescript-eslint/types": "^8.71.2",
|
||||||
"vite-plus": "^1.2.0",
|
"vite-plus": "^1.2.0",
|
||||||
"yaml": "^2.9.1"
|
"yaml": "^2.9.1"
|
||||||
},
|
|
||||||
"engines": {
|
|
||||||
"node": ">=24.2"
|
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"node_modules/@babel/code-frame": {
|
"node_modules/@babel/code-frame": {
|
||||||
|
|||||||
@@ -12,8 +12,5 @@
|
|||||||
"@typescript-eslint/types": "^8.71.2",
|
"@typescript-eslint/types": "^8.71.2",
|
||||||
"vite-plus": "^1.2.0",
|
"vite-plus": "^1.2.0",
|
||||||
"yaml": "^2.9.1"
|
"yaml": "^2.9.1"
|
||||||
},
|
|
||||||
"engines": {
|
|
||||||
"node": ">=24.2"
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
+28
-3
@@ -1,6 +1,7 @@
|
|||||||
/**
|
/**
|
||||||
* `project` — lint rules this repository holds its own source to, on top of
|
* `project` — lint rules this repository holds its own source to, on top of
|
||||||
* the Oxlint categories in `vite.config.ts`. Its rules of its own are `no-disable-comments` and `no-asset-imports`.
|
* the Oxlint categories in `vite.config.ts`. Its rules of its own are
|
||||||
|
* `no-disable-comments` and `no-asset-imports`.
|
||||||
*
|
*
|
||||||
* Loaded by `vite.config.ts` as an Oxlint `jsPlugins` entry.
|
* Loaded by `vite.config.ts` as an Oxlint `jsPlugins` entry.
|
||||||
*
|
*
|
||||||
@@ -161,8 +162,8 @@ const noAssetImportsRule: ProjectRule = {
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* This repository's own rule list, spread by `vite.config.ts`: rules that
|
* This repository's own rule list, spread by `vite.config.ts`: rules that
|
||||||
* sit outside the Oxlint categories, plus the template's extras. Built-in Oxlint rule ids sit here too, so
|
* sit outside the Oxlint categories, plus the template's extras. Built-in
|
||||||
* `vite.config.ts` lists no rule by name.
|
* Oxlint rule ids sit here too, so `vite.config.ts` lists no rule by name.
|
||||||
*/
|
*/
|
||||||
const rules: DummyRuleMap = {
|
const rules: DummyRuleMap = {
|
||||||
// The explicit-types template's `camelcase` stand-in: no `_` inside a name
|
// The explicit-types template's `camelcase` stand-in: no `_` inside a name
|
||||||
@@ -219,6 +220,30 @@ const rules: DummyRuleMap = {
|
|||||||
"project/no-disable-comments": "error",
|
"project/no-disable-comments": "error",
|
||||||
"project/no-asset-imports": "error",
|
"project/no-asset-imports": "error",
|
||||||
"unicorn/no-abusive-eslint-disable": "error",
|
"unicorn/no-abusive-eslint-disable": "error",
|
||||||
|
// Size and complexity limits match Deno's: this repo's `deno lint` ran the
|
||||||
|
// `recommended` set with no config file, so no size or complexity rule
|
||||||
|
// applied and none applies here. Each Oxlint limit rule, from a category or
|
||||||
|
// not, is off:
|
||||||
|
// - `complexity`: Deno had no `max-complexity`.
|
||||||
|
// - `max-lines`: Deno had no `max-file-lines`.
|
||||||
|
// - `max-params`: Deno had no `max-params`.
|
||||||
|
// - `id-length`: Deno had no `max-identifier-length`.
|
||||||
|
// - `no-nested-ternary`: Deno had no `max-nest-ternaries`.
|
||||||
|
// - `max-lines-per-function`, `max-classes-per-file`, `max-depth`,
|
||||||
|
// `max-nested-callbacks`, `max-statements`, `import/max-dependencies`,
|
||||||
|
// `unicorn/max-nested-calls`: Deno had none of these.
|
||||||
|
complexity: "off",
|
||||||
|
"max-lines": "off",
|
||||||
|
"max-params": "off",
|
||||||
|
"id-length": "off",
|
||||||
|
"no-nested-ternary": "off",
|
||||||
|
"max-lines-per-function": "off",
|
||||||
|
"max-classes-per-file": "off",
|
||||||
|
"max-depth": "off",
|
||||||
|
"max-nested-callbacks": "off",
|
||||||
|
"max-statements": "off",
|
||||||
|
"import/max-dependencies": "off",
|
||||||
|
"unicorn/max-nested-calls": "off",
|
||||||
// Pedantic, but Node's and the web's own types (`Response`, `Stats`,
|
// Pedantic, but Node's and the web's own types (`Response`, `Stats`,
|
||||||
// `RequestInit`) are mutable, so no parameter of theirs can pass; the
|
// `RequestInit`) are mutable, so no parameter of theirs can pass; the
|
||||||
// explicit-types template and the app repos turn it off too.
|
// explicit-types template and the app repos turn it off too.
|
||||||
|
|||||||
@@ -1,119 +0,0 @@
|
|||||||
// Runs Claude Code for one profile and returns its final result text.
|
|
||||||
import { createInterface } from "node:readline";
|
|
||||||
import type { Readable } from "node:stream";
|
|
||||||
|
|
||||||
import { isClaudeAuthFailure } from "./auth.ts";
|
|
||||||
import type { ClaudeFailureFields } from "./auth.ts";
|
|
||||||
import { chunks } from "./command.ts";
|
|
||||||
import { agentCommand } from "./isolation.ts";
|
|
||||||
import { isObject } from "./json.ts";
|
|
||||||
import type { JsonObject } from "./json.ts";
|
|
||||||
import { AgentAuthError, agentEnvironment } from "./profiles.ts";
|
|
||||||
import { PROCESS_ENV, WORKSPACE } from "./run-context.ts";
|
|
||||||
import type { RuntimeProfile } from "./runtime.ts";
|
|
||||||
|
|
||||||
// Claude Code's stream-json `result` event, in its own field names.
|
|
||||||
type ClaudeResult = ClaudeFailureFields &
|
|
||||||
Partial<Record<"is_error", boolean>> & {
|
|
||||||
subtype: string;
|
|
||||||
};
|
|
||||||
|
|
||||||
// Echoes stderr as it arrives and resolves with all of it.
|
|
||||||
async function copyError(stream: Readable): Promise<string> {
|
|
||||||
const decoder = new TextDecoder();
|
|
||||||
let error = "";
|
|
||||||
for await (const chunk of chunks(stream)) {
|
|
||||||
const text = decoder.decode(chunk, { stream: true });
|
|
||||||
error += text;
|
|
||||||
console.error(text);
|
|
||||||
}
|
|
||||||
return error + decoder.decode();
|
|
||||||
}
|
|
||||||
|
|
||||||
// Prints the visible text of each streamed message part.
|
|
||||||
function printParts(event: JsonObject): void {
|
|
||||||
const content = isObject(event.message) ? event.message.content : undefined;
|
|
||||||
for (const part of Array.isArray(content) ? content : []) {
|
|
||||||
if (isObject(part)) {
|
|
||||||
const text = part.thinking ?? part.text ?? part.name;
|
|
||||||
if (typeof text === "string" && text !== "") {
|
|
||||||
console.log(text);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
function toResult(event: JsonObject): ClaudeResult {
|
|
||||||
const { is_error: isError, result, subtype, api_error_status: apiErrorStatus } = event;
|
|
||||||
return {
|
|
||||||
...(typeof isError === "boolean" && { is_error: isError }),
|
|
||||||
...(typeof result === "string" && { result }),
|
|
||||||
subtype: String(subtype),
|
|
||||||
...((typeof apiErrorStatus === "number" || apiErrorStatus === null) && {
|
|
||||||
api_error_status: apiErrorStatus,
|
|
||||||
}),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
// Prints each streamed message part and returns the final `result` event.
|
|
||||||
async function readEvents(stream: Readable): Promise<ClaudeResult | undefined> {
|
|
||||||
let result: ClaudeResult | undefined;
|
|
||||||
for await (const line of createInterface({ input: stream, crlfDelay: Infinity })) {
|
|
||||||
if (line !== "") {
|
|
||||||
const event: unknown = JSON.parse(line);
|
|
||||||
if (isObject(event)) {
|
|
||||||
printParts(event);
|
|
||||||
if (event.type === "result") {
|
|
||||||
result = toResult(event);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return result;
|
|
||||||
}
|
|
||||||
|
|
||||||
function checkResult(result: ClaudeResult | undefined, error: string): string {
|
|
||||||
if (result?.is_error === true) {
|
|
||||||
const failure = new Error(result.result ?? `claude ended with ${result.subtype}`);
|
|
||||||
if (isClaudeAuthFailure(result)) {
|
|
||||||
throw new AgentAuthError("claude sign-in failed", { cause: failure });
|
|
||||||
}
|
|
||||||
throw failure;
|
|
||||||
}
|
|
||||||
if (result?.result === undefined) {
|
|
||||||
throw new Error(error.trim() || `claude ended with ${result?.subtype ?? "no result"}`);
|
|
||||||
}
|
|
||||||
return result.result;
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function runClaude(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
token: string,
|
|
||||||
prompt: string,
|
|
||||||
): Promise<string> {
|
|
||||||
const args = [
|
|
||||||
"--print",
|
|
||||||
"--dangerously-skip-permissions",
|
|
||||||
"--model",
|
|
||||||
profile.model,
|
|
||||||
"--output-format",
|
|
||||||
"stream-json",
|
|
||||||
"--verbose",
|
|
||||||
prompt,
|
|
||||||
];
|
|
||||||
const claude = agentCommand(profile, "claude", args, {
|
|
||||||
cwd: WORKSPACE,
|
|
||||||
env: { ...agentEnvironment(PROCESS_ENV, profile, token), IS_SANDBOX: "1" },
|
|
||||||
clearEnv: true,
|
|
||||||
stdout: "piped",
|
|
||||||
stderr: "piped",
|
|
||||||
}).spawn();
|
|
||||||
const errorText = copyError(claude.stderr);
|
|
||||||
const result = await readEvents(claude.stdout);
|
|
||||||
const [status, error] = await Promise.all([claude.status, errorText]);
|
|
||||||
const body = checkResult(result, error);
|
|
||||||
if (!status.success) {
|
|
||||||
throw new Error(error.trim() || `claude exited with ${status.code}`);
|
|
||||||
}
|
|
||||||
return body;
|
|
||||||
}
|
|
||||||
@@ -1,174 +0,0 @@
|
|||||||
// Signs Codex in for one profile, runs it, and returns its result file path.
|
|
||||||
import process from "node:process";
|
|
||||||
import type { Readable } from "node:stream";
|
|
||||||
import { text } from "node:stream/consumers";
|
|
||||||
import { setTimeout as sleep } from "node:timers/promises";
|
|
||||||
|
|
||||||
import { isCodexAuthFailure, retryInvalidToken } from "./auth.ts";
|
|
||||||
import type { CodexAuthentication } from "./auth.ts";
|
|
||||||
import { chunks, endWith, writeChunk } from "./command.ts";
|
|
||||||
import type { CommandStatus } from "./command.ts";
|
|
||||||
import { agentCommand } from "./isolation.ts";
|
|
||||||
import { AgentAuthError, agentEnvironment, withProfile } from "./profiles.ts";
|
|
||||||
import {
|
|
||||||
makeProfileFile,
|
|
||||||
postAuthorComment,
|
|
||||||
PROCESS_ENV,
|
|
||||||
runAgentCommand,
|
|
||||||
WORKSPACE,
|
|
||||||
} from "./run-context.ts";
|
|
||||||
import type { RuntimeProfile } from "./runtime.ts";
|
|
||||||
|
|
||||||
interface CodexAttempt {
|
|
||||||
status: CommandStatus;
|
|
||||||
error: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
async function collectText(stream: Readable, append: (chunk: string) => void): Promise<void> {
|
|
||||||
const decoder = new TextDecoder();
|
|
||||||
for await (const chunk of chunks(stream)) {
|
|
||||||
append(decoder.decode(chunk, { stream: true }));
|
|
||||||
}
|
|
||||||
append(decoder.decode());
|
|
||||||
}
|
|
||||||
|
|
||||||
// Polls every 100 ms until the login prints something, failing if it exits first.
|
|
||||||
async function pollForInstructions(
|
|
||||||
shownText: () => string,
|
|
||||||
status: Promise<CommandStatus>,
|
|
||||||
): Promise<void> {
|
|
||||||
if (shownText().trim() !== "") {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
const exited = await Promise.race([status.then(() => true), sleep(100, false)]);
|
|
||||||
if (exited) {
|
|
||||||
throw new AgentAuthError("AI bot login produced no instructions");
|
|
||||||
}
|
|
||||||
await pollForInstructions(shownText, status);
|
|
||||||
}
|
|
||||||
|
|
||||||
async function codexDeviceLogin(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
environment: Record<string, string>,
|
|
||||||
): Promise<void> {
|
|
||||||
const login = agentCommand(profile, "codex", ["login", "--device-auth"], {
|
|
||||||
cwd: WORKSPACE,
|
|
||||||
env: environment,
|
|
||||||
clearEnv: true,
|
|
||||||
stdout: "piped",
|
|
||||||
stderr: "piped",
|
|
||||||
}).spawn();
|
|
||||||
let shown = "";
|
|
||||||
const append = (chunk: string): void => {
|
|
||||||
shown += chunk;
|
|
||||||
};
|
|
||||||
const drained = Promise.all([
|
|
||||||
collectText(login.stdout, append),
|
|
||||||
collectText(login.stderr, append),
|
|
||||||
]);
|
|
||||||
await sleep(3000);
|
|
||||||
await pollForInstructions(() => shown, login.status);
|
|
||||||
await postAuthorComment(withProfile(shown, profile));
|
|
||||||
const [result] = await Promise.all([login.status, drained]);
|
|
||||||
if (!result.success) {
|
|
||||||
throw new AgentAuthError(`codex login exited with ${result.code}`);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function codexApiLogin(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
environment: Record<string, string>,
|
|
||||||
token: string,
|
|
||||||
): Promise<void> {
|
|
||||||
const login = agentCommand(profile, "codex", ["login", "--with-api-key"], {
|
|
||||||
cwd: WORKSPACE,
|
|
||||||
env: environment,
|
|
||||||
clearEnv: true,
|
|
||||||
stdin: "piped",
|
|
||||||
stderr: "piped",
|
|
||||||
}).spawn();
|
|
||||||
await endWith(login.stdin, `${token}\n`);
|
|
||||||
const [status, error] = await Promise.all([login.status, text(login.stderr)]);
|
|
||||||
if (!status.success) {
|
|
||||||
throw new Error(error.trim() || `codex login exited with ${status.code}`);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function signIn(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
environment: Record<string, string>,
|
|
||||||
authentication: CodexAuthentication,
|
|
||||||
): Promise<void> {
|
|
||||||
if (authentication.kind === "api-key") {
|
|
||||||
await codexApiLogin(profile, environment, authentication.token);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
const loggedIn = await agentCommand(profile, "codex", ["login", "status"], {
|
|
||||||
cwd: WORKSPACE,
|
|
||||||
env: environment,
|
|
||||||
clearEnv: true,
|
|
||||||
}).output();
|
|
||||||
if (!loggedIn.success) {
|
|
||||||
await codexDeviceLogin(profile, environment);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
async function execCodex(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
environment: Record<string, string>,
|
|
||||||
prompt: string,
|
|
||||||
outputPath: string,
|
|
||||||
): Promise<CodexAttempt> {
|
|
||||||
const args = [
|
|
||||||
"exec",
|
|
||||||
"--model",
|
|
||||||
profile.model,
|
|
||||||
"--dangerously-bypass-approvals-and-sandbox",
|
|
||||||
"--output-last-message",
|
|
||||||
outputPath,
|
|
||||||
prompt,
|
|
||||||
];
|
|
||||||
const codex = agentCommand(profile, "codex", args, {
|
|
||||||
cwd: WORKSPACE,
|
|
||||||
env: environment,
|
|
||||||
clearEnv: true,
|
|
||||||
stdout: "inherit",
|
|
||||||
stderr: "piped",
|
|
||||||
}).spawn();
|
|
||||||
const decoder = new TextDecoder();
|
|
||||||
let error = "";
|
|
||||||
for await (const chunk of chunks(codex.stderr)) {
|
|
||||||
await writeChunk(process.stderr, chunk);
|
|
||||||
error += decoder.decode(chunk, { stream: true });
|
|
||||||
}
|
|
||||||
error += decoder.decode();
|
|
||||||
// Codex echoes the prompt, whose comments may quote auth errors.
|
|
||||||
return { status: await codex.status, error: error.replaceAll(prompt, "") };
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function runCodex(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
prompt: string,
|
|
||||||
authentication: CodexAuthentication,
|
|
||||||
): Promise<string> {
|
|
||||||
const token = authentication.kind === "api-key" ? authentication.token : undefined;
|
|
||||||
const environment = agentEnvironment(PROCESS_ENV, profile, token);
|
|
||||||
await signIn(profile, environment, authentication);
|
|
||||||
const outputPath = await makeProfileFile(profile, "result.md");
|
|
||||||
const attempt = (): Promise<CodexAttempt> => execCodex(profile, environment, prompt, outputPath);
|
|
||||||
const result =
|
|
||||||
authentication.kind === "api-key"
|
|
||||||
? await attempt()
|
|
||||||
: await retryInvalidToken(attempt, async () => {
|
|
||||||
await runAgentCommand(profile, "codex", ["logout"]);
|
|
||||||
await codexDeviceLogin(profile, environment);
|
|
||||||
});
|
|
||||||
if (!result.status.success) {
|
|
||||||
const failure = new Error(result.error.trim() || `codex exited with ${result.status.code}`);
|
|
||||||
if (isCodexAuthFailure(result.error)) {
|
|
||||||
throw new AgentAuthError("codex sign-in failed", { cause: failure });
|
|
||||||
}
|
|
||||||
throw failure;
|
|
||||||
}
|
|
||||||
return outputPath;
|
|
||||||
}
|
|
||||||
@@ -1,46 +0,0 @@
|
|||||||
// Runs OpenCode for one profile and returns its final visible text.
|
|
||||||
import process from "node:process";
|
|
||||||
|
|
||||||
import { chunks, writeChunk } from "./command.ts";
|
|
||||||
import { agentCommand } from "./isolation.ts";
|
|
||||||
import {
|
|
||||||
collectOpenCodeOutput,
|
|
||||||
openCodeArgs,
|
|
||||||
openCodeError,
|
|
||||||
parseOpenCodeEvents,
|
|
||||||
} from "./opencode.ts";
|
|
||||||
import { agentEnvironment } from "./profiles.ts";
|
|
||||||
import { PROCESS_ENV, WORKSPACE } from "./run-context.ts";
|
|
||||||
import type { RuntimeProfile } from "./runtime.ts";
|
|
||||||
|
|
||||||
export async function runOpenCode(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
token: string,
|
|
||||||
prompt: string,
|
|
||||||
): Promise<string> {
|
|
||||||
const child = agentCommand(profile, "opencode", openCodeArgs(profile.model, prompt), {
|
|
||||||
cwd: WORKSPACE,
|
|
||||||
env: agentEnvironment(PROCESS_ENV, profile, token),
|
|
||||||
clearEnv: true,
|
|
||||||
stdout: "piped",
|
|
||||||
stderr: "piped",
|
|
||||||
}).spawn();
|
|
||||||
const collected = collectOpenCodeOutput(
|
|
||||||
chunks(child.stdout),
|
|
||||||
chunks(child.stderr),
|
|
||||||
async (chunk) => {
|
|
||||||
await writeChunk(process.stdout, chunk);
|
|
||||||
},
|
|
||||||
async (chunk) => {
|
|
||||||
await writeChunk(process.stderr, chunk);
|
|
||||||
},
|
|
||||||
);
|
|
||||||
const [status, streams] = await Promise.all([child.status, collected]);
|
|
||||||
const error = streams.stderr.trim();
|
|
||||||
if (!status.success) {
|
|
||||||
throw (
|
|
||||||
openCodeError(streams.stdout) ?? new Error(error || `opencode exited with ${status.code}`)
|
|
||||||
);
|
|
||||||
}
|
|
||||||
return parseOpenCodeEvents(streams.stdout);
|
|
||||||
}
|
|
||||||
@@ -1,30 +0,0 @@
|
|||||||
// Dispatches one attempt to the agent CLI its profile names.
|
|
||||||
import { runClaude } from "./agent-claude.ts";
|
|
||||||
import { runCodex } from "./agent-codex.ts";
|
|
||||||
import { runOpenCode } from "./agent-opencode.ts";
|
|
||||||
import { codexAuthentication } from "./auth.ts";
|
|
||||||
import type { CodexAuthentication } from "./auth.ts";
|
|
||||||
import type { RuntimeProfile } from "./runtime.ts";
|
|
||||||
|
|
||||||
export interface AgentAnswer {
|
|
||||||
body?: string;
|
|
||||||
resultPath?: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
// Runs the selected agent; Codex leaves its answer in a file, the others return it.
|
|
||||||
export async function runAgent(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
token: string | undefined,
|
|
||||||
prompt: string,
|
|
||||||
authentication: CodexAuthentication | null,
|
|
||||||
): Promise<AgentAnswer> {
|
|
||||||
if (profile.type === "claude") {
|
|
||||||
return { body: await runClaude(profile, token ?? "", prompt) };
|
|
||||||
}
|
|
||||||
if (profile.type === "codex") {
|
|
||||||
return {
|
|
||||||
resultPath: await runCodex(profile, prompt, authentication ?? codexAuthentication(token)),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
return { body: await runOpenCode(profile, token ?? "", prompt) };
|
|
||||||
}
|
|
||||||
+7
-12
@@ -60,15 +60,6 @@ export async function retryInvalidToken<T extends { status: { success: boolean }
|
|||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
function hasCodexTokens(tokens: unknown): boolean {
|
|
||||||
return (
|
|
||||||
isObject(tokens) &&
|
|
||||||
["access_token", "refresh_token", "id_token", "account_id"].every(
|
|
||||||
(name) => typeof tokens[name] === "string" && tokens[name] !== "",
|
|
||||||
)
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
async function readCodexAuth(path: string): Promise<string> {
|
async function readCodexAuth(path: string): Promise<string> {
|
||||||
const stat = await lstat(path);
|
const stat = await lstat(path);
|
||||||
if (!stat.isFile() || stat.isSymbolicLink()) {
|
if (!stat.isFile() || stat.isSymbolicLink()) {
|
||||||
@@ -84,11 +75,15 @@ async function readCodexAuth(path: string): Promise<string> {
|
|||||||
} catch {
|
} catch {
|
||||||
throw new Error("invalid Codex login");
|
throw new Error("invalid Codex login");
|
||||||
}
|
}
|
||||||
|
const tokens = isObject(value) ? value["tokens"] : undefined;
|
||||||
if (
|
if (
|
||||||
!isObject(value) ||
|
!isObject(value) ||
|
||||||
typeof value.auth_mode !== "string" ||
|
typeof value["auth_mode"] !== "string" ||
|
||||||
value.auth_mode === "" ||
|
value["auth_mode"] === "" ||
|
||||||
!hasCodexTokens(value.tokens)
|
!isObject(tokens) ||
|
||||||
|
!["access_token", "refresh_token", "id_token", "account_id"].every(
|
||||||
|
(name) => typeof tokens[name] === "string" && tokens[name] !== "",
|
||||||
|
)
|
||||||
) {
|
) {
|
||||||
throw new Error("invalid Codex login");
|
throw new Error("invalid Codex login");
|
||||||
}
|
}
|
||||||
|
|||||||
+6
-14
@@ -49,27 +49,19 @@ async function profileProcessIds(uid: number): Promise<number[]> {
|
|||||||
.map(Number);
|
.map(Number);
|
||||||
}
|
}
|
||||||
|
|
||||||
function killProcess(pid: number): void {
|
|
||||||
try {
|
|
||||||
process.kill(pid, "SIGKILL");
|
|
||||||
} catch (error) {
|
|
||||||
if (!isNotFound(error)) {
|
|
||||||
throw error;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Kills the UID's processes every 10 ms until none is left, for up to 100 rounds.
|
// Kills the UID's processes every 10 ms until none is left, for up to 100 rounds.
|
||||||
export async function killProfileProcesses(uid: number, attempt = 0): Promise<void> {
|
export async function killProfileProcesses(uid: number, attempt = 0): Promise<void> {
|
||||||
if (attempt === 100) {
|
if (attempt === 100) {
|
||||||
throw new Error(`profile UID ${uid} still owns processes after cleanup`);
|
throw new Error(`profile UID ${uid} still owns processes after cleanup`);
|
||||||
}
|
}
|
||||||
const ids = await profileProcessIds(uid);
|
const ids = await profileProcessIds(uid);
|
||||||
if (ids.length === 0) {
|
if (ids.length === 0) return;
|
||||||
return;
|
|
||||||
}
|
|
||||||
for (const pid of ids) {
|
for (const pid of ids) {
|
||||||
killProcess(pid);
|
try {
|
||||||
|
process.kill(pid, "SIGKILL");
|
||||||
|
} catch (error) {
|
||||||
|
if (!isNotFound(error)) throw error;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
await sleep(10);
|
await sleep(10);
|
||||||
await killProfileProcesses(uid, attempt + 1);
|
await killProfileProcesses(uid, attempt + 1);
|
||||||
|
|||||||
@@ -1,114 +0,0 @@
|
|||||||
// Reads what the agent phase left behind: its outcome, and the review and
|
|
||||||
// anchors files it wrote into a profile home.
|
|
||||||
import type { Stats } from "node:fs";
|
|
||||||
import { lstat, readFile } from "node:fs/promises";
|
|
||||||
import { join } from "node:path";
|
|
||||||
|
|
||||||
import { isNotFound } from "./errors.ts";
|
|
||||||
import { isObject } from "./json.ts";
|
|
||||||
import { isFailureReason, isProfileType } from "./profiles.ts";
|
|
||||||
import type { ProfileFailure } from "./profiles.ts";
|
|
||||||
import type { RuntimeManifest, RuntimeOutcome } from "./runtime.ts";
|
|
||||||
|
|
||||||
export interface Anchor {
|
|
||||||
path: string;
|
|
||||||
line: number;
|
|
||||||
side: "new" | "old";
|
|
||||||
body: string;
|
|
||||||
}
|
|
||||||
|
|
||||||
function parseAnchor(entry: unknown, at: string): Anchor {
|
|
||||||
if (!isObject(entry)) {
|
|
||||||
throw new TypeError(`${at}: not an object`);
|
|
||||||
}
|
|
||||||
const { path, line, side = "new", body } = entry;
|
|
||||||
if (typeof path !== "string" || path === "") {
|
|
||||||
throw new TypeError(`${at}.path: expected a repository path`);
|
|
||||||
}
|
|
||||||
if (typeof line !== "number" || !Number.isInteger(line) || line < 1) {
|
|
||||||
throw new TypeError(`${at}.line: expected a line number`);
|
|
||||||
}
|
|
||||||
if (side !== "new" && side !== "old") {
|
|
||||||
throw new Error(`${at}.side: expected "new" or "old"`);
|
|
||||||
}
|
|
||||||
if (typeof body !== "string" || body.trim() === "") {
|
|
||||||
throw new TypeError(`${at}.body: expected the finding`);
|
|
||||||
}
|
|
||||||
return { path, line, side, body };
|
|
||||||
}
|
|
||||||
|
|
||||||
export function parseAnchors(text: string, sourcePath: string): Anchor[] {
|
|
||||||
const entries: unknown = JSON.parse(text);
|
|
||||||
if (!Array.isArray(entries)) {
|
|
||||||
throw new TypeError(`${sourcePath}: not an array`);
|
|
||||||
}
|
|
||||||
return entries.map((entry: unknown, index) => parseAnchor(entry, `${sourcePath}[${index}]`));
|
|
||||||
}
|
|
||||||
|
|
||||||
// Only known labels reach the comment, never raw agent output.
|
|
||||||
function knownFailures(failures: unknown): ProfileFailure[] {
|
|
||||||
return (Array.isArray(failures) ? failures : []).flatMap((entry: unknown) => {
|
|
||||||
if (!isObject(entry)) {
|
|
||||||
return [];
|
|
||||||
}
|
|
||||||
const { type, model, reason } = entry;
|
|
||||||
return isProfileType(type) && typeof model === "string" && isFailureReason(reason)
|
|
||||||
? [{ type, model, reason }]
|
|
||||||
: [];
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function readOutcome(path: string): Promise<RuntimeOutcome> {
|
|
||||||
const value: unknown = JSON.parse(await readFile(path, "utf8"));
|
|
||||||
if (!isObject(value) || !("ok" in value)) {
|
|
||||||
throw new Error("invalid agent outcome");
|
|
||||||
}
|
|
||||||
if (value.ok === false) {
|
|
||||||
return { ok: false, failures: knownFailures(value.failures) };
|
|
||||||
}
|
|
||||||
const { ok, body, reviewPath, anchorsPath, profile } = value;
|
|
||||||
if (
|
|
||||||
ok !== true ||
|
|
||||||
typeof body !== "string" ||
|
|
||||||
typeof reviewPath !== "string" ||
|
|
||||||
typeof anchorsPath !== "string" ||
|
|
||||||
!isObject(profile) ||
|
|
||||||
!isProfileType(profile.type) ||
|
|
||||||
typeof profile.model !== "string"
|
|
||||||
) {
|
|
||||||
throw new Error("invalid agent outcome");
|
|
||||||
}
|
|
||||||
return {
|
|
||||||
ok: true,
|
|
||||||
body,
|
|
||||||
reviewPath,
|
|
||||||
anchorsPath,
|
|
||||||
profile: { type: profile.type, model: profile.model },
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function readAgentArtifact(
|
|
||||||
manifest: RuntimeManifest,
|
|
||||||
path: string,
|
|
||||||
name: string,
|
|
||||||
): Promise<string | null> {
|
|
||||||
const profile = manifest.profiles.find((entry) => join(entry.home, name) === path);
|
|
||||||
if (profile === undefined) throw new Error(`${name}: outside profile home`);
|
|
||||||
let stat: Stats;
|
|
||||||
try {
|
|
||||||
stat = await lstat(path);
|
|
||||||
} catch (error) {
|
|
||||||
if (isNotFound(error)) return null;
|
|
||||||
throw error;
|
|
||||||
}
|
|
||||||
if (
|
|
||||||
!stat.isFile() ||
|
|
||||||
stat.isSymbolicLink() ||
|
|
||||||
stat.uid !== profile.uid ||
|
|
||||||
(stat.mode & 0o077) !== 0
|
|
||||||
) {
|
|
||||||
throw new Error(`${name}: expected a profile-owned regular private file`);
|
|
||||||
}
|
|
||||||
const text = await readFile(path, "utf8");
|
|
||||||
return text === "" ? null : text;
|
|
||||||
}
|
|
||||||
+142
-87
@@ -1,11 +1,12 @@
|
|||||||
import { readFile, rm } from "node:fs/promises";
|
import type { Stats } from "node:fs";
|
||||||
|
import { lstat, readFile, rm } from "node:fs/promises";
|
||||||
|
import { join } from "node:path";
|
||||||
import process from "node:process";
|
import process from "node:process";
|
||||||
|
|
||||||
import { isNotFound } from "./errors.ts";
|
import { isNotFound } from "./errors.ts";
|
||||||
import { parseAnchors, readAgentArtifact, readOutcome } from "./post-artifacts.ts";
|
import { isObject } from "./json.ts";
|
||||||
import type { Anchor } from "./post-artifacts.ts";
|
|
||||||
import { failureFooter, withProfile } from "./profiles.ts";
|
import { failureFooter, withProfile } from "./profiles.ts";
|
||||||
import type { ProfileFailure } from "./profiles.ts";
|
import type { FailureReason, ProfileFailure } from "./profiles.ts";
|
||||||
import { readRuntimeManifest } from "./runtime.ts";
|
import { readRuntimeManifest } from "./runtime.ts";
|
||||||
import type { RuntimeManifest, RuntimeOutcome } from "./runtime.ts";
|
import type { RuntimeManifest, RuntimeOutcome } from "./runtime.ts";
|
||||||
|
|
||||||
@@ -16,15 +17,11 @@ export interface PostContext {
|
|||||||
eventName: string;
|
eventName: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
type SuccessOutcome = Extract<RuntimeOutcome, { ok: true }>;
|
interface Anchor {
|
||||||
|
path: string;
|
||||||
type GiteaRequest = (path: string, body: unknown) => Promise<void>;
|
line: number;
|
||||||
|
side: "new" | "old";
|
||||||
// The reviewer's view of one issue or pull request.
|
body: string;
|
||||||
interface Publisher {
|
|
||||||
context: PostContext;
|
|
||||||
request: GiteaRequest;
|
|
||||||
postComment(body: string): Promise<void>;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
const ANSI = new RegExp(`${String.fromCodePoint(27)}\\[[0-9;]*[A-Za-z]`, "gu");
|
const ANSI = new RegExp(`${String.fromCodePoint(27)}\\[[0-9;]*[A-Za-z]`, "gu");
|
||||||
@@ -33,16 +30,122 @@ const VERDICTS: Record<string, [event: string, mark: string]> = {
|
|||||||
Approved: ["APPROVED", "✅"],
|
Approved: ["APPROVED", "✅"],
|
||||||
"Changes requested": ["REQUEST_CHANGES", "🛑"],
|
"Changes requested": ["REQUEST_CHANGES", "🛑"],
|
||||||
};
|
};
|
||||||
|
const PROFILE_TYPES: Set<unknown> = new Set(["claude", "codex", "opencode"]);
|
||||||
|
const FAILURE_REASONS: Set<unknown> = new Set(["sign-in failed", "usage exhausted", "failed"]);
|
||||||
|
const isProfileType = (value: unknown): value is ProfileFailure["type"] => PROFILE_TYPES.has(value);
|
||||||
|
const isFailureReason = (value: unknown): value is FailureReason => FAILURE_REASONS.has(value);
|
||||||
const failureComment = (failures: ProfileFailure[]): string =>
|
const failureComment = (failures: ProfileFailure[]): string =>
|
||||||
`AI bot failed.\n\n${failureFooter(failures)}`;
|
`AI bot failed.\n\n${failureFooter(failures)}`;
|
||||||
|
|
||||||
class GiteaRequestError extends Error {}
|
class GiteaRequestError extends Error {}
|
||||||
|
|
||||||
function giteaRequest(apiUrl: string, reviewerToken: string, fetcher: typeof fetch): GiteaRequest {
|
function parseAnchors(text: string, sourcePath: string): Anchor[] {
|
||||||
return async (path, body) => {
|
const entries: unknown = JSON.parse(text);
|
||||||
|
if (!Array.isArray(entries)) throw new TypeError(`${sourcePath}: not an array`);
|
||||||
|
return entries.map((entry: unknown, index) => {
|
||||||
|
const at = `${sourcePath}[${index}]`;
|
||||||
|
if (!isObject(entry)) {
|
||||||
|
throw new TypeError(`${at}: not an object`);
|
||||||
|
}
|
||||||
|
const { path, line, side = "new", body } = entry;
|
||||||
|
if (typeof path !== "string" || path === "") {
|
||||||
|
throw new TypeError(`${at}.path: expected a repository path`);
|
||||||
|
}
|
||||||
|
if (typeof line !== "number" || !Number.isInteger(line) || line < 1) {
|
||||||
|
throw new TypeError(`${at}.line: expected a line number`);
|
||||||
|
}
|
||||||
|
if (side !== "new" && side !== "old") {
|
||||||
|
throw new Error(`${at}.side: expected "new" or "old"`);
|
||||||
|
}
|
||||||
|
if (typeof body !== "string" || body.trim() === "") {
|
||||||
|
throw new TypeError(`${at}.body: expected the finding`);
|
||||||
|
}
|
||||||
|
return { path, line, side, body };
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
async function readOutcome(path: string): Promise<RuntimeOutcome> {
|
||||||
|
const value: unknown = JSON.parse(await readFile(path, "utf8"));
|
||||||
|
if (!isObject(value) || !("ok" in value)) {
|
||||||
|
throw new Error("invalid agent outcome");
|
||||||
|
}
|
||||||
|
const outcome = value;
|
||||||
|
if (outcome["ok"] === false) {
|
||||||
|
// Only known labels reach the comment, never raw agent output.
|
||||||
|
const failures: unknown[] = Array.isArray(outcome["failures"]) ? outcome["failures"] : [];
|
||||||
|
return {
|
||||||
|
ok: false,
|
||||||
|
failures: failures.flatMap((entry: unknown) => {
|
||||||
|
const { type, model, reason } = isObject(entry) ? entry : {};
|
||||||
|
return isProfileType(type) && typeof model === "string" && isFailureReason(reason)
|
||||||
|
? [{ type, model, reason }]
|
||||||
|
: [];
|
||||||
|
}),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if (
|
||||||
|
outcome["ok"] !== true ||
|
||||||
|
typeof outcome["body"] !== "string" ||
|
||||||
|
typeof outcome["reviewPath"] !== "string" ||
|
||||||
|
typeof outcome["anchorsPath"] !== "string" ||
|
||||||
|
!isObject(outcome["profile"])
|
||||||
|
) {
|
||||||
|
throw new Error("invalid agent outcome");
|
||||||
|
}
|
||||||
|
const profile = outcome["profile"];
|
||||||
|
if (!isProfileType(profile["type"]) || typeof profile["model"] !== "string") {
|
||||||
|
throw new Error("invalid agent outcome");
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
ok: true,
|
||||||
|
body: outcome["body"],
|
||||||
|
reviewPath: outcome["reviewPath"],
|
||||||
|
anchorsPath: outcome["anchorsPath"],
|
||||||
|
profile: {
|
||||||
|
type: profile["type"],
|
||||||
|
model: profile["model"],
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
async function readAgentArtifact(
|
||||||
|
manifest: RuntimeManifest,
|
||||||
|
path: string,
|
||||||
|
name: string,
|
||||||
|
): Promise<string | null> {
|
||||||
|
const profile = manifest.profiles.find((entry) => join(entry.home, name) === path);
|
||||||
|
if (profile === undefined) throw new Error(`${name}: outside profile home`);
|
||||||
|
let stat: Stats;
|
||||||
|
try {
|
||||||
|
stat = await lstat(path);
|
||||||
|
} catch (error) {
|
||||||
|
if (isNotFound(error)) return null;
|
||||||
|
throw error;
|
||||||
|
}
|
||||||
|
if (
|
||||||
|
!stat.isFile() ||
|
||||||
|
stat.isSymbolicLink() ||
|
||||||
|
stat.uid !== profile.uid ||
|
||||||
|
(stat.mode & 0o077) !== 0
|
||||||
|
) {
|
||||||
|
throw new Error(`${name}: expected a profile-owned regular private file`);
|
||||||
|
}
|
||||||
|
const text = await readFile(path, "utf8");
|
||||||
|
return text === "" ? null : text;
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function postRuntime(
|
||||||
|
manifestPath: string,
|
||||||
|
context: PostContext,
|
||||||
|
fetcher: typeof fetch = fetch,
|
||||||
|
): Promise<void> {
|
||||||
|
const manifest = await readRuntimeManifest(manifestPath);
|
||||||
|
try {
|
||||||
|
const reviewerToken = (await readFile(manifest.reviewerFile, "utf8")).trim();
|
||||||
|
const request = async (path: string, body: unknown): Promise<void> => {
|
||||||
let response: Response;
|
let response: Response;
|
||||||
try {
|
try {
|
||||||
response = await fetcher(`${apiUrl}/${path}`, {
|
response = await fetcher(`${context.apiUrl}/${path}`, {
|
||||||
method: "POST",
|
method: "POST",
|
||||||
headers: {
|
headers: {
|
||||||
Authorization: `token ${reviewerToken}`,
|
Authorization: `token ${reviewerToken}`,
|
||||||
@@ -58,37 +161,39 @@ function giteaRequest(apiUrl: string, reviewerToken: string, fetcher: typeof fet
|
|||||||
throw new GiteaRequestError(`${path}: ${response.status} ${await response.text()}`);
|
throw new GiteaRequestError(`${path}: ${response.status} ${await response.text()}`);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
}
|
const postComment = (body: string): Promise<void> =>
|
||||||
|
request(`repos/${context.repository}/issues/${context.issueIndex}/comments`, {
|
||||||
|
body: stripAnsi(body),
|
||||||
|
});
|
||||||
|
|
||||||
async function readSuccess(
|
|
||||||
manifest: RuntimeManifest,
|
|
||||||
publisher: Publisher,
|
|
||||||
): Promise<SuccessOutcome> {
|
|
||||||
let outcome: RuntimeOutcome;
|
let outcome: RuntimeOutcome;
|
||||||
try {
|
try {
|
||||||
outcome = await readOutcome(manifest.outcomeFile);
|
outcome = await readOutcome(manifest.outcomeFile);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
await publisher.postComment(failureComment([]));
|
await postComment(failureComment([]));
|
||||||
throw new Error("agent phase failed", { cause: error });
|
throw new Error("agent phase failed", { cause: error });
|
||||||
}
|
}
|
||||||
if (!outcome.ok) {
|
if (!outcome.ok) {
|
||||||
await publisher.postComment(failureComment(outcome.failures));
|
await postComment(failureComment(outcome.failures));
|
||||||
throw new Error("agent phase failed");
|
throw new Error("agent phase failed");
|
||||||
}
|
}
|
||||||
return outcome;
|
|
||||||
}
|
|
||||||
|
|
||||||
async function postReview(
|
try {
|
||||||
publisher: Publisher,
|
const review = await readAgentArtifact(manifest, outcome.reviewPath, "review.md");
|
||||||
outcome: SuccessOutcome,
|
if (review === null) {
|
||||||
review: string,
|
if (context.eventName === "pull_request") {
|
||||||
anchors: Anchor[],
|
throw new Error("agent did not write a pull request review");
|
||||||
): Promise<void> {
|
}
|
||||||
const { context, request } = publisher;
|
await postComment(withProfile(outcome.body, outcome.profile));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
const [verdict = "", ...rest] = review.split("\n");
|
const [verdict = "", ...rest] = review.split("\n");
|
||||||
const [event, mark] = VERDICTS[verdict.trim()] ?? ["COMMENT", "💬"];
|
const [event, mark] = VERDICTS[verdict.trim()] ?? ["COMMENT", "💬"];
|
||||||
const send = async (entries: Anchor[]): Promise<void> => {
|
const anchorText = await readAgentArtifact(manifest, outcome.anchorsPath, "anchors.json");
|
||||||
await request(`repos/${context.repository}/pulls/${context.issueIndex}/reviews`, {
|
const anchors = anchorText === null ? [] : parseAnchors(anchorText, outcome.anchorsPath);
|
||||||
|
const postReview = (entries: Anchor[]): Promise<void> =>
|
||||||
|
request(`repos/${context.repository}/pulls/${context.issueIndex}/reviews`, {
|
||||||
body: stripAnsi(
|
body: stripAnsi(
|
||||||
withProfile([`${mark} ${verdict.trim()}`, ...rest].join("\n"), outcome.profile),
|
withProfile([`${mark} ${verdict.trim()}`, ...rest].join("\n"), outcome.profile),
|
||||||
),
|
),
|
||||||
@@ -100,68 +205,18 @@ async function postReview(
|
|||||||
old_position: side === "old" ? line : 0,
|
old_position: side === "old" ? line : 0,
|
||||||
})),
|
})),
|
||||||
});
|
});
|
||||||
};
|
await postReview(anchors).catch(async (error: unknown) => {
|
||||||
await send(anchors).catch(async (error: unknown) => {
|
|
||||||
if (anchors.length === 0) throw error;
|
if (anchors.length === 0) throw error;
|
||||||
console.error(
|
console.error(
|
||||||
`inline comments rejected: ${error instanceof Error ? error.message : String(error)}`,
|
`inline comments rejected: ${error instanceof Error ? error.message : String(error)}`,
|
||||||
);
|
);
|
||||||
await send([]);
|
await postReview([]);
|
||||||
});
|
});
|
||||||
}
|
|
||||||
|
|
||||||
async function publishResult(
|
|
||||||
manifest: RuntimeManifest,
|
|
||||||
outcome: SuccessOutcome,
|
|
||||||
publisher: Publisher,
|
|
||||||
): Promise<void> {
|
|
||||||
const review = await readAgentArtifact(manifest, outcome.reviewPath, "review.md");
|
|
||||||
if (review === null) {
|
|
||||||
if (publisher.context.eventName === "pull_request") {
|
|
||||||
throw new Error("agent did not write a pull request review");
|
|
||||||
}
|
|
||||||
await publisher.postComment(withProfile(outcome.body, outcome.profile));
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
const anchorText = await readAgentArtifact(manifest, outcome.anchorsPath, "anchors.json");
|
|
||||||
const anchors = anchorText === null ? [] : parseAnchors(anchorText, outcome.anchorsPath);
|
|
||||||
await postReview(publisher, outcome, review, anchors);
|
|
||||||
}
|
|
||||||
|
|
||||||
async function publish(
|
|
||||||
manifest: RuntimeManifest,
|
|
||||||
context: PostContext,
|
|
||||||
fetcher: typeof fetch,
|
|
||||||
): Promise<void> {
|
|
||||||
const reviewerToken = (await readFile(manifest.reviewerFile, "utf8")).trim();
|
|
||||||
const request = giteaRequest(context.apiUrl, reviewerToken, fetcher);
|
|
||||||
const publisher: Publisher = {
|
|
||||||
context,
|
|
||||||
request,
|
|
||||||
postComment: async (body) => {
|
|
||||||
await request(`repos/${context.repository}/issues/${context.issueIndex}/comments`, {
|
|
||||||
body: stripAnsi(body),
|
|
||||||
});
|
|
||||||
},
|
|
||||||
};
|
|
||||||
const outcome = await readSuccess(manifest, publisher);
|
|
||||||
try {
|
|
||||||
await publishResult(manifest, outcome, publisher);
|
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
if (error instanceof GiteaRequestError) throw error;
|
if (error instanceof GiteaRequestError) throw error;
|
||||||
await publisher.postComment(failureComment([{ ...outcome.profile, reason: "failed" }]));
|
await postComment(failureComment([{ ...outcome.profile, reason: "failed" }]));
|
||||||
throw error;
|
throw error;
|
||||||
}
|
}
|
||||||
}
|
|
||||||
|
|
||||||
export async function postRuntime(
|
|
||||||
manifestPath: string,
|
|
||||||
context: PostContext,
|
|
||||||
fetcher: typeof fetch = fetch,
|
|
||||||
): Promise<void> {
|
|
||||||
const manifest = await readRuntimeManifest(manifestPath);
|
|
||||||
try {
|
|
||||||
await publish(manifest, context, fetcher);
|
|
||||||
} finally {
|
} finally {
|
||||||
await rm(manifest.runtimeDir, { recursive: true }).catch((error: unknown) => {
|
await rm(manifest.runtimeDir, { recursive: true }).catch((error: unknown) => {
|
||||||
if (!isNotFound(error)) throw error;
|
if (!isNotFound(error)) throw error;
|
||||||
|
|||||||
+1
-3
@@ -5,9 +5,7 @@ import { prepareRuntime } from "./runtime.ts";
|
|||||||
|
|
||||||
const env = (name: string): string => {
|
const env = (name: string): string => {
|
||||||
const value = process.env[name];
|
const value = process.env[name];
|
||||||
if (value === undefined || value === "") {
|
if (value === undefined || value === "") throw new Error(`${name} is not set`);
|
||||||
throw new Error(`${name} is not set`);
|
|
||||||
}
|
|
||||||
return value;
|
return value;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
+3
-16
@@ -1,18 +1,9 @@
|
|||||||
export type ProfileType = "claude" | "codex" | "opencode";
|
|
||||||
|
|
||||||
export interface BotProfile {
|
export interface BotProfile {
|
||||||
type: ProfileType;
|
type: "claude" | "codex" | "opencode";
|
||||||
model: string;
|
model: string;
|
||||||
token?: string;
|
token?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
const PROFILE_TYPES: Set<unknown> = new Set(["claude", "codex", "opencode"]);
|
|
||||||
const FAILURE_REASONS: Set<unknown> = new Set(["sign-in failed", "usage exhausted", "failed"]);
|
|
||||||
|
|
||||||
export function isProfileType(value: unknown): value is ProfileType {
|
|
||||||
return PROFILE_TYPES.has(value);
|
|
||||||
}
|
|
||||||
|
|
||||||
export function profileFooter(profile: Pick<BotProfile, "type" | "model">): string {
|
export function profileFooter(profile: Pick<BotProfile, "type" | "model">): string {
|
||||||
return `> Profile: \`${profile.type}\` · \`${profile.model}\``;
|
return `> Profile: \`${profile.type}\` · \`${profile.model}\``;
|
||||||
}
|
}
|
||||||
@@ -23,10 +14,6 @@ export function withProfile(body: string, profile: Pick<BotProfile, "type" | "mo
|
|||||||
|
|
||||||
export type FailureReason = "sign-in failed" | "usage exhausted" | "failed";
|
export type FailureReason = "sign-in failed" | "usage exhausted" | "failed";
|
||||||
|
|
||||||
export function isFailureReason(value: unknown): value is FailureReason {
|
|
||||||
return FAILURE_REASONS.has(value);
|
|
||||||
}
|
|
||||||
|
|
||||||
export type ProfileFailure = Pick<BotProfile, "type" | "model"> & {
|
export type ProfileFailure = Pick<BotProfile, "type" | "model"> & {
|
||||||
reason: FailureReason;
|
reason: FailureReason;
|
||||||
};
|
};
|
||||||
@@ -123,8 +110,8 @@ export function agentEnvironment(
|
|||||||
token?: string,
|
token?: string,
|
||||||
): Record<string, string> {
|
): Record<string, string> {
|
||||||
const result = sanitizedEnvironment(environment);
|
const result = sanitizedEnvironment(environment);
|
||||||
result.HOME = profile.home;
|
result["HOME"] = profile.home;
|
||||||
if (profile.type === "codex") result.CODEX_HOME = `${profile.home}/.codex`;
|
if (profile.type === "codex") result["CODEX_HOME"] = `${profile.home}/.codex`;
|
||||||
if (token !== undefined && token !== "") {
|
if (token !== undefined && token !== "") {
|
||||||
const tokenName = {
|
const tokenName = {
|
||||||
claude: "CLAUDE_CODE_OAUTH_TOKEN",
|
claude: "CLAUDE_CODE_OAUTH_TOKEN",
|
||||||
|
|||||||
@@ -1,79 +0,0 @@
|
|||||||
// The agent phase's environment and the helpers every agent runner shares. It
|
|
||||||
// is read once, when the runner starts, as the single-file runner did.
|
|
||||||
import { chmod, chown, writeFile } from "node:fs/promises";
|
|
||||||
import process from "node:process";
|
|
||||||
|
|
||||||
import { agentCommand } from "./isolation.ts";
|
|
||||||
import { agentEnvironment, sanitizedEnvironment } from "./profiles.ts";
|
|
||||||
import { readRuntimeManifest } from "./runtime.ts";
|
|
||||||
import type { RuntimeProfile } from "./runtime.ts";
|
|
||||||
|
|
||||||
export const env = (name: string): string => {
|
|
||||||
const value = process.env[name];
|
|
||||||
if (value === undefined) {
|
|
||||||
throw new Error(`${name} is not set`);
|
|
||||||
}
|
|
||||||
return value;
|
|
||||||
};
|
|
||||||
|
|
||||||
function definedEnvironment(): Record<string, string> {
|
|
||||||
const result: Record<string, string> = {};
|
|
||||||
for (const [name, value] of Object.entries(process.env)) {
|
|
||||||
if (value !== undefined) {
|
|
||||||
result[name] = value;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return result;
|
|
||||||
}
|
|
||||||
|
|
||||||
export const API = env("GITEA_API_URL");
|
|
||||||
export const REPO = env("GITEA_REPOSITORY");
|
|
||||||
export const INDEX = env("ISSUE_INDEX");
|
|
||||||
export const EVENT = env("EVENT_NAME");
|
|
||||||
const AUTHOR_TOKEN = env("GITEA_TOKEN");
|
|
||||||
export const WORKSPACE = env("GITHUB_WORKSPACE");
|
|
||||||
export const MANIFEST = await readRuntimeManifest(env("BOT_AGENTS_MANIFEST"));
|
|
||||||
export const PROCESS_ENV = sanitizedEnvironment(definedEnvironment());
|
|
||||||
|
|
||||||
export async function gitea(path: string, body?: unknown): Promise<Response> {
|
|
||||||
const response = await fetch(`${API}/${path}`, {
|
|
||||||
method: body === undefined ? "GET" : "POST",
|
|
||||||
headers: {
|
|
||||||
Authorization: `token ${AUTHOR_TOKEN}`,
|
|
||||||
"Content-Type": "application/json",
|
|
||||||
},
|
|
||||||
body: body === undefined ? null : JSON.stringify(body),
|
|
||||||
});
|
|
||||||
if (!response.ok) {
|
|
||||||
throw new Error(`${path}: ${response.status} ${await response.text()}`);
|
|
||||||
}
|
|
||||||
return response;
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function postAuthorComment(body: string): Promise<void> {
|
|
||||||
await gitea(`repos/${REPO}/issues/${INDEX}/comments`, { body });
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function runAgentCommand(
|
|
||||||
profile: RuntimeProfile,
|
|
||||||
command: string,
|
|
||||||
args: string[],
|
|
||||||
token?: string,
|
|
||||||
): Promise<void> {
|
|
||||||
const { success, code } = await agentCommand(profile, command, args, {
|
|
||||||
cwd: WORKSPACE,
|
|
||||||
env: agentEnvironment(PROCESS_ENV, profile, token),
|
|
||||||
clearEnv: true,
|
|
||||||
}).output();
|
|
||||||
if (!success) {
|
|
||||||
throw new Error(`${command} ${args[0]} exited with ${code}`);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function makeProfileFile(profile: RuntimeProfile, name: string): Promise<string> {
|
|
||||||
const path = `${profile.home}/${name}`;
|
|
||||||
await writeFile(path, "", { mode: 0o600 });
|
|
||||||
await chmod(path, 0o600);
|
|
||||||
await chown(path, profile.uid, profile.gid);
|
|
||||||
return path;
|
|
||||||
}
|
|
||||||
+387
-56
@@ -1,28 +1,40 @@
|
|||||||
// Runs one ordered agent profile. Credential decryption and reviewer posting
|
// Runs one ordered agent profile. Credential decryption and reviewer posting
|
||||||
// live in separate processes so neither privileged secret reaches this runner.
|
// live in separate processes so neither privileged secret reaches this runner.
|
||||||
import { chmod, readFile, writeFile } from "node:fs/promises";
|
import { chmod, chown, readFile, writeFile } from "node:fs/promises";
|
||||||
|
import process from "node:process";
|
||||||
|
import { createInterface } from "node:readline";
|
||||||
|
import type { Readable } from "node:stream";
|
||||||
|
import { text as readText } from "node:stream/consumers";
|
||||||
|
import { setTimeout as sleep } from "node:timers/promises";
|
||||||
|
|
||||||
import { codexAuthentication, persistCodexAuth, stageCodexAuth } from "./auth.ts";
|
|
||||||
import { runAgent } from "./agents.ts";
|
|
||||||
import type { AgentAnswer } from "./agents.ts";
|
|
||||||
import { output } from "./command.ts";
|
|
||||||
import { killProfileProcesses, readProfileFile } from "./isolation.ts";
|
|
||||||
import { isObject } from "./json.ts";
|
|
||||||
import { runProfiles } from "./profiles.ts";
|
|
||||||
import type { ProfileFailure } from "./profiles.ts";
|
|
||||||
import {
|
import {
|
||||||
API,
|
codexAuthentication,
|
||||||
env,
|
isClaudeAuthFailure,
|
||||||
EVENT,
|
isCodexAuthFailure,
|
||||||
gitea,
|
persistCodexAuth,
|
||||||
INDEX,
|
retryInvalidToken,
|
||||||
makeProfileFile,
|
stageCodexAuth,
|
||||||
MANIFEST,
|
} from "./auth.ts";
|
||||||
PROCESS_ENV,
|
import type { ClaudeFailureFields, CodexAuthentication } from "./auth.ts";
|
||||||
REPO,
|
import { chunks, endWith, output, writeChunk } from "./command.ts";
|
||||||
runAgentCommand,
|
import type { CommandStatus } from "./command.ts";
|
||||||
WORKSPACE,
|
import { agentCommand, killProfileProcesses, readProfileFile } from "./isolation.ts";
|
||||||
} from "./run-context.ts";
|
import { isObject } from "./json.ts";
|
||||||
|
import {
|
||||||
|
collectOpenCodeOutput,
|
||||||
|
openCodeArgs,
|
||||||
|
openCodeError,
|
||||||
|
parseOpenCodeEvents,
|
||||||
|
} from "./opencode.ts";
|
||||||
|
import {
|
||||||
|
AgentAuthError,
|
||||||
|
agentEnvironment,
|
||||||
|
runProfiles,
|
||||||
|
sanitizedEnvironment,
|
||||||
|
withProfile,
|
||||||
|
} from "./profiles.ts";
|
||||||
|
import type { ProfileFailure } from "./profiles.ts";
|
||||||
|
import { readRuntimeManifest } from "./runtime.ts";
|
||||||
import type { RuntimeOutcome, RuntimeProfile } from "./runtime.ts";
|
import type { RuntimeOutcome, RuntimeProfile } from "./runtime.ts";
|
||||||
|
|
||||||
interface AttemptResult {
|
interface AttemptResult {
|
||||||
@@ -32,30 +44,71 @@ interface AttemptResult {
|
|||||||
profile: Pick<RuntimeProfile, "type" | "model">;
|
profile: Pick<RuntimeProfile, "type" | "model">;
|
||||||
}
|
}
|
||||||
|
|
||||||
interface RenderedPrompt {
|
// Claude Code's stream-json `result` event, in its own field names.
|
||||||
prompt: string;
|
type ClaudeResult = ClaudeFailureFields &
|
||||||
reviewPath: string;
|
Partial<Record<"is_error", boolean>> & {
|
||||||
anchorsPath: string;
|
subtype: string;
|
||||||
|
};
|
||||||
|
|
||||||
|
const env = (name: string): string => {
|
||||||
|
const value = process.env[name];
|
||||||
|
if (value === undefined) throw new Error(`${name} is not set`);
|
||||||
|
return value;
|
||||||
|
};
|
||||||
|
|
||||||
|
function definedEnvironment(): Record<string, string> {
|
||||||
|
const result: Record<string, string> = {};
|
||||||
|
for (const [name, value] of Object.entries(process.env)) {
|
||||||
|
if (value !== undefined) {
|
||||||
|
result[name] = value;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const API = env("GITEA_API_URL");
|
||||||
|
const REPO = env("GITEA_REPOSITORY");
|
||||||
|
const INDEX = env("ISSUE_INDEX");
|
||||||
|
const EVENT = env("EVENT_NAME");
|
||||||
|
const AUTHOR_TOKEN = env("GITEA_TOKEN");
|
||||||
|
const WORKSPACE = env("GITHUB_WORKSPACE");
|
||||||
|
const MANIFEST = await readRuntimeManifest(env("BOT_AGENTS_MANIFEST"));
|
||||||
|
const PROCESS_ENV = sanitizedEnvironment(definedEnvironment());
|
||||||
const RULES_PATH = "repos/commons/code-rules/raw/README.md";
|
const RULES_PATH = "repos/commons/code-rules/raw/README.md";
|
||||||
const CODEX_AUTH = "/root/.codex/auth.json";
|
const CODEX_AUTH = "/root/.codex/auth.json";
|
||||||
const SKILLS_INSTALL = "skills add obra/superpowers";
|
const SKILLS_INSTALL = "skills add obra/superpowers";
|
||||||
|
|
||||||
|
async function gitea(path: string, body?: unknown): Promise<Response> {
|
||||||
|
const response = await fetch(`${API}/${path}`, {
|
||||||
|
method: body === undefined ? "GET" : "POST",
|
||||||
|
headers: {
|
||||||
|
Authorization: `token ${AUTHOR_TOKEN}`,
|
||||||
|
"Content-Type": "application/json",
|
||||||
|
},
|
||||||
|
body: body === undefined ? undefined : JSON.stringify(body),
|
||||||
|
});
|
||||||
|
if (!response.ok) {
|
||||||
|
throw new Error(`${path}: ${response.status} ${await response.text()}`);
|
||||||
|
}
|
||||||
|
return response;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function postAuthorComment(body: string): Promise<void> {
|
||||||
|
await gitea(`repos/${REPO}/issues/${INDEX}/comments`, { body });
|
||||||
|
}
|
||||||
|
|
||||||
async function runRoot(command: string, args: string[]): Promise<void> {
|
async function runRoot(command: string, args: string[]): Promise<void> {
|
||||||
const { success, code } = await output(command, { args, env: PROCESS_ENV, clearEnv: true });
|
const { success, code } = await output(command, { args, env: PROCESS_ENV, clearEnv: true });
|
||||||
if (!success) {
|
if (!success) throw new Error(`${command} ${args[0]} exited with ${code}`);
|
||||||
throw new Error(`${command} ${args[0]} exited with ${code}`);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
async function configureGitAuthor(): Promise<void> {
|
async function configureGitAuthor(): Promise<void> {
|
||||||
const user: unknown = await (await gitea("user")).json();
|
const user: unknown = await (await gitea("user")).json();
|
||||||
if (!isObject(user) || typeof user.login !== "string" || typeof user.email !== "string") {
|
if (!isObject(user) || typeof user["login"] !== "string" || typeof user["email"] !== "string") {
|
||||||
throw new Error("user: unexpected Gitea response");
|
throw new Error("user: unexpected Gitea response");
|
||||||
}
|
}
|
||||||
await runRoot("git", ["config", "user.name", user.login]);
|
await runRoot("git", ["config", "user.name", user["login"]]);
|
||||||
await runRoot("git", ["config", "user.email", user.email]);
|
await runRoot("git", ["config", "user.email", user["email"]]);
|
||||||
}
|
}
|
||||||
|
|
||||||
async function readProfileToken(profile: RuntimeProfile): Promise<string | undefined> {
|
async function readProfileToken(profile: RuntimeProfile): Promise<string | undefined> {
|
||||||
@@ -63,6 +116,20 @@ async function readProfileToken(profile: RuntimeProfile): Promise<string | undef
|
|||||||
return token;
|
return token;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function runAgentCommand(
|
||||||
|
profile: RuntimeProfile,
|
||||||
|
command: string,
|
||||||
|
args: string[],
|
||||||
|
token?: string,
|
||||||
|
): Promise<void> {
|
||||||
|
const { success, code } = await agentCommand(profile, command, args, {
|
||||||
|
cwd: WORKSPACE,
|
||||||
|
env: agentEnvironment(PROCESS_ENV, profile, token),
|
||||||
|
clearEnv: true,
|
||||||
|
}).output();
|
||||||
|
if (!success) throw new Error(`${command} ${args[0]} exited with ${code}`);
|
||||||
|
}
|
||||||
|
|
||||||
async function prepareProfile(profile: RuntimeProfile): Promise<void> {
|
async function prepareProfile(profile: RuntimeProfile): Promise<void> {
|
||||||
await runAgentCommand(profile, "git", [
|
await runAgentCommand(profile, "git", [
|
||||||
"config",
|
"config",
|
||||||
@@ -84,21 +151,22 @@ async function prepareProfile(profile: RuntimeProfile): Promise<void> {
|
|||||||
// One issue comment as the prompt quotes it.
|
// One issue comment as the prompt quotes it.
|
||||||
function formatComment(comment: unknown): string {
|
function formatComment(comment: unknown): string {
|
||||||
const { user, created_at: createdAt, body } = isObject(comment) ? comment : {};
|
const { user, created_at: createdAt, body } = isObject(comment) ? comment : {};
|
||||||
const login = isObject(user) ? user.login : undefined;
|
const login = isObject(user) ? user["login"] : undefined;
|
||||||
return `## ${String(login)} at ${String(createdAt)}\n\n${String(body)}\n`;
|
return `## ${String(login)} at ${String(createdAt)}\n\n${String(body)}\n`;
|
||||||
}
|
}
|
||||||
|
|
||||||
async function promptValues(
|
async function renderPrompt(
|
||||||
reviewPath: string,
|
profile: RuntimeProfile,
|
||||||
anchorsPath: string,
|
): Promise<{ prompt: string; reviewPath: string; anchorsPath: string }> {
|
||||||
): Promise<Record<string, string>> {
|
const reviewPath = await makeProfileFile(profile, "review.md");
|
||||||
|
const anchorsPath = await makeProfileFile(profile, "anchors.json");
|
||||||
const comments: unknown = await (
|
const comments: unknown = await (
|
||||||
await gitea(`repos/${REPO}/issues/${INDEX}/comments?limit=100`)
|
await gitea(`repos/${REPO}/issues/${INDEX}/comments?limit=100`)
|
||||||
).json();
|
).json();
|
||||||
if (!Array.isArray(comments)) {
|
if (!Array.isArray(comments)) {
|
||||||
throw new TypeError("comments: unexpected Gitea response");
|
throw new TypeError("comments: unexpected Gitea response");
|
||||||
}
|
}
|
||||||
return {
|
const values: Record<string, string> = {
|
||||||
COMMENT: env("COMMENT"),
|
COMMENT: env("COMMENT"),
|
||||||
ISSUE_COMMENTS: comments.map((comment: unknown) => formatComment(comment)).join("\n"),
|
ISSUE_COMMENTS: comments.map((comment: unknown) => formatComment(comment)).join("\n"),
|
||||||
CODE_RULES: await (await gitea(RULES_PATH)).text(),
|
CODE_RULES: await (await gitea(RULES_PATH)).text(),
|
||||||
@@ -109,12 +177,6 @@ async function promptValues(
|
|||||||
REVIEW_PATH: reviewPath,
|
REVIEW_PATH: reviewPath,
|
||||||
ANCHORS_PATH: anchorsPath,
|
ANCHORS_PATH: anchorsPath,
|
||||||
};
|
};
|
||||||
}
|
|
||||||
|
|
||||||
async function renderPrompt(profile: RuntimeProfile): Promise<RenderedPrompt> {
|
|
||||||
const reviewPath = await makeProfileFile(profile, "review.md");
|
|
||||||
const anchorsPath = await makeProfileFile(profile, "anchors.json");
|
|
||||||
const values = await promptValues(reviewPath, anchorsPath);
|
|
||||||
const template = await readFile(new URL("../prompt.md", import.meta.url), "utf8");
|
const template = await readFile(new URL("../prompt.md", import.meta.url), "utf8");
|
||||||
return {
|
return {
|
||||||
prompt: template.replaceAll(
|
prompt: template.replaceAll(
|
||||||
@@ -126,45 +188,314 @@ async function renderPrompt(profile: RuntimeProfile): Promise<RenderedPrompt> {
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function runClaude(profile: RuntimeProfile, token: string, prompt: string): Promise<string> {
|
||||||
|
const claude = agentCommand(
|
||||||
|
profile,
|
||||||
|
"claude",
|
||||||
|
[
|
||||||
|
"--print",
|
||||||
|
"--dangerously-skip-permissions",
|
||||||
|
"--model",
|
||||||
|
profile.model,
|
||||||
|
"--output-format",
|
||||||
|
"stream-json",
|
||||||
|
"--verbose",
|
||||||
|
prompt,
|
||||||
|
],
|
||||||
|
{
|
||||||
|
cwd: WORKSPACE,
|
||||||
|
env: {
|
||||||
|
...agentEnvironment(PROCESS_ENV, profile, token),
|
||||||
|
IS_SANDBOX: "1",
|
||||||
|
},
|
||||||
|
clearEnv: true,
|
||||||
|
stdout: "piped",
|
||||||
|
stderr: "piped",
|
||||||
|
},
|
||||||
|
).spawn();
|
||||||
|
let result: ClaudeResult | undefined;
|
||||||
|
let error = "";
|
||||||
|
const copyError = (async (): Promise<void> => {
|
||||||
|
const decoder = new TextDecoder();
|
||||||
|
for await (const chunk of chunks(claude.stderr)) {
|
||||||
|
const part = decoder.decode(chunk, { stream: true });
|
||||||
|
error += part;
|
||||||
|
console.error(part);
|
||||||
|
}
|
||||||
|
error += decoder.decode();
|
||||||
|
})();
|
||||||
|
for await (const line of createInterface({ input: claude.stdout, crlfDelay: Infinity })) {
|
||||||
|
if (line !== "") {
|
||||||
|
const event: unknown = JSON.parse(line);
|
||||||
|
if (isObject(event)) {
|
||||||
|
const content = isObject(event["message"]) ? event["message"]["content"] : undefined;
|
||||||
|
for (const part of Array.isArray(content) ? content : []) {
|
||||||
|
if (isObject(part)) {
|
||||||
|
const text = part["thinking"] ?? part["text"] ?? part["name"];
|
||||||
|
if (typeof text === "string" && text !== "") {
|
||||||
|
console.log(text);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (event["type"] === "result") {
|
||||||
|
const { is_error: isError, result: answer, subtype, api_error_status: apiStatus } = event;
|
||||||
|
result = {
|
||||||
|
is_error: typeof isError === "boolean" ? isError : undefined,
|
||||||
|
result: typeof answer === "string" ? answer : undefined,
|
||||||
|
subtype: String(subtype),
|
||||||
|
api_error_status:
|
||||||
|
typeof apiStatus === "number" || apiStatus === null ? apiStatus : undefined,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
const [status] = await Promise.all([claude.status, copyError]);
|
||||||
|
if (result?.is_error === true) {
|
||||||
|
const failure = new Error(result.result ?? `claude ended with ${result.subtype}`);
|
||||||
|
if (isClaudeAuthFailure(result)) {
|
||||||
|
throw new AgentAuthError("claude sign-in failed", { cause: failure });
|
||||||
|
}
|
||||||
|
throw failure;
|
||||||
|
}
|
||||||
|
if (result?.result === undefined) {
|
||||||
|
throw new Error(error.trim() || `claude ended with ${result?.subtype ?? "no result"}`);
|
||||||
|
}
|
||||||
|
if (!status.success) {
|
||||||
|
throw new Error(error.trim() || `claude exited with ${status.code}`);
|
||||||
|
}
|
||||||
|
return result.result;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Polls every 100 ms until the login prints something, failing if it exits first.
|
||||||
|
async function pollForInstructions(
|
||||||
|
shownText: () => string,
|
||||||
|
status: Promise<CommandStatus>,
|
||||||
|
): Promise<void> {
|
||||||
|
if (shownText().trim() !== "") {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
const exited = await Promise.race([status.then(() => true), sleep(100, false)]);
|
||||||
|
if (exited) {
|
||||||
|
throw new AgentAuthError("AI bot login produced no instructions");
|
||||||
|
}
|
||||||
|
await pollForInstructions(shownText, status);
|
||||||
|
}
|
||||||
|
|
||||||
|
async function codexDeviceLogin(
|
||||||
|
profile: RuntimeProfile,
|
||||||
|
environment: Record<string, string>,
|
||||||
|
): Promise<void> {
|
||||||
|
const login = agentCommand(profile, "codex", ["login", "--device-auth"], {
|
||||||
|
cwd: WORKSPACE,
|
||||||
|
env: environment,
|
||||||
|
clearEnv: true,
|
||||||
|
stdout: "piped",
|
||||||
|
stderr: "piped",
|
||||||
|
}).spawn();
|
||||||
|
let shown = "";
|
||||||
|
const collect = async (stream: Readable): Promise<void> => {
|
||||||
|
const decoder = new TextDecoder();
|
||||||
|
for await (const chunk of chunks(stream)) {
|
||||||
|
shown += decoder.decode(chunk, { stream: true });
|
||||||
|
}
|
||||||
|
shown += decoder.decode();
|
||||||
|
};
|
||||||
|
const drained = Promise.all([collect(login.stdout), collect(login.stderr)]);
|
||||||
|
const status = login.status;
|
||||||
|
await sleep(3000);
|
||||||
|
await pollForInstructions(() => shown, status);
|
||||||
|
await postAuthorComment(withProfile(shown, profile));
|
||||||
|
const [result] = await Promise.all([status, drained]);
|
||||||
|
if (!result.success) {
|
||||||
|
throw new AgentAuthError(`codex login exited with ${result.code}`);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
async function codexApiLogin(
|
||||||
|
profile: RuntimeProfile,
|
||||||
|
environment: Record<string, string>,
|
||||||
|
token: string,
|
||||||
|
): Promise<void> {
|
||||||
|
const login = agentCommand(profile, "codex", ["login", "--with-api-key"], {
|
||||||
|
cwd: WORKSPACE,
|
||||||
|
env: environment,
|
||||||
|
clearEnv: true,
|
||||||
|
stdin: "piped",
|
||||||
|
stderr: "piped",
|
||||||
|
}).spawn();
|
||||||
|
await endWith(login.stdin, `${token}\n`);
|
||||||
|
const [status, error] = await Promise.all([login.status, readText(login.stderr)]);
|
||||||
|
if (!status.success) {
|
||||||
|
throw new Error(error.trim() || `codex login exited with ${status.code}`);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
async function makeProfileFile(profile: RuntimeProfile, name: string): Promise<string> {
|
||||||
|
const path = `${profile.home}/${name}`;
|
||||||
|
await writeFile(path, "", { mode: 0o600 });
|
||||||
|
await chmod(path, 0o600);
|
||||||
|
await chown(path, profile.uid, profile.gid);
|
||||||
|
return path;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function runCodex(
|
||||||
|
profile: RuntimeProfile,
|
||||||
|
prompt: string,
|
||||||
|
authentication: CodexAuthentication,
|
||||||
|
): Promise<string> {
|
||||||
|
const token = authentication.kind === "api-key" ? authentication.token : undefined;
|
||||||
|
const environment = agentEnvironment(PROCESS_ENV, profile, token);
|
||||||
|
if (authentication.kind === "api-key") {
|
||||||
|
await codexApiLogin(profile, environment, authentication.token);
|
||||||
|
} else {
|
||||||
|
const loggedIn = await agentCommand(profile, "codex", ["login", "status"], {
|
||||||
|
cwd: WORKSPACE,
|
||||||
|
env: environment,
|
||||||
|
clearEnv: true,
|
||||||
|
}).output();
|
||||||
|
if (!loggedIn.success) await codexDeviceLogin(profile, environment);
|
||||||
|
}
|
||||||
|
const outputPath = await makeProfileFile(profile, "result.md");
|
||||||
|
const attempt = async (): Promise<{ status: CommandStatus; error: string }> => {
|
||||||
|
const codex = agentCommand(
|
||||||
|
profile,
|
||||||
|
"codex",
|
||||||
|
[
|
||||||
|
"exec",
|
||||||
|
"--model",
|
||||||
|
profile.model,
|
||||||
|
"--dangerously-bypass-approvals-and-sandbox",
|
||||||
|
"--output-last-message",
|
||||||
|
outputPath,
|
||||||
|
prompt,
|
||||||
|
],
|
||||||
|
{
|
||||||
|
cwd: WORKSPACE,
|
||||||
|
env: environment,
|
||||||
|
clearEnv: true,
|
||||||
|
stdout: "inherit",
|
||||||
|
stderr: "piped",
|
||||||
|
},
|
||||||
|
).spawn();
|
||||||
|
const decoder = new TextDecoder();
|
||||||
|
let error = "";
|
||||||
|
for await (const chunk of chunks(codex.stderr)) {
|
||||||
|
await writeChunk(process.stderr, chunk);
|
||||||
|
error += decoder.decode(chunk, { stream: true });
|
||||||
|
}
|
||||||
|
error += decoder.decode();
|
||||||
|
// Codex echoes the prompt, whose comments may quote auth errors.
|
||||||
|
return { status: await codex.status, error: error.replaceAll(prompt, "") };
|
||||||
|
};
|
||||||
|
const result =
|
||||||
|
authentication.kind === "api-key"
|
||||||
|
? await attempt()
|
||||||
|
: await retryInvalidToken(attempt, async () => {
|
||||||
|
await runAgentCommand(profile, "codex", ["logout"]);
|
||||||
|
await codexDeviceLogin(profile, environment);
|
||||||
|
});
|
||||||
|
if (!result.status.success) {
|
||||||
|
const failure = new Error(result.error.trim() || `codex exited with ${result.status.code}`);
|
||||||
|
if (isCodexAuthFailure(result.error)) {
|
||||||
|
throw new AgentAuthError("codex sign-in failed", { cause: failure });
|
||||||
|
}
|
||||||
|
throw failure;
|
||||||
|
}
|
||||||
|
return outputPath;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function runOpenCode(
|
||||||
|
profile: RuntimeProfile,
|
||||||
|
token: string,
|
||||||
|
prompt: string,
|
||||||
|
): Promise<string> {
|
||||||
|
const child = agentCommand(profile, "opencode", openCodeArgs(profile.model, prompt), {
|
||||||
|
cwd: WORKSPACE,
|
||||||
|
env: agentEnvironment(PROCESS_ENV, profile, token),
|
||||||
|
clearEnv: true,
|
||||||
|
stdout: "piped",
|
||||||
|
stderr: "piped",
|
||||||
|
}).spawn();
|
||||||
|
const collected = collectOpenCodeOutput(
|
||||||
|
chunks(child.stdout),
|
||||||
|
chunks(child.stderr),
|
||||||
|
async (chunk) => {
|
||||||
|
await writeChunk(process.stdout, chunk);
|
||||||
|
},
|
||||||
|
async (chunk) => {
|
||||||
|
await writeChunk(process.stderr, chunk);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
const [status, streams] = await Promise.all([child.status, collected]);
|
||||||
|
const error = streams.stderr.trim();
|
||||||
|
if (!status.success) {
|
||||||
|
throw (
|
||||||
|
openCodeError(streams.stdout) ?? new Error(error || `opencode exited with ${status.code}`)
|
||||||
|
);
|
||||||
|
}
|
||||||
|
return parseOpenCodeEvents(streams.stdout);
|
||||||
|
}
|
||||||
|
|
||||||
async function runProfile(profile: RuntimeProfile): Promise<AttemptResult> {
|
async function runProfile(profile: RuntimeProfile): Promise<AttemptResult> {
|
||||||
const token = await readProfileToken(profile);
|
const token = await readProfileToken(profile);
|
||||||
const authentication = profile.type === "codex" ? codexAuthentication(token) : null;
|
const authentication = profile.type === "codex" ? codexAuthentication(token) : null;
|
||||||
let stagedCodexAuth: string | null = null;
|
let stagedCodexAuth: string | null = null;
|
||||||
let answer: AgentAnswer = {};
|
let body: string | undefined;
|
||||||
let rendered: RenderedPrompt | undefined;
|
let resultPath: string | null = null;
|
||||||
|
let reviewPath: string | undefined;
|
||||||
|
let anchorsPath: string | undefined;
|
||||||
try {
|
try {
|
||||||
if (authentication?.kind === "persistent") {
|
if (authentication?.kind === "persistent") {
|
||||||
stagedCodexAuth = await stageCodexAuth(CODEX_AUTH, profile.home, profile.uid, profile.gid);
|
stagedCodexAuth = await stageCodexAuth(CODEX_AUTH, profile.home, profile.uid, profile.gid);
|
||||||
}
|
}
|
||||||
await prepareProfile(profile);
|
await prepareProfile(profile);
|
||||||
rendered = await renderPrompt(profile);
|
const rendered = await renderPrompt(profile);
|
||||||
answer = await runAgent(profile, token, rendered.prompt, authentication);
|
reviewPath = rendered.reviewPath;
|
||||||
|
anchorsPath = rendered.anchorsPath;
|
||||||
|
if (profile.type === "claude") {
|
||||||
|
body = await runClaude(profile, token ?? "", rendered.prompt);
|
||||||
|
} else if (profile.type === "codex") {
|
||||||
|
resultPath = await runCodex(
|
||||||
|
profile,
|
||||||
|
rendered.prompt,
|
||||||
|
authentication ?? codexAuthentication(token),
|
||||||
|
);
|
||||||
|
} else {
|
||||||
|
body = await runOpenCode(profile, token ?? "", rendered.prompt);
|
||||||
|
}
|
||||||
} finally {
|
} finally {
|
||||||
await killProfileProcesses(profile.uid);
|
await killProfileProcesses(profile.uid);
|
||||||
if (stagedCodexAuth !== null) {
|
if (stagedCodexAuth !== null) {
|
||||||
await persistCodexAuth(stagedCodexAuth, CODEX_AUTH);
|
await persistCodexAuth(stagedCodexAuth, CODEX_AUTH);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
const body =
|
if (resultPath !== null) body = await readProfileFile(profile, resultPath);
|
||||||
answer.resultPath === undefined
|
if (body === undefined || reviewPath === undefined || anchorsPath === undefined) {
|
||||||
? answer.body
|
|
||||||
: await readProfileFile(profile, answer.resultPath);
|
|
||||||
if (body === undefined || rendered === undefined) {
|
|
||||||
throw new Error("agent attempt produced no result");
|
throw new Error("agent attempt produced no result");
|
||||||
}
|
}
|
||||||
const { reviewPath, anchorsPath } = rendered;
|
return {
|
||||||
return { body, reviewPath, anchorsPath, profile: { type: profile.type, model: profile.model } };
|
body,
|
||||||
|
reviewPath,
|
||||||
|
anchorsPath,
|
||||||
|
profile: { type: profile.type, model: profile.model },
|
||||||
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
async function writeOutcome(outcome: RuntimeOutcome): Promise<void> {
|
async function writeOutcome(outcome: RuntimeOutcome): Promise<void> {
|
||||||
await writeFile(MANIFEST.outcomeFile, JSON.stringify(outcome), { mode: 0o600 });
|
await writeFile(MANIFEST.outcomeFile, JSON.stringify(outcome), {
|
||||||
|
mode: 0o600,
|
||||||
|
});
|
||||||
await chmod(MANIFEST.outcomeFile, 0o600);
|
await chmod(MANIFEST.outcomeFile, 0o600);
|
||||||
}
|
}
|
||||||
|
|
||||||
const failures: ProfileFailure[] = [];
|
const failures: ProfileFailure[] = [];
|
||||||
try {
|
try {
|
||||||
await configureGitAuthor();
|
await configureGitAuthor();
|
||||||
await writeOutcome({ ok: true, ...(await runProfiles(MANIFEST.profiles, runProfile, failures)) });
|
await writeOutcome({
|
||||||
|
ok: true,
|
||||||
|
...(await runProfiles(MANIFEST.profiles, runProfile, failures)),
|
||||||
|
});
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error(error);
|
console.error(error);
|
||||||
await writeOutcome({ ok: false, failures });
|
await writeOutcome({ ok: false, failures });
|
||||||
|
|||||||
+28
-27
@@ -39,24 +39,6 @@ async function writePrivate(path: string, value: string, uid: number, gid: numbe
|
|||||||
await chown(path, uid, gid);
|
await chown(path, uid, gid);
|
||||||
}
|
}
|
||||||
|
|
||||||
async function prepareProfile(
|
|
||||||
runtimeDir: string,
|
|
||||||
profile: BotProfile,
|
|
||||||
index: number,
|
|
||||||
): Promise<RuntimeProfile> {
|
|
||||||
const uid = FIRST_PROFILE_UID + index;
|
|
||||||
const home = join(runtimeDir, `profile-${index}`);
|
|
||||||
await mkdir(home, { mode: 0o700 });
|
|
||||||
await chmod(home, 0o700);
|
|
||||||
await chown(home, uid, uid);
|
|
||||||
const tokenFile =
|
|
||||||
profile.token === undefined || profile.token === "" ? null : join(home, "token");
|
|
||||||
if (tokenFile !== null && profile.token !== undefined) {
|
|
||||||
await writePrivate(tokenFile, profile.token, uid, uid);
|
|
||||||
}
|
|
||||||
return { index, type: profile.type, model: profile.model, uid, gid: uid, home, tokenFile };
|
|
||||||
}
|
|
||||||
|
|
||||||
export async function prepareRuntime(
|
export async function prepareRuntime(
|
||||||
actionPath: string,
|
actionPath: string,
|
||||||
runtimeRoot: string,
|
runtimeRoot: string,
|
||||||
@@ -74,10 +56,29 @@ export async function prepareRuntime(
|
|||||||
|
|
||||||
// One profile at a time, in order, as each claims the next UID.
|
// One profile at a time, in order, as each claims the next UID.
|
||||||
const profiles = await credentials.profiles.reduce<Promise<RuntimeProfile[]>>(
|
const profiles = await credentials.profiles.reduce<Promise<RuntimeProfile[]>>(
|
||||||
async (previous, profile, index) => [
|
async (previous, profile, index) => {
|
||||||
...(await previous),
|
const prepared = await previous;
|
||||||
await prepareProfile(runtimeDir, profile, index),
|
const uid = FIRST_PROFILE_UID + index;
|
||||||
],
|
const home = join(runtimeDir, `profile-${index}`);
|
||||||
|
await mkdir(home, { mode: 0o700 });
|
||||||
|
await chmod(home, 0o700);
|
||||||
|
await chown(home, uid, uid);
|
||||||
|
const tokenFile =
|
||||||
|
profile.token === undefined || profile.token === "" ? null : join(home, "token");
|
||||||
|
if (tokenFile !== null && profile.token !== undefined) {
|
||||||
|
await writePrivate(tokenFile, profile.token, uid, uid);
|
||||||
|
}
|
||||||
|
prepared.push({
|
||||||
|
index,
|
||||||
|
type: profile.type,
|
||||||
|
model: profile.model,
|
||||||
|
uid,
|
||||||
|
gid: uid,
|
||||||
|
home,
|
||||||
|
tokenFile,
|
||||||
|
});
|
||||||
|
return prepared;
|
||||||
|
},
|
||||||
Promise.resolve([]),
|
Promise.resolve([]),
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -100,11 +101,11 @@ export async function prepareRuntime(
|
|||||||
function isRuntimeManifest(value: unknown): value is RuntimeManifest {
|
function isRuntimeManifest(value: unknown): value is RuntimeManifest {
|
||||||
return (
|
return (
|
||||||
isMapping(value) &&
|
isMapping(value) &&
|
||||||
typeof value.runtimeDir === "string" &&
|
typeof value["runtimeDir"] === "string" &&
|
||||||
typeof value.manifestPath === "string" &&
|
typeof value["manifestPath"] === "string" &&
|
||||||
typeof value.reviewerFile === "string" &&
|
typeof value["reviewerFile"] === "string" &&
|
||||||
typeof value.outcomeFile === "string" &&
|
typeof value["outcomeFile"] === "string" &&
|
||||||
Array.isArray(value.profiles)
|
Array.isArray(value["profiles"])
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -16,7 +16,7 @@ const PHASES: [phase: string, firstVariable: string][] = [
|
|||||||
|
|
||||||
test.each(PHASES)("Node loads the %s phase", async (phase, firstVariable) => {
|
test.each(PHASES)("Node loads the %s phase", async (phase, firstVariable) => {
|
||||||
const path = fileURLToPath(new URL(`../src/${phase}.ts`, import.meta.url));
|
const path = fileURLToPath(new URL(`../src/${phase}.ts`, import.meta.url));
|
||||||
const result = await runCommand(process.execPath, [path], { PATH: process.env.PATH ?? "" });
|
const result = await runCommand(process.execPath, [path], { PATH: process.env["PATH"] ?? "" });
|
||||||
expect(result.success).toBe(false);
|
expect(result.success).toBe(false);
|
||||||
expect(result.stderr).toContain(`${firstVariable} is not set`);
|
expect(result.stderr).toContain(`${firstVariable} is not set`);
|
||||||
});
|
});
|
||||||
|
|||||||
+21
-21
@@ -48,11 +48,11 @@ test("all committed YAML parses", async () => {
|
|||||||
|
|
||||||
test("the action exposes only the master key and scopes it to preparation", async () => {
|
test("the action exposes only the master key and scopes it to preparation", async () => {
|
||||||
const action = await yaml("action.yml");
|
const action = await yaml("action.yml");
|
||||||
expect(Object.keys(mapping(action.inputs, "inputs"))).toStrictEqual(["master-key"]);
|
expect(Object.keys(mapping(action["inputs"], "inputs"))).toStrictEqual(["master-key"]);
|
||||||
const steps = sequence(mapping(action.runs, "runs").steps, "runs.steps");
|
const steps = sequence(mapping(action["runs"], "runs")["steps"], "runs.steps");
|
||||||
for (const step of steps) {
|
for (const step of steps) {
|
||||||
if (typeof step.run === "string") {
|
if (typeof step["run"] === "string") {
|
||||||
expect(step.run.includes("\n"), String(step.name)).toBe(false);
|
expect(step["run"].includes("\n"), String(step["name"])).toBe(false);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
const checkout = findStep(steps, "uses", "actions/checkout@v4");
|
const checkout = findStep(steps, "uses", "actions/checkout@v4");
|
||||||
@@ -60,16 +60,16 @@ test("the action exposes only the master key and scopes it to preparation", asyn
|
|||||||
const agent = findStep(steps, "id", "agent");
|
const agent = findStep(steps, "id", "agent");
|
||||||
const post = findStep(steps, "id", "post");
|
const post = findStep(steps, "id", "post");
|
||||||
findStep(steps, "id", "source");
|
findStep(steps, "id", "source");
|
||||||
expect(mapping(checkout.with, "checkout.with").token).toBe("${{ gitea.token }}");
|
expect(mapping(checkout["with"], "checkout.with")["token"]).toBe("${{ gitea.token }}");
|
||||||
expect(mapping(prepare.env, "prepare.env").BOT_AGENTS_MASTER_KEY).toBe(
|
expect(mapping(prepare["env"], "prepare.env")["BOT_AGENTS_MASTER_KEY"]).toBe(
|
||||||
"${{ inputs.master-key }}",
|
"${{ inputs.master-key }}",
|
||||||
);
|
);
|
||||||
expect(JSON.stringify(agent).includes("BOT_AGENTS_MASTER_KEY")).toBe(false);
|
expect(JSON.stringify(agent).includes("BOT_AGENTS_MASTER_KEY")).toBe(false);
|
||||||
expect(JSON.stringify(post).includes("BOT_AGENTS_MASTER_KEY")).toBe(false);
|
expect(JSON.stringify(post).includes("BOT_AGENTS_MASTER_KEY")).toBe(false);
|
||||||
expect(mapping(agent.env, "agent.env").GITEA_TOKEN).toBe("${{ gitea.token }}");
|
expect(mapping(agent["env"], "agent.env")["GITEA_TOKEN"]).toBe("${{ gitea.token }}");
|
||||||
assert(String(post.if).includes("always()"));
|
assert(String(post["if"]).includes("always()"));
|
||||||
for (const step of [prepare, agent, post]) {
|
for (const step of [prepare, agent, post]) {
|
||||||
assert(String(step.run).includes("steps.source.outputs.path"));
|
assert(String(step["run"]).includes("steps.source.outputs.path"));
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -118,17 +118,17 @@ test("module-relative runtime assets exist", async () => {
|
|||||||
|
|
||||||
test("the repository uses its trusted main action", async () => {
|
test("the repository uses its trusted main action", async () => {
|
||||||
const workflow = await yaml(".gitea/workflows/agents.yml");
|
const workflow = await yaml(".gitea/workflows/agents.yml");
|
||||||
const job = mapping(mapping(workflow.jobs, "jobs").agent, "jobs.agent");
|
const job = mapping(mapping(workflow["jobs"], "jobs")["agent"], "jobs.agent");
|
||||||
const permissions = mapping(job.permissions, "jobs.agent.permissions");
|
const permissions = mapping(job["permissions"], "jobs.agent.permissions");
|
||||||
expect(permissions).toStrictEqual({
|
expect(permissions).toStrictEqual({
|
||||||
code: "write",
|
code: "write",
|
||||||
issues: "write",
|
issues: "write",
|
||||||
"pull-requests": "write",
|
"pull-requests": "write",
|
||||||
});
|
});
|
||||||
const steps = sequence(job.steps, "jobs.agent.steps");
|
const steps = sequence(job["steps"], "jobs.agent.steps");
|
||||||
expect(steps.findIndex((step) => step.uses === "./")).toStrictEqual(-1);
|
expect(steps.findIndex((step) => step["uses"] === "./")).toStrictEqual(-1);
|
||||||
const trusted = findStep(steps, "uses", "https://git.capsulizers.com/commons/bot-agents@main");
|
const trusted = findStep(steps, "uses", "https://git.capsulizers.com/commons/bot-agents@main");
|
||||||
expect(mapping(trusted.with, "trusted.with")["master-key"]).toBe(
|
expect(mapping(trusted["with"], "trusted.with")["master-key"]).toBe(
|
||||||
"${{ secrets.BOT_AGENTS_MASTER_KEY }}",
|
"${{ secrets.BOT_AGENTS_MASTER_KEY }}",
|
||||||
);
|
);
|
||||||
expect(JSON.stringify(workflow).includes("gitea.actor != 'bot'")).toBe(true);
|
expect(JSON.stringify(workflow).includes("gitea.actor != 'bot'")).toBe(true);
|
||||||
@@ -136,9 +136,9 @@ test("the repository uses its trusted main action", async () => {
|
|||||||
|
|
||||||
test("CI checks every phase and the root isolation suite", async () => {
|
test("CI checks every phase and the root isolation suite", async () => {
|
||||||
const workflow = await yaml(".gitea/workflows/check.yml");
|
const workflow = await yaml(".gitea/workflows/check.yml");
|
||||||
const job = mapping(mapping(workflow.jobs, "jobs").check, "jobs.check");
|
const job = mapping(mapping(workflow["jobs"], "jobs")["check"], "jobs.check");
|
||||||
const commands = sequence(job.steps, "jobs.check.steps")
|
const commands = sequence(job["steps"], "jobs.check.steps")
|
||||||
.map((step) => (typeof step.run === "string" ? step.run : ""))
|
.map((step) => (typeof step["run"] === "string" ? step["run"] : ""))
|
||||||
.join("\n");
|
.join("\n");
|
||||||
// `vp check` type-checks every phase, and `vp test` runs each of them under
|
// `vp check` type-checks every phase, and `vp test` runs each of them under
|
||||||
// Node as well as the root-only isolation tests.
|
// Node as well as the root-only isolation tests.
|
||||||
@@ -170,8 +170,8 @@ test("profile preparation does not receive provider credentials", async () => {
|
|||||||
|
|
||||||
test("central profiles fall back from Codex to Claude to OpenCode", async () => {
|
test("central profiles fall back from Codex to Claude to OpenCode", async () => {
|
||||||
const credentials: unknown = JSON.parse(await readFile("profiles.json", "utf8"));
|
const credentials: unknown = JSON.parse(await readFile("profiles.json", "utf8"));
|
||||||
const profiles = sequence(mapping(credentials, "profiles.json").profiles, "profiles");
|
const profiles = sequence(mapping(credentials, "profiles.json")["profiles"], "profiles");
|
||||||
expect(profiles.map((profile) => profile.type)).toStrictEqual(["codex", "claude", "opencode"]);
|
expect(profiles.map((profile) => profile["type"])).toStrictEqual(["codex", "claude", "opencode"]);
|
||||||
expect(profiles[2]?.model).toBe("openrouter/qwen/qwen3.8-27b");
|
expect(profiles[2]?.["model"]).toBe("openrouter/qwen/qwen3.8-27b");
|
||||||
assert(String(profiles[2]?.token).startsWith("v1:"));
|
assert(String(profiles[2]?.["token"]).startsWith("v1:"));
|
||||||
});
|
});
|
||||||
|
|||||||
+1
-1
@@ -9,8 +9,8 @@
|
|||||||
"erasableSyntaxOnly": true,
|
"erasableSyntaxOnly": true,
|
||||||
"verbatimModuleSyntax": true,
|
"verbatimModuleSyntax": true,
|
||||||
"strict": true,
|
"strict": true,
|
||||||
"exactOptionalPropertyTypes": true,
|
|
||||||
"noUncheckedIndexedAccess": true,
|
"noUncheckedIndexedAccess": true,
|
||||||
|
"noPropertyAccessFromIndexSignature": true,
|
||||||
"noImplicitOverride": true,
|
"noImplicitOverride": true,
|
||||||
"noImplicitReturns": true,
|
"noImplicitReturns": true,
|
||||||
"noFallthroughCasesInSwitch": true,
|
"noFallthroughCasesInSwitch": true,
|
||||||
|
|||||||
Reference in New Issue
Block a user