Compare commits
5 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 3419e0a978 | |||
| 4ed8b48b7a | |||
| 0d109ebec8 | |||
| a2bc4c9541 | |||
| 75d3593376 |
@@ -20,6 +20,11 @@ inputs:
|
|||||||
bot-token:
|
bot-token:
|
||||||
description: API key or token for the selected bot
|
description: API key or token for the selected bot
|
||||||
required: false
|
required: false
|
||||||
|
model:
|
||||||
|
description: >-
|
||||||
|
Model for the selected bot. Defaults to `claude-sonnet-5` or
|
||||||
|
`gpt-5.6-terra`, the mid tiers, which cover reviews and fixes.
|
||||||
|
required: false
|
||||||
|
|
||||||
runs:
|
runs:
|
||||||
using: composite
|
using: composite
|
||||||
@@ -40,6 +45,7 @@ runs:
|
|||||||
ACTION_PATH: ${{ gitea.action_path }}
|
ACTION_PATH: ${{ gitea.action_path }}
|
||||||
BOT_TYPE: ${{ inputs.bot-type }}
|
BOT_TYPE: ${{ inputs.bot-type }}
|
||||||
BOT_TOKEN: ${{ inputs.bot-token }}
|
BOT_TOKEN: ${{ inputs.bot-token }}
|
||||||
|
MODEL: ${{ inputs.model }}
|
||||||
GITEA_API_URL: ${{ gitea.api_url }}
|
GITEA_API_URL: ${{ gitea.api_url }}
|
||||||
GITEA_REPOSITORY: ${{ gitea.repository }}
|
GITEA_REPOSITORY: ${{ gitea.repository }}
|
||||||
GITEA_TOKEN: ${{ inputs.author-token }}
|
GITEA_TOKEN: ${{ inputs.author-token }}
|
||||||
|
|||||||
@@ -18,26 +18,26 @@ the head of the pull request when there is one, with full history and the
|
|||||||
author's push credentials. Read the code there, run its checks and tests when
|
author's push credentials. Read the code there, run its checks and tests when
|
||||||
they bear on the task, and push from there.
|
they bear on the task, and push from there.
|
||||||
|
|
||||||
For a `pull_request` event, review the PR without changing code, using the
|
For a `pull_request` event, and for a comment on a pull request that asks you to
|
||||||
|
review it, review the PR without changing code, using the
|
||||||
`requesting-code-review` skill from superpowers: run its code reviewer template
|
`requesting-code-review` skill from superpowers: run its code reviewer template
|
||||||
against the PR's base and head, and make its complete output your final response
|
against the PR's base and head. Run the project's checks on the head and treat a
|
||||||
instead of the short comment style above. Run the project's checks on the head
|
failure as at least Important. Check the whole repository against the code rules
|
||||||
and treat a failure as at least Important. Check the whole repository against
|
at the end of this prompt, not only the diff; a violation is at least Important
|
||||||
the code rules at the end of this prompt, not only the diff; a violation is at
|
even when the diff did not cause it. Write the complete review, and nothing
|
||||||
least Important even when the diff did not cause it. Your final response is
|
else, to the file `${REVIEW_PATH}`: it is posted verbatim as a pull request
|
||||||
posted verbatim as a pull request review from the bot account, so it is the
|
review from the bot account, and your final response is not posted at all. The
|
||||||
review text and nothing else: no narration about what you did, verified, or are
|
file's first line must be exactly the verdict and nothing else: `Approved` when
|
||||||
about to post, whether you reviewed yourself or relayed a reviewer subagent. Its
|
the template's answer is yes, `Changes requested` otherwise. The mark in front
|
||||||
first line must be exactly the template's verdict and nothing else: `Yes`, `No`,
|
of it is added when posting, so write the words alone; any other first line is
|
||||||
or `With fixes`. `Yes` approves and the other two request changes; any other
|
posted as a plain comment, which wastes the run. Minor issues alone never block,
|
||||||
first line is posted as a plain comment, which wastes the run. Minor issues
|
and neither does a finding the author has answered in the comment history below
|
||||||
alone never block, and neither does a finding the author has answered in the
|
as intended or a false alarm, once the code or docs make that clear. When the
|
||||||
comment history below as intended or a false alarm, once the code or docs make
|
verdict is `Changes requested`, the second line names what must change in one
|
||||||
that clear. When the verdict is not `Yes`, the second line names what must
|
line, addressed to the author; the author's own agent picks the fixes up, so
|
||||||
change in one line, addressed to the author; the author's own agent picks the
|
never ask `@bot` to make them. For UI changes, check that the result is aligned,
|
||||||
fixes up, so never ask `@bot` to make them. For UI changes, check that the
|
clean, and pixel-perfect, and that included screenshots prove the intended
|
||||||
result is aligned, clean, and pixel-perfect, and that included screenshots prove
|
result was achieved.
|
||||||
the intended result was achieved.
|
|
||||||
|
|
||||||
The review must read at a glance: everything outside `<details>` blocks totals
|
The review must read at a glance: everything outside `<details>` blocks totals
|
||||||
under 512 bytes. Only core information stays visible: the verdict, the summary
|
under 512 bytes. Only core information stays visible: the verdict, the summary
|
||||||
|
|||||||
@@ -20,6 +20,13 @@ const EVENT = env("EVENT_NAME");
|
|||||||
const AUTHOR_TOKEN = env("GITEA_TOKEN");
|
const AUTHOR_TOKEN = env("GITEA_TOKEN");
|
||||||
const REVIEWER_TOKEN = env("REVIEWER_TOKEN");
|
const REVIEWER_TOKEN = env("REVIEWER_TOKEN");
|
||||||
const RULES_PATH = "repos/commons/code-rules/raw/README.md";
|
const RULES_PATH = "repos/commons/code-rules/raw/README.md";
|
||||||
|
// The mid tiers: a run follows a fixed template and the project's checks.
|
||||||
|
const DEFAULT_MODELS: Record<string, string> = {
|
||||||
|
claude: "claude-sonnet-5",
|
||||||
|
codex: "gpt-5.6-terra",
|
||||||
|
};
|
||||||
|
const model = (bot: string): string =>
|
||||||
|
Deno.env.get("MODEL") || DEFAULT_MODELS[bot];
|
||||||
|
|
||||||
// The reviewer token is withheld so the agent cannot approve as the bot.
|
// The reviewer token is withheld so the agent cannot approve as the bot.
|
||||||
const { REVIEWER_TOKEN: _, ...agentEnv } = Deno.env.toObject();
|
const { REVIEWER_TOKEN: _, ...agentEnv } = Deno.env.toObject();
|
||||||
@@ -52,21 +59,30 @@ async function postComment(body: string): Promise<void> {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
// A pull request event is a review request, so the response becomes a review.
|
// A review is posted whenever the agent wrote one, whether a review request or
|
||||||
// Its first line is the verdict; anything unexpected only comments, never
|
// a comment asked for it. It comes through a file, because a final chat message
|
||||||
// approves.
|
// picks up narration while a file's first line is written on purpose. That line
|
||||||
const VERDICTS: Record<string, string> = {
|
// is the verdict, matched whole; anything unexpected only comments, never
|
||||||
Yes: "APPROVED",
|
// approves. The mark in front is added here, so it is never part of the match.
|
||||||
No: "REQUEST_CHANGES",
|
const REVIEW_PATH = `${await Deno.makeTempDir()}/review.md`;
|
||||||
"With fixes": "REQUEST_CHANGES",
|
const VERDICTS: Record<string, [event: string, mark: string]> = {
|
||||||
|
Approved: ["APPROVED", "✅"],
|
||||||
|
"Changes requested": ["REQUEST_CHANGES", "🛑"],
|
||||||
};
|
};
|
||||||
|
|
||||||
async function postResult(body: string): Promise<void> {
|
async function postResult(body: string): Promise<void> {
|
||||||
if (EVENT !== "pull_request") return postComment(body);
|
const review = await Deno.readTextFile(REVIEW_PATH).catch(() => null);
|
||||||
const [verdict] = body.split("\n", 1);
|
if (review === null) {
|
||||||
|
if (EVENT === "pull_request") {
|
||||||
|
throw new Error(`no review was written to ${REVIEW_PATH}`);
|
||||||
|
}
|
||||||
|
return postComment(body);
|
||||||
|
}
|
||||||
|
const [verdict, ...rest] = review.split("\n");
|
||||||
|
const [event, mark] = VERDICTS[verdict.trim()] ?? ["COMMENT", "💬"];
|
||||||
await gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, {
|
await gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, {
|
||||||
body: stripAnsi(body),
|
body: stripAnsi([`${mark} ${verdict.trim()}`, ...rest].join("\n")),
|
||||||
event: VERDICTS[verdict.trim()] ?? "COMMENT",
|
event,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -111,6 +127,7 @@ async function renderPrompt(): Promise<string> {
|
|||||||
GITEA_API_URL: API,
|
GITEA_API_URL: API,
|
||||||
GITEA_REPOSITORY: REPO,
|
GITEA_REPOSITORY: REPO,
|
||||||
ISSUE_INDEX: INDEX,
|
ISSUE_INDEX: INDEX,
|
||||||
|
REVIEW_PATH,
|
||||||
};
|
};
|
||||||
const template = await Deno.readTextFile(
|
const template = await Deno.readTextFile(
|
||||||
new URL("prompt.md", import.meta.url),
|
new URL("prompt.md", import.meta.url),
|
||||||
@@ -134,7 +151,7 @@ async function runClaude(prompt: string): Promise<string> {
|
|||||||
"--print",
|
"--print",
|
||||||
"--dangerously-skip-permissions",
|
"--dangerously-skip-permissions",
|
||||||
"--model",
|
"--model",
|
||||||
"claude-fable-5",
|
model("claude"),
|
||||||
"--output-format",
|
"--output-format",
|
||||||
"stream-json",
|
"stream-json",
|
||||||
"--verbose",
|
"--verbose",
|
||||||
@@ -199,7 +216,7 @@ async function runCodex(prompt: string): Promise<string> {
|
|||||||
args: [
|
args: [
|
||||||
"exec",
|
"exec",
|
||||||
"--model",
|
"--model",
|
||||||
"gpt-5.5",
|
model("codex"),
|
||||||
"--dangerously-bypass-approvals-and-sandbox",
|
"--dangerously-bypass-approvals-and-sandbox",
|
||||||
"--output-last-message",
|
"--output-last-message",
|
||||||
file,
|
file,
|
||||||
|
|||||||
Reference in New Issue
Block a user