1 Commits

Author SHA1 Message Date
temeddix 78dcb3a2b3 Honor author replies
Check / deno (pull_request) Successful in 40s
2026-09-14 00:20:25 +09:00
3 changed files with 40 additions and 129 deletions
-6
View File
@@ -20,11 +20,6 @@ inputs:
bot-token: bot-token:
description: API key or token for the selected bot description: API key or token for the selected bot
required: false required: false
model:
description: >-
Model for the selected bot. Defaults to `claude-sonnet-5` or
`gpt-5.6-terra`, the mid tiers, which cover reviews and fixes.
required: false
runs: runs:
using: composite using: composite
@@ -45,7 +40,6 @@ runs:
ACTION_PATH: ${{ gitea.action_path }} ACTION_PATH: ${{ gitea.action_path }}
BOT_TYPE: ${{ inputs.bot-type }} BOT_TYPE: ${{ inputs.bot-type }}
BOT_TOKEN: ${{ inputs.bot-token }} BOT_TOKEN: ${{ inputs.bot-token }}
MODEL: ${{ inputs.model }}
GITEA_API_URL: ${{ gitea.api_url }} GITEA_API_URL: ${{ gitea.api_url }}
GITEA_REPOSITORY: ${{ gitea.repository }} GITEA_REPOSITORY: ${{ gitea.repository }}
GITEA_TOKEN: ${{ inputs.author-token }} GITEA_TOKEN: ${{ inputs.author-token }}
+26 -37
View File
@@ -18,45 +18,34 @@ the head of the pull request when there is one, with full history and the
author's push credentials. Read the code there, run its checks and tests when author's push credentials. Read the code there, run its checks and tests when
they bear on the task, and push from there. they bear on the task, and push from there.
For a `pull_request` event, and for a comment on a pull request that asks you to For a `pull_request` event, review the PR without changing code, using the
review it, review the PR without changing code, using the
`requesting-code-review` skill from superpowers: run its code reviewer template `requesting-code-review` skill from superpowers: run its code reviewer template
against the PR's base and head. Run the project's checks on the head and treat a against the PR's base and head, and make its complete output your final response
failure as at least Important. Check the whole repository against the code rules instead of the short comment style above. Run the project's checks on the head
at the end of this prompt, not only the diff; a violation is at least Important and treat a failure as at least Important. Check the whole repository against
even when the diff did not cause it. Write the complete review, and nothing the code rules at the end of this prompt, not only the diff; a violation is at
else, to the file `${REVIEW_PATH}`: it is posted verbatim as a pull request least Important even when the diff did not cause it. Your final response is
review from the bot account, and your final response is not posted at all. The posted verbatim as a pull request review from the bot account, so it is the
file's first line must be exactly the verdict and nothing else: `Approved` when review text and nothing else: no narration about what you did, verified, or are
the template's answer is yes, `Changes requested` otherwise. The mark in front about to post, whether you reviewed yourself or relayed a reviewer subagent. Its
of it is added when posting, so write the words alone; any other first line is first line must be exactly the template's verdict and nothing else: `Yes`, `No`,
posted as a plain comment, which wastes the run. Minor issues alone never block, or `With fixes`. `Yes` approves and the other two request changes; any other
and neither does a finding the author has answered in the comment history below first line is posted as a plain comment, which wastes the run. Minor issues
as intended or a false alarm, once the code or docs make that clear. When the alone never block, and neither does a finding the author has answered in the
verdict is `Changes requested`, the second line names what must change in one comment history below as intended or a false alarm, once the code or docs make
line, addressed to the author; the author's own agent picks the fixes up, so that clear. When the verdict is not `Yes`, the second line names what must
never ask `@bot` to make them. For UI changes, check that the result is aligned, change in one line, addressed to the author; the author's own agent picks the
clean, and pixel-perfect, and that included screenshots prove the intended fixes up, so never ask `@bot` to make them. For UI changes, check that the
result was achieved. result is aligned, clean, and pixel-perfect, and that included screenshots prove
the intended result was achieved.
Every finding that belongs to one line of the diff goes on that line instead of The review must read at a glance: everything outside `<details>` blocks totals
into the body. Write those to `${ANCHORS_PATH}` as a JSON array, each entry under 512 bytes. Only core information stays visible: the verdict, the summary
`{"path": "<path from the repository root>", "line": <number>, "side": "new" | line, and the section headings. Anything verbose goes into a `<details>` block
"old", "body": "<the finding>"}`. whose `<summary>` is a few words, such as the `file:line` and title of an issue
`side` is `new` for a line in the head file and `old` for one only in the base with the what, why, and how inside; the same for each strength, each
file; `line` is that file's own line number, and it must be a line the diff recommendation, the reasoning, and any compliance notes. Details blocks are
touches, or Gitea refuses the anchor. Write the file only when there is top-level, never inside a list item, because Gitea breaks them there.
something to anchor, and keep each body to the what, the why, and the how, with
no `file:line` prefix; the line carries that.
The review body must read at a glance: everything outside `<details>` blocks
totals under 512 bytes. Only core information stays visible: the verdict, the
summary line, and the section headings. Anything verbose goes into a `<details>`
block whose `<summary>` is a few words, such as the title of an issue with the
what, why, and how inside; the same for each strength, each recommendation, the
reasoning, and any compliance notes. A finding you anchored belongs there only
as its title, since its detail is on the line. Details blocks are top-level,
never inside a list item, because Gitea breaks them there.
For an `issue_comment` or `pull_request_review_comment` event, treat the `body` For an `issue_comment` or `pull_request_review_comment` event, treat the `body`
in the triggering comment payload below as the user's exact instruction. in the triggering comment payload below as the user's exact instruction.
+14 -86
View File
@@ -20,13 +20,6 @@ const EVENT = env("EVENT_NAME");
const AUTHOR_TOKEN = env("GITEA_TOKEN"); const AUTHOR_TOKEN = env("GITEA_TOKEN");
const REVIEWER_TOKEN = env("REVIEWER_TOKEN"); const REVIEWER_TOKEN = env("REVIEWER_TOKEN");
const RULES_PATH = "repos/commons/code-rules/raw/README.md"; const RULES_PATH = "repos/commons/code-rules/raw/README.md";
// The mid tiers: a run follows a fixed template and the project's checks.
const DEFAULT_MODELS: Record<string, string> = {
claude: "claude-sonnet-5",
codex: "gpt-5.6-terra",
};
const model = (bot: string): string =>
Deno.env.get("MODEL") || DEFAULT_MODELS[bot];
// The reviewer token is withheld so the agent cannot approve as the bot. // The reviewer token is withheld so the agent cannot approve as the bot.
const { REVIEWER_TOKEN: _, ...agentEnv } = Deno.env.toObject(); const { REVIEWER_TOKEN: _, ...agentEnv } = Deno.env.toObject();
@@ -59,84 +52,21 @@ async function postComment(body: string): Promise<void> {
}); });
} }
// A review is posted whenever the agent wrote one, whether a review request or // A pull request event is a review request, so the response becomes a review.
// a comment asked for it. It comes through a file, because a final chat message // Its first line is the verdict; anything unexpected only comments, never
// picks up narration while a file's first line is written on purpose. That line // approves.
// is the verdict, matched whole; anything unexpected only comments, never const VERDICTS: Record<string, string> = {
// approves. The mark in front is added here, so it is never part of the match. Yes: "APPROVED",
const REVIEW_DIR = await Deno.makeTempDir(); No: "REQUEST_CHANGES",
const REVIEW_PATH = `${REVIEW_DIR}/review.md`; "With fixes": "REQUEST_CHANGES",
const VERDICTS: Record<string, [event: string, mark: string]> = {
Approved: ["APPROVED", "✅"],
"Changes requested": ["REQUEST_CHANGES", "🛑"],
}; };
// A finding about one line is posted on that line of the diff rather than as
// `file:line` prose in the body. Those anchors come as JSON, so the file and
// line are structured instead of parsed back out of English; a malformed entry
// fails the run, because a silently dropped finding is worse than a red run.
const ANCHORS_PATH = `${REVIEW_DIR}/anchors.json`;
type Anchor = { path: string; line: number; side: "new" | "old"; body: string };
function parseAnchors(text: string): Anchor[] {
const entries: unknown = JSON.parse(text);
if (!Array.isArray(entries)) throw new Error(`${ANCHORS_PATH}: not an array`);
return entries.map((entry: unknown, index) => {
const at = `${ANCHORS_PATH}[${index}]`;
if (typeof entry !== "object" || entry === null) {
throw new Error(`${at}: not an object`);
}
const { path, line, side = "new", body } = entry as Record<string, unknown>;
if (typeof path !== "string" || path === "") {
throw new Error(`${at}.path: expected a repository path`);
}
if (typeof line !== "number" || !Number.isInteger(line) || line < 1) {
throw new Error(`${at}.line: expected a line number`);
}
if (side !== "new" && side !== "old") {
throw new Error(`${at}.side: expected "new" or "old"`);
}
if (typeof body !== "string" || body.trim() === "") {
throw new Error(`${at}.body: expected the finding`);
}
return { path, line, side, body };
});
}
async function readAnchors(): Promise<Anchor[]> {
const written = await Deno.readTextFile(ANCHORS_PATH).catch(() => null);
return written === null ? [] : parseAnchors(written);
}
async function postResult(body: string): Promise<void> { async function postResult(body: string): Promise<void> {
const review = await Deno.readTextFile(REVIEW_PATH).catch(() => null); if (EVENT !== "pull_request") return postComment(body);
if (review === null) { const [verdict] = body.split("\n", 1);
if (EVENT === "pull_request") { await gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, {
throw new Error(`no review was written to ${REVIEW_PATH}`); body: stripAnsi(body),
} event: VERDICTS[verdict.trim()] ?? "COMMENT",
return postComment(body);
}
const [verdict, ...rest] = review.split("\n");
const [event, mark] = VERDICTS[verdict.trim()] ?? ["COMMENT", "💬"];
const post = (anchors: Anchor[]) =>
gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, {
body: stripAnsi([`${mark} ${verdict.trim()}`, ...rest].join("\n")),
event,
comments: anchors.map(({ path, line, side, body }) => ({
path,
body: stripAnsi(body),
new_position: side === "new" ? line : 0,
old_position: side === "old" ? line : 0,
})),
});
const anchors = await readAnchors();
// Gitea rejects the whole review when an anchor names a line outside the
// diff, and a verdict that never lands blocks the pull request, so the body
// goes up alone rather than not at all.
await post(anchors).catch(async (error: Error) => {
if (anchors.length === 0) throw error;
console.error(`inline comments rejected: ${error.message}`);
await post([]);
}); });
} }
@@ -181,8 +111,6 @@ async function renderPrompt(): Promise<string> {
GITEA_API_URL: API, GITEA_API_URL: API,
GITEA_REPOSITORY: REPO, GITEA_REPOSITORY: REPO,
ISSUE_INDEX: INDEX, ISSUE_INDEX: INDEX,
REVIEW_PATH,
ANCHORS_PATH,
}; };
const template = await Deno.readTextFile( const template = await Deno.readTextFile(
new URL("prompt.md", import.meta.url), new URL("prompt.md", import.meta.url),
@@ -206,7 +134,7 @@ async function runClaude(prompt: string): Promise<string> {
"--print", "--print",
"--dangerously-skip-permissions", "--dangerously-skip-permissions",
"--model", "--model",
model("claude"), "claude-fable-5",
"--output-format", "--output-format",
"stream-json", "stream-json",
"--verbose", "--verbose",
@@ -271,7 +199,7 @@ async function runCodex(prompt: string): Promise<string> {
args: [ args: [
"exec", "exec",
"--model", "--model",
model("codex"), "gpt-5.5",
"--dangerously-bypass-approvals-and-sandbox", "--dangerously-bypass-approvals-and-sandbox",
"--output-last-message", "--output-last-message",
file, file,