Review file

prompt.md

@@ -18,8 +18,7 @@ the head of the pull request when there is one, with full history and the
 author's push credentials. Read the code there, run its checks and tests when
 they bear on the task, and push from there.
 
-For a `pull_request` event, and for a comment on a pull request that asks you to
+For a `pull_request` event, review the PR without changing code, using the
-review it, review the PR without changing code, using the
 `requesting-code-review` skill from superpowers: run its code reviewer template
 against the PR's base and head. Run the project's checks on the head and treat a
 failure as at least Important. Check the whole repository against the code rules
@@ -27,17 +26,16 @@ at the end of this prompt, not only the diff; a violation is at least Important
 even when the diff did not cause it. Write the complete review, and nothing
 else, to the file `${REVIEW_PATH}`: it is posted verbatim as a pull request
 review from the bot account, and your final response is not posted at all. The
-file's first line must be exactly the verdict and nothing else: `Approved` when
+file's first line must be exactly the template's verdict and nothing else:
-the template's answer is yes, `Changes requested` otherwise. The mark in front
+`Yes`, `No`, or `With fixes`. `Yes` approves and the other two request changes;
-of it is added when posting, so write the words alone; any other first line is
+any other first line is posted as a plain comment, which wastes the run. Minor
-posted as a plain comment, which wastes the run. Minor issues alone never block,
+issues alone never block, and neither does a finding the author has answered in
-and neither does a finding the author has answered in the comment history below
+the comment history below as intended or a false alarm, once the code or docs
-as intended or a false alarm, once the code or docs make that clear. When the
+make that clear. When the verdict is not `Yes`, the second line names what must
-verdict is `Changes requested`, the second line names what must change in one
+change in one line, addressed to the author; the author's own agent picks the
-line, addressed to the author; the author's own agent picks the fixes up, so
+fixes up, so never ask `@bot` to make them. For UI changes, check that the
-never ask `@bot` to make them. For UI changes, check that the result is aligned,
+result is aligned, clean, and pixel-perfect, and that included screenshots prove
-clean, and pixel-perfect, and that included screenshots prove the intended
+the intended result was achieved.
-result was achieved.
 
 The review must read at a glance: everything outside `<details>` blocks totals
 under 512 bytes. Only core information stays visible: the verdict, the summary

run.ts

@@ -59,30 +59,26 @@ async function postComment(body: string): Promise<void> {
   });
 }
 
-// A review is posted whenever the agent wrote one, whether a review request or
+// A pull request event is a review request, so the review is posted instead
-// a comment asked for it. It comes through a file, because a final chat message
+// of the response. It comes through a file, because a final chat message picks
-// picks up narration while a file's first line is written on purpose. That line
+// up narration while a file's first line is written on purpose. That line is
-// is the verdict, matched whole; anything unexpected only comments, never
+// the verdict; anything unexpected only comments, never approves.
-// approves. The mark in front is added here, so it is never part of the match.
 const REVIEW_PATH = `${await Deno.makeTempDir()}/review.md`;
-const VERDICTS: Record<string, [event: string, mark: string]> = {
+const VERDICTS: Record<string, string> = {
-  Approved: ["APPROVED", "✅"],
+  Yes: "APPROVED",
-  "Changes requested": ["REQUEST_CHANGES", "🛑"],
+  No: "REQUEST_CHANGES",
+  "With fixes": "REQUEST_CHANGES",
 };
 
 async function postResult(body: string): Promise<void> {
-  const review = await Deno.readTextFile(REVIEW_PATH).catch(() => null);
+  if (EVENT !== "pull_request") return postComment(body);
-  if (review === null) {
+  const review = await Deno.readTextFile(REVIEW_PATH).catch(() => {
-    if (EVENT === "pull_request") {
     throw new Error(`no review was written to ${REVIEW_PATH}`);
-    }
+  });
-    return postComment(body);
+  const [verdict] = review.split("\n", 1);
-  }
-  const [verdict, ...rest] = review.split("\n");
-  const [event, mark] = VERDICTS[verdict.trim()] ?? ["COMMENT", "💬"];
   await gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, {
-    body: stripAnsi([`${mark} ${verdict.trim()}`, ...rest].join("\n")),
+    body: stripAnsi(review),
-    event,
+    event: VERDICTS[verdict.trim()] ?? "COMMENT",
   });
 }