1 Commits

Author SHA1 Message Date
temeddix 78dcb3a2b3 Honor author replies
Check / deno (pull_request) Successful in 40s
2026-09-14 00:20:25 +09:00
3 changed files with 30 additions and 49 deletions
-6
View File
@@ -20,11 +20,6 @@ inputs:
bot-token: bot-token:
description: API key or token for the selected bot description: API key or token for the selected bot
required: false required: false
model:
description: >-
Model for the selected bot. Defaults to `claude-sonnet-5` or
`gpt-5.6-terra`, the mid tiers, which cover reviews and fixes.
required: false
runs: runs:
using: composite using: composite
@@ -45,7 +40,6 @@ runs:
ACTION_PATH: ${{ gitea.action_path }} ACTION_PATH: ${{ gitea.action_path }}
BOT_TYPE: ${{ inputs.bot-type }} BOT_TYPE: ${{ inputs.bot-type }}
BOT_TOKEN: ${{ inputs.bot-token }} BOT_TOKEN: ${{ inputs.bot-token }}
MODEL: ${{ inputs.model }}
GITEA_API_URL: ${{ gitea.api_url }} GITEA_API_URL: ${{ gitea.api_url }}
GITEA_REPOSITORY: ${{ gitea.repository }} GITEA_REPOSITORY: ${{ gitea.repository }}
GITEA_TOKEN: ${{ inputs.author-token }} GITEA_TOKEN: ${{ inputs.author-token }}
+18 -17
View File
@@ -20,23 +20,24 @@ they bear on the task, and push from there.
For a `pull_request` event, review the PR without changing code, using the For a `pull_request` event, review the PR without changing code, using the
`requesting-code-review` skill from superpowers: run its code reviewer template `requesting-code-review` skill from superpowers: run its code reviewer template
against the PR's base and head. Run the project's checks on the head and treat a against the PR's base and head, and make its complete output your final response
failure as at least Important. Check the whole repository against the code rules instead of the short comment style above. Run the project's checks on the head
at the end of this prompt, not only the diff; a violation is at least Important and treat a failure as at least Important. Check the whole repository against
even when the diff did not cause it. Write the complete review, and nothing the code rules at the end of this prompt, not only the diff; a violation is at
else, to the file `${REVIEW_PATH}`: it is posted verbatim as a pull request least Important even when the diff did not cause it. Your final response is
review from the bot account, and your final response is not posted at all. The posted verbatim as a pull request review from the bot account, so it is the
file's first line must be exactly the verdict and nothing else: `Approved` when review text and nothing else: no narration about what you did, verified, or are
the template's answer is yes, `Changes requested` otherwise. The mark in front about to post, whether you reviewed yourself or relayed a reviewer subagent. Its
of it is added when posting, so write the words alone; any other first line is first line must be exactly the template's verdict and nothing else: `Yes`, `No`,
posted as a plain comment, which wastes the run. Minor issues alone never block, or `With fixes`. `Yes` approves and the other two request changes; any other
and neither does a finding the author has answered in the comment history below first line is posted as a plain comment, which wastes the run. Minor issues
as intended or a false alarm, once the code or docs make that clear. When the alone never block, and neither does a finding the author has answered in the
verdict is `Changes requested`, the second line names what must change in one comment history below as intended or a false alarm, once the code or docs make
line, addressed to the author; the author's own agent picks the fixes up, so that clear. When the verdict is not `Yes`, the second line names what must
never ask `@bot` to make them. For UI changes, check that the result is aligned, change in one line, addressed to the author; the author's own agent picks the
clean, and pixel-perfect, and that included screenshots prove the intended fixes up, so never ask `@bot` to make them. For UI changes, check that the
result was achieved. result is aligned, clean, and pixel-perfect, and that included screenshots prove
the intended result was achieved.
The review must read at a glance: everything outside `<details>` blocks totals The review must read at a glance: everything outside `<details>` blocks totals
under 512 bytes. Only core information stays visible: the verdict, the summary under 512 bytes. Only core information stays visible: the verdict, the summary
+12 -26
View File
@@ -20,13 +20,6 @@ const EVENT = env("EVENT_NAME");
const AUTHOR_TOKEN = env("GITEA_TOKEN"); const AUTHOR_TOKEN = env("GITEA_TOKEN");
const REVIEWER_TOKEN = env("REVIEWER_TOKEN"); const REVIEWER_TOKEN = env("REVIEWER_TOKEN");
const RULES_PATH = "repos/commons/code-rules/raw/README.md"; const RULES_PATH = "repos/commons/code-rules/raw/README.md";
// The mid tiers: a run follows a fixed template and the project's checks.
const DEFAULT_MODELS: Record<string, string> = {
claude: "claude-sonnet-5",
codex: "gpt-5.6-terra",
};
const model = (bot: string): string =>
Deno.env.get("MODEL") || DEFAULT_MODELS[bot];
// The reviewer token is withheld so the agent cannot approve as the bot. // The reviewer token is withheld so the agent cannot approve as the bot.
const { REVIEWER_TOKEN: _, ...agentEnv } = Deno.env.toObject(); const { REVIEWER_TOKEN: _, ...agentEnv } = Deno.env.toObject();
@@ -59,27 +52,21 @@ async function postComment(body: string): Promise<void> {
}); });
} }
// A pull request event is a review request, so the review is posted instead // A pull request event is a review request, so the response becomes a review.
// of the response. It comes through a file, because a final chat message picks // Its first line is the verdict; anything unexpected only comments, never
// up narration while a file's first line is written on purpose. That line is // approves.
// the verdict, matched whole; anything unexpected only comments, never const VERDICTS: Record<string, string> = {
// approves. The mark in front is added here, so it is never part of the match. Yes: "APPROVED",
const REVIEW_PATH = `${await Deno.makeTempDir()}/review.md`; No: "REQUEST_CHANGES",
const VERDICTS: Record<string, [event: string, mark: string]> = { "With fixes": "REQUEST_CHANGES",
Approved: ["APPROVED", "✅"],
"Changes requested": ["REQUEST_CHANGES", "🛑"],
}; };
async function postResult(body: string): Promise<void> { async function postResult(body: string): Promise<void> {
if (EVENT !== "pull_request") return postComment(body); if (EVENT !== "pull_request") return postComment(body);
const review = await Deno.readTextFile(REVIEW_PATH).catch(() => { const [verdict] = body.split("\n", 1);
throw new Error(`no review was written to ${REVIEW_PATH}`);
});
const [verdict, ...rest] = review.split("\n");
const [event, mark] = VERDICTS[verdict.trim()] ?? ["COMMENT", "💬"];
await gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, { await gitea(REVIEWER_TOKEN, `repos/${REPO}/pulls/${INDEX}/reviews`, {
body: stripAnsi([`${mark} ${verdict.trim()}`, ...rest].join("\n")), body: stripAnsi(body),
event, event: VERDICTS[verdict.trim()] ?? "COMMENT",
}); });
} }
@@ -124,7 +111,6 @@ async function renderPrompt(): Promise<string> {
GITEA_API_URL: API, GITEA_API_URL: API,
GITEA_REPOSITORY: REPO, GITEA_REPOSITORY: REPO,
ISSUE_INDEX: INDEX, ISSUE_INDEX: INDEX,
REVIEW_PATH,
}; };
const template = await Deno.readTextFile( const template = await Deno.readTextFile(
new URL("prompt.md", import.meta.url), new URL("prompt.md", import.meta.url),
@@ -148,7 +134,7 @@ async function runClaude(prompt: string): Promise<string> {
"--print", "--print",
"--dangerously-skip-permissions", "--dangerously-skip-permissions",
"--model", "--model",
model("claude"), "claude-fable-5",
"--output-format", "--output-format",
"stream-json", "stream-json",
"--verbose", "--verbose",
@@ -213,7 +199,7 @@ async function runCodex(prompt: string): Promise<string> {
args: [ args: [
"exec", "exec",
"--model", "--model",
model("codex"), "gpt-5.5",
"--dangerously-bypass-approvals-and-sandbox", "--dangerously-bypass-approvals-and-sandbox",
"--output-last-message", "--output-last-message",
file, file,