commons/bot-agents
3
0
Fork 0
Code Issues Pull Requests Actions Releases 3 Activity

Require AI-bot review on every PR #17

Merged
temeddix merged 1 commits from require-bot-review into main 2026-09-23 20:43:03 +00:00
Conversation 7 Commits 1 Files Changed 1
+15
temeddix commented 2026-09-23 20:30:21 +00:00
Owner
Copy Link
Copy Source

Require every pull request to request an AI-bot review immediately after creation and wait for same-head approval plus green CI before merge.

Require every pull request to request an AI-bot review immediately after creation and wait for same-head approval plus green CI before merge.
temeddix commented 2026-09-23 20:30:22 +00:00
Author
Owner
Copy Link
Copy Source

@bot please review the current head for approval.

@bot please review the current head for approval.
bot requested changes 2026-09-23 20:33:29 +00:00
Dismissed
bot left a comment
Owner
Copy Link
Copy Source

🛑 Changes requested
Please replace the action's Node/npm dependency with Deno-compliant tooling.

Important

Node runtime violates repository policy

action.yml explicitly assumes node:24-bookworm and installs tools with npm, which violates the repository rule requiring Deno instead of Node for TypeScript projects. Migrate this action setup to Deno-compatible tooling.

Checks

Passed
  • Required Check / deno (pull_request) CI: successful.
  • deno fmt --check .
  • deno lint .
  • deno check src/prepare.ts src/run.ts src/post.ts
  • deno test --allow-all — 38 passed.
🛑 Changes requested Please replace the action's Node/npm dependency with Deno-compliant tooling. ## Important <details> <summary>Node runtime violates repository policy</summary> `action.yml` explicitly assumes `node:24-bookworm` and installs tools with `npm`, which violates the repository rule requiring Deno instead of Node for TypeScript projects. Migrate this action setup to Deno-compatible tooling. </details> ## Checks <details> <summary>Passed</summary> - Required `Check / deno (pull_request)` CI: successful. - `deno fmt --check .` - `deno lint .` - `deno check src/prepare.ts src/run.ts src/post.ts` - `deno test --allow-all` — 38 passed. </details>
temeddix force-pushed require-bot-review from 6f7296e5f8 to f968386d9f 2026-09-23 20:34:39 +00:00 Compare
temeddix commented 2026-09-23 20:34:46 +00:00
Author
Owner
Copy Link
Copy Source

The previous finding conflated repository TypeScript with vendor CLI distribution. All source and checks use Deno; npm only installs the externally distributed Claude Code and Codex executables. AGENTS.md now makes that boundary explicit.

The previous finding conflated repository TypeScript with vendor CLI distribution. All source and checks use Deno; npm only installs the externally distributed Claude Code and Codex executables. AGENTS.md now makes that boundary explicit.
temeddix commented 2026-09-23 20:34:46 +00:00
Author
Owner
Copy Link
Copy Source

@bot please review the updated head for approval.

@bot please review the updated head for approval.
bot requested changes 2026-09-23 20:37:38 +00:00
Dismissed
bot left a comment
Owner
Copy Link
Copy Source

🛑 Changes requested
Make damem recall available to every bot session or remove/guard the mandatory command.

Important

  • Required context command unavailable

Checks

  • Deno format, lint, type checks, and tests: 38 passed
Strength
  • The Deno/vendor-CLI boundary is explicit and matches the workflow.
Declined
  • Vendor npm installation: documented external CLI distribution, not repository runtime code.
🛑 Changes requested Make `damem recall` available to every bot session or remove/guard the mandatory command. ### Important - Required context command unavailable ### Checks - Deno format, lint, type checks, and tests: 38 passed <details> <summary>Strength</summary> - The Deno/vendor-CLI boundary is explicit and matches the workflow. </details> <details> <summary>Declined</summary> - Vendor npm installation: documented external CLI distribution, not repository runtime code. </details>
AGENTS.md Outdated
@@ -0,0 +1,13 @@
At the start of every new session, run `damem recall` and treat its output as
bot commented 2026-09-23 20:37:38 +00:00
Owner
Copy Link
Copy Source

The runner does not provide damem (damem: command not found), so this mandatory first step fails and no repository context can be loaded. Install it before the agent runs, or make context retrieval available through a bundled command.

The runner does not provide `damem` (`damem: command not found`), so this mandatory first step fails and no repository context can be loaded. Install it before the agent runs, or make context retrieval available through a bundled command.
temeddix added 1 commit 2026-09-23 20:38:48 +00:00
Require AI-bot review on every PR
Check / deno (pull_request) Successful in 55s
Details
fcac94783e
temeddix force-pushed require-bot-review from f968386d9f to fcac94783e 2026-09-23 20:38:48 +00:00 Compare
temeddix commented 2026-09-23 20:38:59 +00:00
Author
Owner
Copy Link
Copy Source

The required damem startup now includes an explicit installation fallback for fresh containers. @bot please review the updated head for approval.

The required damem startup now includes an explicit installation fallback for fresh containers. @bot please review the updated head for approval.
bot approved these changes 2026-09-23 20:42:00 +00:00
bot left a comment
Owner
Copy Link
Copy Source

✅ Approved
Summary: Required PR-review policy and the fresh-container damem fallback are present.

Strengths

Validated change
  • Requires damem recall at session start and directs unavailable installations to the upstream installation instructions before reasoning or responding.
  • Requests @bot review immediately and requires green CI plus same-head approval before merge.

Issues

  • None.

Recommendations

  • None.

Assessment

Ready to merge: Yes.

Verification
  • deno fmt --check . && deno lint . && deno check src/prepare.ts src/run.ts src/post.ts && deno test --allow-all — 38 passed.
  • Required Check / deno (pull_request) status — successful.
  • Declined to judge: none.
✅ Approved Summary: Required PR-review policy and the fresh-container `damem` fallback are present. ## Strengths <details> <summary>Validated change</summary> - Requires `damem recall` at session start and directs unavailable installations to the upstream installation instructions before reasoning or responding. - Requests `@bot` review immediately and requires green CI plus same-head approval before merge. </details> ## Issues - None. ## Recommendations - None. ## Assessment Ready to merge: Yes. <details> <summary>Verification</summary> - `deno fmt --check . && deno lint . && deno check src/prepare.ts src/run.ts src/post.ts && deno test --allow-all` — 38 passed. - Required `Check / deno (pull_request)` status — successful. - Declined to judge: none. </details>
temeddix merged commit 4ecdf5adc0 into main 2026-09-23 20:43:03 +00:00
temeddix deleted branch require-bot-review 2026-09-23 20:43:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bot
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
bot RaymondCho temeddix
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: commons/bot-agents#17
Delete Branch "require-bot-review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?