Fail-closed verdict #3

Merged

temeddix merged 3 commits from fold-review into main 2026-09-13 14:57:02 +00:00

Conversation 0 Commits 3 Files Changed 2

+42 -25

temeddix commented 2026-09-13 14:45:43 +00:00

Owner

Copy Link

Copy Source

• prompt.md: the review's first line is exactly Yes, No, or With fixes; the second line is the @bot instruction when not Yes. Everything outside <details> blocks stays under 512 bytes: only the verdict, the @bot line, and headings are visible; anything verbose folds into a top-level <details> (Gitea breaks them inside list items).
• run.ts: the review event comes from an equality lookup on that first line, Yes → APPROVED, No / With fixes → REQUEST_CHANGES, anything else → COMMENT, so an unexpected response never approves. No @bot or Bot failed: matching remains. Failures throw and one catch posts Bot failed: … as a comment.

Verified: deno fmt --check, deno lint, deno check run.ts; the lookup on Yes, With fixes, No, **Ready to merge?** Yes, Yes, ship it, and empty input.

- `prompt.md`: the review's first line is exactly `Yes`, `No`, or `With fixes`; the second line is the `@bot` instruction when not `Yes`. Everything outside `<details>` blocks stays under 512 bytes: only the verdict, the `@bot` line, and headings are visible; anything verbose folds into a top-level `<details>` (Gitea breaks them inside list items). - `run.ts`: the review event comes from an equality lookup on that first line, `Yes` → APPROVED, `No` / `With fixes` → REQUEST_CHANGES, anything else → COMMENT, so an unexpected response never approves. No `@bot` or `Bot failed:` matching remains. Failures throw and one catch posts `Bot failed: …` as a comment. Verified: `deno fmt --check`, `deno lint`, `deno check run.ts`; the lookup on `Yes`, `With fixes`, `No`, `**Ready to merge?** Yes`, `Yes, ship it`, and empty input.

temeddix added 1 commit 2026-09-13 14:45:43 +00:00

Fold review details ca6c2f1378

temeddix added 1 commit 2026-09-13 14:47:21 +00:00

Fold anything verbose 81e75297a4

temeddix added 1 commit 2026-09-13 14:56:07 +00:00

Verdict is the first line 242717a141

temeddix changed title from Fold review details to Fail-closed verdict 2026-09-13 14:56:07 +00:00

temeddix merged commit f0506adfea into main 2026-09-13 14:57:02 +00:00

temeddix deleted branch fold-review 2026-09-13 14:57:02 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Assignees

Clear assignees

bot temeddix

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: commons/bot-agents#3