Restore Superpowers reviews #12

Merged
temeddix merged 1 commits from superpowers-v0.2.0 into main 2026-09-16 04:27:22 +00:00
5 changed files with 129 additions and 20 deletions
Showing only changes of commit 5a1a5656ac - Show all commits
+5 -1
View File
@@ -14,4 +14,8 @@ jobs:
- uses: denoland/setup-deno@v2 - uses: denoland/setup-deno@v2
- run: deno fmt --check . && deno lint . && deno check run.ts - run: >-
deno fmt --check . &&
deno lint . &&
deno check run.ts &&
deno test
+25 -18
View File
@@ -19,24 +19,31 @@ author's push credentials. Read the code there, run its checks and tests when
they bear on the task, and push from there. they bear on the task, and push from there.
For a `pull_request` event, and for a comment on a pull request that asks you to For a `pull_request` event, and for a comment on a pull request that asks you to
review it, review the PR without changing code against its base and head. Run review it, invoke the installed `superpowers:requesting-code-review` skill
the project's checks on the head and treat a failure as at least Important. before inspecting the PR. You are the reviewer that has already been dispatched,
Check the whole repository against the code rules at the end of this prompt, not so run the skill's code reviewer template yourself instead of dispatching
only the diff; a violation is at least Important even when the diff did not another reviewer. Use the pull request and triggering instruction as its
cause it. Write the complete review, and nothing else, to the file description and requirements, and review the exact base and head SHAs without
`${REVIEW_PATH}`: it is posted verbatim as a pull request review from the bot changing code. Run the project's required checks on the head and treat a real
account, and your final response is not posted at all. The file's first line failure as at least Important. The bot automation workflow itself is not a
must be exactly the verdict and nothing else: `Approved` when the head is ready project check: ignore its skipped or canceled duplicate/automatic runs, and
to merge, `Changes requested` otherwise. The mark in front of it is added when never reject a PR because the current review run is unfinished. Only a failed
posting, so write the words alone; any other first line is posted as a plain required check for the reviewed head blocks approval. Check the whole repository
comment, which wastes the run. Minor issues alone never block, and neither does against the code rules at the end of this prompt, not only the diff; a violation
a finding the author has answered in the comment history below as intended or a is at least Important even when the diff did not cause it. Write the complete
false alarm, once the code or docs make that clear. When the verdict is review, and nothing else, to the file `${REVIEW_PATH}`: it is posted verbatim as
`Changes requested`, the second line names what must change in one line, a pull request review from the bot account, and your final response is not
addressed to the author; the author's own agent picks the fixes up, so never ask posted at all. The file's first line must be exactly the verdict and nothing
`@bot` to make them. For UI changes, check that the result is aligned, clean, else: `Approved` when the head is ready to merge, `Changes requested` otherwise.
and pixel-perfect, and that included screenshots prove the intended result was The mark in front of it is added when posting, so write the words alone; any
achieved. other first line is posted as a plain comment, which wastes the run. Minor
issues alone never block, and neither does a finding the author has answered in
the comment history below as intended or a false alarm, once the code or docs
make that clear. When the verdict is `Changes requested`, the second line names
what must change in one line, addressed to the author; the author's own agent
picks the fixes up, so never ask `@bot` to make them. For UI changes, check that
the result is aligned, clean, and pixel-perfect, and that included screenshots
prove the intended result was achieved.
Every finding that belongs to one line of the diff goes on that line instead of Every finding that belongs to one line of the diff goes on that line instead of
into the body. Write those to `${ANCHORS_PATH}` as a JSON array, each entry into the body. Write those to `${ANCHORS_PATH}` as a JSON array, each entry
+17 -1
View File
@@ -4,6 +4,11 @@
// so it appears as the bot account. // so it appears as the bot account.
import { TextLineStream } from "jsr:@std/streams@1/text-line-stream"; import { TextLineStream } from "jsr:@std/streams@1/text-line-stream";
import { retryInvalidToken } from "./auth.ts"; import { retryInvalidToken } from "./auth.ts";
import {
type BotType,
parseBotType,
superpowersInstallCommands,
} from "./superpowers.ts";
type GiteaUser = { login: string; email: string }; type GiteaUser = { login: string; email: string };
type GiteaComment = { user: GiteaUser; created_at: string; body: string }; type GiteaComment = { user: GiteaUser; created_at: string; body: string };
@@ -18,6 +23,7 @@ const API = env("GITEA_API_URL");
const REPO = env("GITEA_REPOSITORY"); const REPO = env("GITEA_REPOSITORY");
const INDEX = env("ISSUE_INDEX"); const INDEX = env("ISSUE_INDEX");
const EVENT = env("EVENT_NAME"); const EVENT = env("EVENT_NAME");
const BOT = parseBotType(env("BOT_TYPE"));
const AUTHOR_TOKEN = env("GITEA_TOKEN"); const AUTHOR_TOKEN = env("GITEA_TOKEN");
const REVIEWER_TOKEN = env("REVIEWER_TOKEN"); const REVIEWER_TOKEN = env("REVIEWER_TOKEN");
const RULES_PATH = "repos/commons/code-rules/raw/README.md"; const RULES_PATH = "repos/commons/code-rules/raw/README.md";
@@ -146,6 +152,14 @@ async function run(command: string, args: string[]): Promise<void> {
if (!success) throw new Error(`${command} ${args[0]} exited with ${code}`); if (!success) throw new Error(`${command} ${args[0]} exited with ${code}`);
} }
// The reviewer uses Superpowers' requesting-code-review template. Both plugin
// installers are idempotent on the persisted bot home.
async function installSuperpowers(bot: BotType): Promise<void> {
for (const { command, args } of superpowersInstallCommands(bot)) {
await run(command, args);
}
}
// Commits belong to the same account as the pull request they end up in. // Commits belong to the same account as the pull request they end up in.
async function configureGitAuthor(): Promise<void> { async function configureGitAuthor(): Promise<void> {
const user: GiteaUser = await (await gitea(AUTHOR_TOKEN, "user")).json(); const user: GiteaUser = await (await gitea(AUTHOR_TOKEN, "user")).json();
@@ -188,6 +202,7 @@ async function runClaude(prompt: string): Promise<string> {
"Run `claude setup-token` locally and set the `bot-token` action input.", "Run `claude setup-token` locally and set the `bot-token` action input.",
); );
} }
await installSuperpowers("claude");
const claude = new Deno.Command("claude", { const claude = new Deno.Command("claude", {
args: [ args: [
"--print", "--print",
@@ -257,6 +272,7 @@ async function runCodex(prompt: string): Promise<string> {
}) })
.output(); .output();
if (!loggedIn.success) await codexDeviceLogin(); if (!loggedIn.success) await codexDeviceLogin();
await installSuperpowers("codex");
const file = await Deno.makeTempFile(); const file = await Deno.makeTempFile();
const attempt = async () => { const attempt = async () => {
const codex = new Deno.Command("codex", { const codex = new Deno.Command("codex", {
@@ -294,7 +310,7 @@ async function runCodex(prompt: string): Promise<string> {
try { try {
await configureGitAuthor(); await configureGitAuthor();
const prompt = await renderPrompt(); const prompt = await renderPrompt();
const result = env("BOT_TYPE") === "claude" const result = BOT === "claude"
? await runClaude(prompt) ? await runClaude(prompt)
: await runCodex(prompt); : await runCodex(prompt);
await postResult(result); await postResult(result);
+42
View File
@@ -0,0 +1,42 @@
export type BotType = "claude" | "codex";
export type InstallCommand = {
command: string;
args: string[];
};
export function parseBotType(value: string): BotType {
if (value === "claude" || value === "codex") return value;
throw new Error(`unsupported bot type: ${value}`);
}
export function superpowersInstallCommands(
bot: BotType,
): InstallCommand[] {
if (bot === "claude") {
return [
{
command: "claude",
args: [
"plugin",
"marketplace",
"add",
"obra/superpowers-marketplace",
],
},
{
command: "claude",
args: [
"plugin",
"install",
"-y",
"superpowers@superpowers-marketplace",
],
},
];
}
return [{
command: "codex",
args: ["plugin", "add", "superpowers@openai-curated-remote"],
}];
}
+40
View File
@@ -0,0 +1,40 @@
import { assertEquals, assertThrows } from "jsr:@std/assert@1";
import { parseBotType, superpowersInstallCommands } from "./superpowers.ts";
Deno.test("installs Superpowers from the Codex marketplace", () => {
assertEquals(superpowersInstallCommands("codex"), [{
command: "codex",
args: ["plugin", "add", "superpowers@openai-curated-remote"],
}]);
});
Deno.test("installs Superpowers from the Claude marketplace", () => {
assertEquals(superpowersInstallCommands("claude"), [
{
command: "claude",
args: [
"plugin",
"marketplace",
"add",
"obra/superpowers-marketplace",
],
},
{
command: "claude",
args: [
"plugin",
"install",
"-y",
"superpowers@superpowers-marketplace",
],
},
]);
});
Deno.test("rejects an unsupported bot type", () => {
assertThrows(
() => parseBotType("other"),
Error,
"unsupported bot type: other",
);
});