commons/bot-agents
3
0
Fork 0
Code Issues Pull Requests Actions Releases 3 Activity

Document that package.json aliases may target only direct subfolders of src #21

Merged
temeddix merged 27 commits from alias-targets into main 2026-10-18 14:37:50 +00:00
Conversation 30 Commits 27 Files Changed 51
+2 -2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 50df193a8c - Show all commits
AGENTS.md
+2 -2
View File
@@ -33,8 +33,8 @@ Inside an area, relative imports of siblings and subfolders are free. `../`
is banned in every file, owned or not
bot commented 2026-10-17 18:47:35 +00:00
Outdated
Review
Copy Link
Copy Source

This new rule says ../ is banned in every file, but it remains in tests/entrypoints.test.ts, tests/workflow.test.ts, and src/run.ts; the listed import rule does not check URL strings. Remove those traversals or narrow and enforce the rule to match its actual scope.

Profile: codex · gpt-5.6-terra

This new rule says `../` is banned in every file, but it remains in `tests/entrypoints.test.ts`, `tests/workflow.test.ts`, and `src/run.ts`; the listed import rule does not check URL strings. Remove those traversals or narrow and enforce the rule to match its actual scope. > Profile: `codex` · `gpt-5.6-terra`
(`import/no-relative-parent-imports`). Files no alias owns need no `index.ts`
and no alias, and import `./` siblings and subfolders freely. The one alias
is `#testing` (`./src/testing/index.ts`): every test imports it by alias, and
`tests/` reaches `src/` only through it. Local convention, stricter than the
is `#testing` (`./src/testing/index.ts`): tests that use its helpers import
bot commented 2026-10-17 18:37:48 +00:00
Outdated
Review
Copy Link
Copy Source

AGENTS.md says every test imports #testing, but src/credentials.test.ts, src/opencode.test.ts, and src/profiles.test.ts do not. Limit this to tests/ (or make the statement true) so the alias policy stays accurate.

Profile: codex · gpt-5.6-terra

`AGENTS.md` says every test imports `#testing`, but `src/credentials.test.ts`, `src/opencode.test.ts`, and `src/profiles.test.ts` do not. Limit this to `tests/` (or make the statement true) so the alias policy stays accurate. > Profile: `codex` · `gpt-5.6-terra`
it by alias, and `tests/` reaches `src/` only through it. Local convention, stricter than the
general rule above: in this repo, aliases point only at a direct subfolder of
`src/` (`"#helpers": "./src/helpers/index.ts"`), and code outside `src/` uses
`./` relative imports. `scripts/` is flat: one file per