006bbe6b0c
## Summary
Moves `commons/bot-agents` off Deno. The action's TypeScript now runs directly on the job image's Node.js (`node src/<phase>.ts`, using Node's built-in type stripping), with no build step and still no runtime dependency. Repository checks move to Vite+ (`vp check`, `vp test`).
## What changed
- **Runtime.** `action.yml` runs `prepare.ts`, `run.ts`, and `post.ts` with `node` instead of `deno run -A`. `package.json` (`"type": "module"`, `engines.node >=24.2` for `import.meta.main`) is now copied into the root-owned source copy by `scripts/protect-source.sh`.
- **Profiles.** `profiles.yml` → `profiles.json`, with the same content (encrypted values unchanged), parsed with `JSON.parse`. This drops the only runtime dependency (`@std/yaml`).
- **Deno APIs → Node.**
- `src/command.ts` wraps `child_process.spawn` with the old `Deno.Command` shapes: `output()`/`spawn()`, `clearEnv`, `uid`/`gid`, and Deno's stdio defaults (stdin inherited; stdout/stderr piped for `output()`, inherited for `spawn()`). A signal exit maps to `128 + signo`. Status settles on process exit.
- `src/errors.ts` maps `NotFound` to `ENOENT`/`ESRCH`.
- fs, path, stream, and readline calls are mapped one for one. `makeTempFile` becomes an exclusive `wx` 0600 create.
- **Size refactors.** These are needed for Oxlint's default limits. There are no behavior changes and no overrides for source files.
- `run.ts` is split into `run-context.ts`, `agents.ts`, and `agent-{claude,codex,opencode}.ts`.
- `post.ts` is split into `post.ts` and `post-artifacts.ts`.
- `parseCredentials`, `readOutcome`, and `postRuntime` are broken into helpers.
- Loops that awaited sequentially became recursion or a `reduce` chain, so they stay sequential. `/proc` status reads became `Promise.all`.
- `src/json.ts` adds type guards in place of `as` casts.
- **Tests.** The 58 `Deno.test` cases were converted to Vitest with the codemod, and its TODOs were finished by hand.
- Unit tests are `src/*.test.ts`; the repository-level workflow test is `tests/workflow.test.ts`.
- Root-only tests are now `test.skipIf(!IS_ROOT)`, so they show as skipped instead of silently passing.
- New `tests/entrypoints.test.ts` runs each phase under real Node to prove its whole import graph loads.
- **Config.** The only config files are `package.json`, `tsconfig.json`, and `vite.config.ts`, plus `package-lock.json`.
- Lint uses Oxlint correctness/suspicious/pedantic/perf at error, with default limits and type-aware checks.
- `scripts/project-lint.ts` holds the rule list. It maps Deno's `recommended` rules that fall outside those categories, adds the template's `id-match`, `no-disable-comments`, and `no-non-ts-imports`, and maps Deno's `no-window`/`no-process-global`/`no-node-globals` to `no-restricted-globals` (so `process`/`Buffer` come from `node:` imports).
- **CI.** `.gitea/workflows/check.yml` runs `node --version`, `npm ci`, `npx vp check`, and `npx vp test` in the default runner image.
- **Formatting.** Oxfmt formatting is a separate first commit, so the second commit shows only the semantic diff.
- **AGENTS.md** is updated for the new toolchain.
## Deviations / risks
- **Live `@main` switch.** Six consumer repos use `commons/bot-agents@main`, so merging switches all of them at once. Suggested before merging: tag the current `main` (e.g. `deno-final`) as a rollback target, and canary this branch from one consumer (`uses: …/commons/bot-agents@node-migration`) on a throwaway PR.
- **Node version.** `post.ts` relies on `import.meta.main`, which needs Node ≥ 24.2. DANNYEC's cached `node:24-bookworm` minor is unknown (`forcePull=false`), and the CI job now prints `node --version` to confirm it.
- **Deno stays in the global install.** `deno` remains in the action's global npm install because agents still verify Deno-based consumers (memona, memona-home). Remove it once those repos move.
- **`prefer-readonly-parameter-types` is off.** This pedantic rule is turned off, as in the explicit-types template and the app repos, because Node/web types (`Response`, `Stats`, `RequestInit`) can never satisfy it. `scripts/**` has one narrow override (`no-unsafe-enum-comparison`) for AST node `type` comparisons.
- **Stricter validation of malformed input.** For valid input, behavior is unchanged. A few validations are stricter where the old code would have used a malformed value:
- Gitea `/user` and comment responses are checked.
- The runtime manifest and the outcome's profile type are checked against known values.
- Some type-check errors are now `TypeError` (same messages).
- **@cunarist lint plugins.** "CI fails until @cunarist/eslint-plugin-* are published" does **not** apply here. This repo's Deno setup enabled no plugin, so it depends on none of `@cunarist/eslint-plugin-*`, and CI can pass as is.
## Verification
- `vp check`: formatting, lint (0 warnings), and type check all pass.
- `vp test` as a normal user: 56 passed, 5 root-only skipped.
- `vp test` as root in `node:24-bookworm` (Node v24.22.0, the CI image): all 61 passed, including the UID isolation, process cleanup, and `prepare.ts` cleanup tests.
- End-to-end smoke as root in `node:24-bookworm`, with fake `codex`/`claude`/`npx` binaries and a fake Gitea, through `protect-source.sh` → `prepare.ts` → `run.ts` → `post.ts`:
- Codex hit "usage limit" and fell through to Claude.
- Agents ran as UIDs 20000/20001 without the master key.
- The Codex login was persisted to `/root/.codex/auth.json` (0600).
- The PR review with an inline comment was posted with the reviewer token.
- Runtime credentials were removed and the git author was configured.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Reviewed-on: #20
Reviewed-by: bot <noreply@capsulizers.com>
Co-authored-by: Danny Kim <temeddix@gmail.com>
Co-committed-by: Danny Kim <temeddix@gmail.com>
106 lines
3.6 KiB
TypeScript
106 lines
3.6 KiB
TypeScript
import { chmod, readdir, readFile, rm, stat, writeFile } from "node:fs/promises";
|
|
import process from "node:process";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
import { assert, expect, test } from "vite-plus/test";
|
|
|
|
import { output } from "./command.ts";
|
|
import { prepareRuntime } from "./runtime.ts";
|
|
import type { RuntimeProfile } from "./runtime.ts";
|
|
import { IS_ROOT, makeTempDir } from "./testing.ts";
|
|
|
|
const MASTER_KEY = "AAECAwQFBgcICQoLDA0ODxAREhMUFRYXGBkaGxwdHh8";
|
|
const ENCRYPTED = "v1:ICEiIyQlJicoKSor:oV_FAgnsN3p1FyegJxwGVdyjfyPio6qDeSUwbA";
|
|
|
|
// Runs `command` as the profile's user, from the root directory.
|
|
async function runAs(profile: RuntimeProfile, command: string, path: string): Promise<boolean> {
|
|
const result = await output(command, {
|
|
args: [path],
|
|
cwd: "/",
|
|
uid: profile.uid,
|
|
gid: profile.gid,
|
|
});
|
|
return result.success;
|
|
}
|
|
|
|
async function expectPrivate(path: string, uid: number, mode: number): Promise<void> {
|
|
const info = await stat(path);
|
|
expect(info.uid).toStrictEqual(uid);
|
|
expect(info.mode & 0o777).toBe(mode);
|
|
}
|
|
|
|
test.skipIf(!IS_ROOT)("prepares root-only reviewer and isolated profile credentials", async () => {
|
|
const root = await makeTempDir();
|
|
await chmod(root, 0o711);
|
|
const action = await makeTempDir();
|
|
try {
|
|
await writeFile(
|
|
`${action}/profiles.json`,
|
|
JSON.stringify({
|
|
"reviewer-token": ENCRYPTED,
|
|
profiles: [{ type: "claude", token: ENCRYPTED }, { type: "codex" }],
|
|
}),
|
|
);
|
|
|
|
const manifest = await prepareRuntime(action, root, MASTER_KEY);
|
|
const serialized = await readFile(manifest.manifestPath, "utf8");
|
|
assert(!serialized.includes("secret-token"));
|
|
expect(await readFile(manifest.reviewerFile, "utf8")).toBe("secret-token");
|
|
await expectPrivate(manifest.reviewerFile, 0, 0o600);
|
|
|
|
const [claude, codex] = manifest.profiles;
|
|
assert(claude !== undefined && codex !== undefined);
|
|
expect(claude.uid).not.toStrictEqual(codex.uid);
|
|
await expectPrivate(claude.home, claude.uid, 0o700);
|
|
assert(claude.tokenFile !== null);
|
|
expect(await readFile(claude.tokenFile, "utf8")).toBe("secret-token");
|
|
await expectPrivate(claude.tokenFile, claude.uid, 0o600);
|
|
expect((await stat(codex.home)).uid).toStrictEqual(codex.uid);
|
|
expect(codex.tokenFile).toBe(null);
|
|
|
|
const ownToken = await output("/bin/cat", {
|
|
args: [claude.tokenFile],
|
|
cwd: "/",
|
|
uid: claude.uid,
|
|
gid: claude.gid,
|
|
});
|
|
expect(ownToken.success).toBe(true);
|
|
expect(new TextDecoder().decode(ownToken.stdout)).toBe("secret-token");
|
|
expect(await runAs(claude, "/bin/cat", manifest.reviewerFile)).toBe(false);
|
|
expect(await runAs(claude, "/bin/ls", codex.home)).toBe(false);
|
|
} finally {
|
|
await rm(root, { recursive: true });
|
|
await rm(action, { recursive: true });
|
|
}
|
|
});
|
|
|
|
test.skipIf(!IS_ROOT)("removes prepared credentials when output publication fails", async () => {
|
|
const root = await makeTempDir();
|
|
const action = await makeTempDir();
|
|
try {
|
|
await writeFile(
|
|
`${action}/profiles.json`,
|
|
JSON.stringify({
|
|
"reviewer-token": ENCRYPTED,
|
|
profiles: [{ type: "claude", token: ENCRYPTED }],
|
|
}),
|
|
);
|
|
const result = await output(process.execPath, {
|
|
args: [fileURLToPath(new URL("prepare.ts", import.meta.url))],
|
|
env: {
|
|
ACTION_PATH: action,
|
|
RUNNER_TEMP: root,
|
|
BOT_AGENTS_MASTER_KEY: MASTER_KEY,
|
|
GITHUB_OUTPUT: action,
|
|
},
|
|
clearEnv: true,
|
|
});
|
|
|
|
expect(result.success).toBe(false);
|
|
expect(await readdir(root)).toStrictEqual([]);
|
|
} finally {
|
|
await rm(root, { recursive: true });
|
|
await rm(action, { recursive: true });
|
|
}
|
|
});
|