006bbe6b0c
## Summary
Moves `commons/bot-agents` off Deno. The action's TypeScript now runs directly on the job image's Node.js (`node src/<phase>.ts`, using Node's built-in type stripping), with no build step and still no runtime dependency. Repository checks move to Vite+ (`vp check`, `vp test`).
## What changed
- **Runtime.** `action.yml` runs `prepare.ts`, `run.ts`, and `post.ts` with `node` instead of `deno run -A`. `package.json` (`"type": "module"`, `engines.node >=24.2` for `import.meta.main`) is now copied into the root-owned source copy by `scripts/protect-source.sh`.
- **Profiles.** `profiles.yml` → `profiles.json`, with the same content (encrypted values unchanged), parsed with `JSON.parse`. This drops the only runtime dependency (`@std/yaml`).
- **Deno APIs → Node.**
- `src/command.ts` wraps `child_process.spawn` with the old `Deno.Command` shapes: `output()`/`spawn()`, `clearEnv`, `uid`/`gid`, and Deno's stdio defaults (stdin inherited; stdout/stderr piped for `output()`, inherited for `spawn()`). A signal exit maps to `128 + signo`. Status settles on process exit.
- `src/errors.ts` maps `NotFound` to `ENOENT`/`ESRCH`.
- fs, path, stream, and readline calls are mapped one for one. `makeTempFile` becomes an exclusive `wx` 0600 create.
- **Size refactors.** These are needed for Oxlint's default limits. There are no behavior changes and no overrides for source files.
- `run.ts` is split into `run-context.ts`, `agents.ts`, and `agent-{claude,codex,opencode}.ts`.
- `post.ts` is split into `post.ts` and `post-artifacts.ts`.
- `parseCredentials`, `readOutcome`, and `postRuntime` are broken into helpers.
- Loops that awaited sequentially became recursion or a `reduce` chain, so they stay sequential. `/proc` status reads became `Promise.all`.
- `src/json.ts` adds type guards in place of `as` casts.
- **Tests.** The 58 `Deno.test` cases were converted to Vitest with the codemod, and its TODOs were finished by hand.
- Unit tests are `src/*.test.ts`; the repository-level workflow test is `tests/workflow.test.ts`.
- Root-only tests are now `test.skipIf(!IS_ROOT)`, so they show as skipped instead of silently passing.
- New `tests/entrypoints.test.ts` runs each phase under real Node to prove its whole import graph loads.
- **Config.** The only config files are `package.json`, `tsconfig.json`, and `vite.config.ts`, plus `package-lock.json`.
- Lint uses Oxlint correctness/suspicious/pedantic/perf at error, with default limits and type-aware checks.
- `scripts/project-lint.ts` holds the rule list. It maps Deno's `recommended` rules that fall outside those categories, adds the template's `id-match`, `no-disable-comments`, and `no-non-ts-imports`, and maps Deno's `no-window`/`no-process-global`/`no-node-globals` to `no-restricted-globals` (so `process`/`Buffer` come from `node:` imports).
- **CI.** `.gitea/workflows/check.yml` runs `node --version`, `npm ci`, `npx vp check`, and `npx vp test` in the default runner image.
- **Formatting.** Oxfmt formatting is a separate first commit, so the second commit shows only the semantic diff.
- **AGENTS.md** is updated for the new toolchain.
## Deviations / risks
- **Live `@main` switch.** Six consumer repos use `commons/bot-agents@main`, so merging switches all of them at once. Suggested before merging: tag the current `main` (e.g. `deno-final`) as a rollback target, and canary this branch from one consumer (`uses: …/commons/bot-agents@node-migration`) on a throwaway PR.
- **Node version.** `post.ts` relies on `import.meta.main`, which needs Node ≥ 24.2. DANNYEC's cached `node:24-bookworm` minor is unknown (`forcePull=false`), and the CI job now prints `node --version` to confirm it.
- **Deno stays in the global install.** `deno` remains in the action's global npm install because agents still verify Deno-based consumers (memona, memona-home). Remove it once those repos move.
- **`prefer-readonly-parameter-types` is off.** This pedantic rule is turned off, as in the explicit-types template and the app repos, because Node/web types (`Response`, `Stats`, `RequestInit`) can never satisfy it. `scripts/**` has one narrow override (`no-unsafe-enum-comparison`) for AST node `type` comparisons.
- **Stricter validation of malformed input.** For valid input, behavior is unchanged. A few validations are stricter where the old code would have used a malformed value:
- Gitea `/user` and comment responses are checked.
- The runtime manifest and the outcome's profile type are checked against known values.
- Some type-check errors are now `TypeError` (same messages).
- **@cunarist lint plugins.** "CI fails until @cunarist/eslint-plugin-* are published" does **not** apply here. This repo's Deno setup enabled no plugin, so it depends on none of `@cunarist/eslint-plugin-*`, and CI can pass as is.
## Verification
- `vp check`: formatting, lint (0 warnings), and type check all pass.
- `vp test` as a normal user: 56 passed, 5 root-only skipped.
- `vp test` as root in `node:24-bookworm` (Node v24.22.0, the CI image): all 61 passed, including the UID isolation, process cleanup, and `prepare.ts` cleanup tests.
- End-to-end smoke as root in `node:24-bookworm`, with fake `codex`/`claude`/`npx` binaries and a fake Gitea, through `protect-source.sh` → `prepare.ts` → `run.ts` → `post.ts`:
- Codex hit "usage limit" and fell through to Claude.
- Agents ran as UIDs 20000/20001 without the master key.
- The Codex login was persisted to `/root/.codex/auth.json` (0600).
- The PR review with an inline comment was posted with the reviewer token.
- Runtime credentials were removed and the git author was configured.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Reviewed-on: #20
Reviewed-by: bot <noreply@capsulizers.com>
Co-authored-by: Danny Kim <temeddix@gmail.com>
Co-committed-by: Danny Kim <temeddix@gmail.com>
173 lines
5.6 KiB
TypeScript
173 lines
5.6 KiB
TypeScript
// Runs one ordered agent profile. Credential decryption and reviewer posting
|
|
// live in separate processes so neither privileged secret reaches this runner.
|
|
import { chmod, readFile, writeFile } from "node:fs/promises";
|
|
|
|
import { codexAuthentication, persistCodexAuth, stageCodexAuth } from "./auth.ts";
|
|
import { runAgent } from "./agents.ts";
|
|
import type { AgentAnswer } from "./agents.ts";
|
|
import { output } from "./command.ts";
|
|
import { killProfileProcesses, readProfileFile } from "./isolation.ts";
|
|
import { isObject } from "./json.ts";
|
|
import { runProfiles } from "./profiles.ts";
|
|
import type { ProfileFailure } from "./profiles.ts";
|
|
import {
|
|
API,
|
|
env,
|
|
EVENT,
|
|
gitea,
|
|
INDEX,
|
|
makeProfileFile,
|
|
MANIFEST,
|
|
PROCESS_ENV,
|
|
REPO,
|
|
runAgentCommand,
|
|
WORKSPACE,
|
|
} from "./run-context.ts";
|
|
import type { RuntimeOutcome, RuntimeProfile } from "./runtime.ts";
|
|
|
|
interface AttemptResult {
|
|
body: string;
|
|
reviewPath: string;
|
|
anchorsPath: string;
|
|
profile: Pick<RuntimeProfile, "type" | "model">;
|
|
}
|
|
|
|
interface RenderedPrompt {
|
|
prompt: string;
|
|
reviewPath: string;
|
|
anchorsPath: string;
|
|
}
|
|
|
|
const RULES_PATH = "repos/commons/code-rules/raw/README.md";
|
|
const CODEX_AUTH = "/root/.codex/auth.json";
|
|
const SKILLS_INSTALL = "skills add obra/superpowers";
|
|
|
|
async function runRoot(command: string, args: string[]): Promise<void> {
|
|
const { success, code } = await output(command, { args, env: PROCESS_ENV, clearEnv: true });
|
|
if (!success) {
|
|
throw new Error(`${command} ${args[0]} exited with ${code}`);
|
|
}
|
|
}
|
|
|
|
async function configureGitAuthor(): Promise<void> {
|
|
const user: unknown = await (await gitea("user")).json();
|
|
if (!isObject(user) || typeof user.login !== "string" || typeof user.email !== "string") {
|
|
throw new Error("user: unexpected Gitea response");
|
|
}
|
|
await runRoot("git", ["config", "user.name", user.login]);
|
|
await runRoot("git", ["config", "user.email", user.email]);
|
|
}
|
|
|
|
async function readProfileToken(profile: RuntimeProfile): Promise<string | undefined> {
|
|
const token = profile.tokenFile === null ? undefined : await readFile(profile.tokenFile, "utf8");
|
|
return token;
|
|
}
|
|
|
|
async function prepareProfile(profile: RuntimeProfile): Promise<void> {
|
|
await runAgentCommand(profile, "git", [
|
|
"config",
|
|
"--global",
|
|
"--add",
|
|
"safe.directory",
|
|
WORKSPACE,
|
|
]);
|
|
await runAgentCommand(profile, "npx", [
|
|
"-y",
|
|
...SKILLS_INSTALL.split(" "),
|
|
"--global",
|
|
"--agent",
|
|
profile.type === "claude" ? "claude-code" : profile.type,
|
|
"--yes",
|
|
]);
|
|
}
|
|
|
|
// One issue comment as the prompt quotes it.
|
|
function formatComment(comment: unknown): string {
|
|
const { user, created_at: createdAt, body } = isObject(comment) ? comment : {};
|
|
const login = isObject(user) ? user.login : undefined;
|
|
return `## ${String(login)} at ${String(createdAt)}\n\n${String(body)}\n`;
|
|
}
|
|
|
|
async function promptValues(
|
|
reviewPath: string,
|
|
anchorsPath: string,
|
|
): Promise<Record<string, string>> {
|
|
const comments: unknown = await (
|
|
await gitea(`repos/${REPO}/issues/${INDEX}/comments?limit=100`)
|
|
).json();
|
|
if (!Array.isArray(comments)) {
|
|
throw new TypeError("comments: unexpected Gitea response");
|
|
}
|
|
return {
|
|
COMMENT: env("COMMENT"),
|
|
ISSUE_COMMENTS: comments.map((comment: unknown) => formatComment(comment)).join("\n"),
|
|
CODE_RULES: await (await gitea(RULES_PATH)).text(),
|
|
EVENT_NAME: EVENT,
|
|
GITEA_API_URL: API,
|
|
GITEA_REPOSITORY: REPO,
|
|
ISSUE_INDEX: INDEX,
|
|
REVIEW_PATH: reviewPath,
|
|
ANCHORS_PATH: anchorsPath,
|
|
};
|
|
}
|
|
|
|
async function renderPrompt(profile: RuntimeProfile): Promise<RenderedPrompt> {
|
|
const reviewPath = await makeProfileFile(profile, "review.md");
|
|
const anchorsPath = await makeProfileFile(profile, "anchors.json");
|
|
const values = await promptValues(reviewPath, anchorsPath);
|
|
const template = await readFile(new URL("../prompt.md", import.meta.url), "utf8");
|
|
return {
|
|
prompt: template.replaceAll(
|
|
/\$\{(\w+)\}/gu,
|
|
(match: string, name: string) => values[name] ?? match,
|
|
),
|
|
reviewPath,
|
|
anchorsPath,
|
|
};
|
|
}
|
|
|
|
async function runProfile(profile: RuntimeProfile): Promise<AttemptResult> {
|
|
const token = await readProfileToken(profile);
|
|
const authentication = profile.type === "codex" ? codexAuthentication(token) : null;
|
|
let stagedCodexAuth: string | null = null;
|
|
let answer: AgentAnswer = {};
|
|
let rendered: RenderedPrompt | undefined;
|
|
try {
|
|
if (authentication?.kind === "persistent") {
|
|
stagedCodexAuth = await stageCodexAuth(CODEX_AUTH, profile.home, profile.uid, profile.gid);
|
|
}
|
|
await prepareProfile(profile);
|
|
rendered = await renderPrompt(profile);
|
|
answer = await runAgent(profile, token, rendered.prompt, authentication);
|
|
} finally {
|
|
await killProfileProcesses(profile.uid);
|
|
if (stagedCodexAuth !== null) {
|
|
await persistCodexAuth(stagedCodexAuth, CODEX_AUTH);
|
|
}
|
|
}
|
|
const body =
|
|
answer.resultPath === undefined
|
|
? answer.body
|
|
: await readProfileFile(profile, answer.resultPath);
|
|
if (body === undefined || rendered === undefined) {
|
|
throw new Error("agent attempt produced no result");
|
|
}
|
|
const { reviewPath, anchorsPath } = rendered;
|
|
return { body, reviewPath, anchorsPath, profile: { type: profile.type, model: profile.model } };
|
|
}
|
|
|
|
async function writeOutcome(outcome: RuntimeOutcome): Promise<void> {
|
|
await writeFile(MANIFEST.outcomeFile, JSON.stringify(outcome), { mode: 0o600 });
|
|
await chmod(MANIFEST.outcomeFile, 0o600);
|
|
}
|
|
|
|
const failures: ProfileFailure[] = [];
|
|
try {
|
|
await configureGitAuthor();
|
|
await writeOutcome({ ok: true, ...(await runProfiles(MANIFEST.profiles, runProfile, failures)) });
|
|
} catch (error) {
|
|
console.error(error);
|
|
await writeOutcome({ ok: false, failures });
|
|
throw error;
|
|
}
|