006bbe6b0c
## Summary
Moves `commons/bot-agents` off Deno. The action's TypeScript now runs directly on the job image's Node.js (`node src/<phase>.ts`, using Node's built-in type stripping), with no build step and still no runtime dependency. Repository checks move to Vite+ (`vp check`, `vp test`).
## What changed
- **Runtime.** `action.yml` runs `prepare.ts`, `run.ts`, and `post.ts` with `node` instead of `deno run -A`. `package.json` (`"type": "module"`, `engines.node >=24.2` for `import.meta.main`) is now copied into the root-owned source copy by `scripts/protect-source.sh`.
- **Profiles.** `profiles.yml` → `profiles.json`, with the same content (encrypted values unchanged), parsed with `JSON.parse`. This drops the only runtime dependency (`@std/yaml`).
- **Deno APIs → Node.**
- `src/command.ts` wraps `child_process.spawn` with the old `Deno.Command` shapes: `output()`/`spawn()`, `clearEnv`, `uid`/`gid`, and Deno's stdio defaults (stdin inherited; stdout/stderr piped for `output()`, inherited for `spawn()`). A signal exit maps to `128 + signo`. Status settles on process exit.
- `src/errors.ts` maps `NotFound` to `ENOENT`/`ESRCH`.
- fs, path, stream, and readline calls are mapped one for one. `makeTempFile` becomes an exclusive `wx` 0600 create.
- **Size refactors.** These are needed for Oxlint's default limits. There are no behavior changes and no overrides for source files.
- `run.ts` is split into `run-context.ts`, `agents.ts`, and `agent-{claude,codex,opencode}.ts`.
- `post.ts` is split into `post.ts` and `post-artifacts.ts`.
- `parseCredentials`, `readOutcome`, and `postRuntime` are broken into helpers.
- Loops that awaited sequentially became recursion or a `reduce` chain, so they stay sequential. `/proc` status reads became `Promise.all`.
- `src/json.ts` adds type guards in place of `as` casts.
- **Tests.** The 58 `Deno.test` cases were converted to Vitest with the codemod, and its TODOs were finished by hand.
- Unit tests are `src/*.test.ts`; the repository-level workflow test is `tests/workflow.test.ts`.
- Root-only tests are now `test.skipIf(!IS_ROOT)`, so they show as skipped instead of silently passing.
- New `tests/entrypoints.test.ts` runs each phase under real Node to prove its whole import graph loads.
- **Config.** The only config files are `package.json`, `tsconfig.json`, and `vite.config.ts`, plus `package-lock.json`.
- Lint uses Oxlint correctness/suspicious/pedantic/perf at error, with default limits and type-aware checks.
- `scripts/project-lint.ts` holds the rule list. It maps Deno's `recommended` rules that fall outside those categories, adds the template's `id-match`, `no-disable-comments`, and `no-non-ts-imports`, and maps Deno's `no-window`/`no-process-global`/`no-node-globals` to `no-restricted-globals` (so `process`/`Buffer` come from `node:` imports).
- **CI.** `.gitea/workflows/check.yml` runs `node --version`, `npm ci`, `npx vp check`, and `npx vp test` in the default runner image.
- **Formatting.** Oxfmt formatting is a separate first commit, so the second commit shows only the semantic diff.
- **AGENTS.md** is updated for the new toolchain.
## Deviations / risks
- **Live `@main` switch.** Six consumer repos use `commons/bot-agents@main`, so merging switches all of them at once. Suggested before merging: tag the current `main` (e.g. `deno-final`) as a rollback target, and canary this branch from one consumer (`uses: …/commons/bot-agents@node-migration`) on a throwaway PR.
- **Node version.** `post.ts` relies on `import.meta.main`, which needs Node ≥ 24.2. DANNYEC's cached `node:24-bookworm` minor is unknown (`forcePull=false`), and the CI job now prints `node --version` to confirm it.
- **Deno stays in the global install.** `deno` remains in the action's global npm install because agents still verify Deno-based consumers (memona, memona-home). Remove it once those repos move.
- **`prefer-readonly-parameter-types` is off.** This pedantic rule is turned off, as in the explicit-types template and the app repos, because Node/web types (`Response`, `Stats`, `RequestInit`) can never satisfy it. `scripts/**` has one narrow override (`no-unsafe-enum-comparison`) for AST node `type` comparisons.
- **Stricter validation of malformed input.** For valid input, behavior is unchanged. A few validations are stricter where the old code would have used a malformed value:
- Gitea `/user` and comment responses are checked.
- The runtime manifest and the outcome's profile type are checked against known values.
- Some type-check errors are now `TypeError` (same messages).
- **@cunarist lint plugins.** "CI fails until @cunarist/eslint-plugin-* are published" does **not** apply here. This repo's Deno setup enabled no plugin, so it depends on none of `@cunarist/eslint-plugin-*`, and CI can pass as is.
## Verification
- `vp check`: formatting, lint (0 warnings), and type check all pass.
- `vp test` as a normal user: 56 passed, 5 root-only skipped.
- `vp test` as root in `node:24-bookworm` (Node v24.22.0, the CI image): all 61 passed, including the UID isolation, process cleanup, and `prepare.ts` cleanup tests.
- End-to-end smoke as root in `node:24-bookworm`, with fake `codex`/`claude`/`npx` binaries and a fake Gitea, through `protect-source.sh` → `prepare.ts` → `run.ts` → `post.ts`:
- Codex hit "usage limit" and fell through to Claude.
- Agents ran as UIDs 20000/20001 without the master key.
- The Codex login was persisted to `/root/.codex/auth.json` (0600).
- The PR review with an inline comment was posted with the reviewer token.
- Runtime credentials were removed and the git author was configured.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Reviewed-on: #20
Reviewed-by: bot <noreply@capsulizers.com>
Co-authored-by: Danny Kim <temeddix@gmail.com>
Co-committed-by: Danny Kim <temeddix@gmail.com>
175 lines
5.4 KiB
TypeScript
175 lines
5.4 KiB
TypeScript
// Signs Codex in for one profile, runs it, and returns its result file path.
|
|
import process from "node:process";
|
|
import type { Readable } from "node:stream";
|
|
import { text } from "node:stream/consumers";
|
|
import { setTimeout as sleep } from "node:timers/promises";
|
|
|
|
import { isCodexAuthFailure, retryInvalidToken } from "./auth.ts";
|
|
import type { CodexAuthentication } from "./auth.ts";
|
|
import { chunks, endWith, writeChunk } from "./command.ts";
|
|
import type { CommandStatus } from "./command.ts";
|
|
import { agentCommand } from "./isolation.ts";
|
|
import { AgentAuthError, agentEnvironment, withProfile } from "./profiles.ts";
|
|
import {
|
|
makeProfileFile,
|
|
postAuthorComment,
|
|
PROCESS_ENV,
|
|
runAgentCommand,
|
|
WORKSPACE,
|
|
} from "./run-context.ts";
|
|
import type { RuntimeProfile } from "./runtime.ts";
|
|
|
|
interface CodexAttempt {
|
|
status: CommandStatus;
|
|
error: string;
|
|
}
|
|
|
|
async function collectText(stream: Readable, append: (chunk: string) => void): Promise<void> {
|
|
const decoder = new TextDecoder();
|
|
for await (const chunk of chunks(stream)) {
|
|
append(decoder.decode(chunk, { stream: true }));
|
|
}
|
|
append(decoder.decode());
|
|
}
|
|
|
|
// Polls every 100 ms until the login prints something, failing if it exits first.
|
|
async function pollForInstructions(
|
|
shownText: () => string,
|
|
status: Promise<CommandStatus>,
|
|
): Promise<void> {
|
|
if (shownText().trim() !== "") {
|
|
return;
|
|
}
|
|
const exited = await Promise.race([status.then(() => true), sleep(100, false)]);
|
|
if (exited) {
|
|
throw new AgentAuthError("AI bot login produced no instructions");
|
|
}
|
|
await pollForInstructions(shownText, status);
|
|
}
|
|
|
|
async function codexDeviceLogin(
|
|
profile: RuntimeProfile,
|
|
environment: Record<string, string>,
|
|
): Promise<void> {
|
|
const login = agentCommand(profile, "codex", ["login", "--device-auth"], {
|
|
cwd: WORKSPACE,
|
|
env: environment,
|
|
clearEnv: true,
|
|
stdout: "piped",
|
|
stderr: "piped",
|
|
}).spawn();
|
|
let shown = "";
|
|
const append = (chunk: string): void => {
|
|
shown += chunk;
|
|
};
|
|
const drained = Promise.all([
|
|
collectText(login.stdout, append),
|
|
collectText(login.stderr, append),
|
|
]);
|
|
await sleep(3000);
|
|
await pollForInstructions(() => shown, login.status);
|
|
await postAuthorComment(withProfile(shown, profile));
|
|
const [result] = await Promise.all([login.status, drained]);
|
|
if (!result.success) {
|
|
throw new AgentAuthError(`codex login exited with ${result.code}`);
|
|
}
|
|
}
|
|
|
|
async function codexApiLogin(
|
|
profile: RuntimeProfile,
|
|
environment: Record<string, string>,
|
|
token: string,
|
|
): Promise<void> {
|
|
const login = agentCommand(profile, "codex", ["login", "--with-api-key"], {
|
|
cwd: WORKSPACE,
|
|
env: environment,
|
|
clearEnv: true,
|
|
stdin: "piped",
|
|
stderr: "piped",
|
|
}).spawn();
|
|
await endWith(login.stdin, `${token}\n`);
|
|
const [status, error] = await Promise.all([login.status, text(login.stderr)]);
|
|
if (!status.success) {
|
|
throw new Error(error.trim() || `codex login exited with ${status.code}`);
|
|
}
|
|
}
|
|
|
|
async function signIn(
|
|
profile: RuntimeProfile,
|
|
environment: Record<string, string>,
|
|
authentication: CodexAuthentication,
|
|
): Promise<void> {
|
|
if (authentication.kind === "api-key") {
|
|
await codexApiLogin(profile, environment, authentication.token);
|
|
return;
|
|
}
|
|
const loggedIn = await agentCommand(profile, "codex", ["login", "status"], {
|
|
cwd: WORKSPACE,
|
|
env: environment,
|
|
clearEnv: true,
|
|
}).output();
|
|
if (!loggedIn.success) {
|
|
await codexDeviceLogin(profile, environment);
|
|
}
|
|
}
|
|
|
|
async function execCodex(
|
|
profile: RuntimeProfile,
|
|
environment: Record<string, string>,
|
|
prompt: string,
|
|
outputPath: string,
|
|
): Promise<CodexAttempt> {
|
|
const args = [
|
|
"exec",
|
|
"--model",
|
|
profile.model,
|
|
"--dangerously-bypass-approvals-and-sandbox",
|
|
"--output-last-message",
|
|
outputPath,
|
|
prompt,
|
|
];
|
|
const codex = agentCommand(profile, "codex", args, {
|
|
cwd: WORKSPACE,
|
|
env: environment,
|
|
clearEnv: true,
|
|
stdout: "inherit",
|
|
stderr: "piped",
|
|
}).spawn();
|
|
const decoder = new TextDecoder();
|
|
let error = "";
|
|
for await (const chunk of chunks(codex.stderr)) {
|
|
await writeChunk(process.stderr, chunk);
|
|
error += decoder.decode(chunk, { stream: true });
|
|
}
|
|
error += decoder.decode();
|
|
// Codex echoes the prompt, whose comments may quote auth errors.
|
|
return { status: await codex.status, error: error.replaceAll(prompt, "") };
|
|
}
|
|
|
|
export async function runCodex(
|
|
profile: RuntimeProfile,
|
|
prompt: string,
|
|
authentication: CodexAuthentication,
|
|
): Promise<string> {
|
|
const token = authentication.kind === "api-key" ? authentication.token : undefined;
|
|
const environment = agentEnvironment(PROCESS_ENV, profile, token);
|
|
await signIn(profile, environment, authentication);
|
|
const outputPath = await makeProfileFile(profile, "result.md");
|
|
const attempt = (): Promise<CodexAttempt> => execCodex(profile, environment, prompt, outputPath);
|
|
const result =
|
|
authentication.kind === "api-key"
|
|
? await attempt()
|
|
: await retryInvalidToken(attempt, async () => {
|
|
await runAgentCommand(profile, "codex", ["logout"]);
|
|
await codexDeviceLogin(profile, environment);
|
|
});
|
|
if (!result.status.success) {
|
|
const failure = new Error(result.error.trim() || `codex exited with ${result.status.code}`);
|
|
if (isCodexAuthFailure(result.error)) {
|
|
throw new AgentAuthError("codex sign-in failed", { cause: failure });
|
|
}
|
|
throw failure;
|
|
}
|
|
return outputPath;
|
|
}
|