commons/memona-plugin-signature
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Open a WebDAV server as a folder under the signature plugin #1

Merged
temeddix merged 3 commits from scaffold into main 2026-09-25 16:54:16 +00:00
Conversation 3 Commits 3 Files Changed 12
+1563 -4
temeddix commented 2026-09-25 16:38:42 +00:00
Owner
Copy Link
Copy Source

The signature plugin starts as a WebDAV folder, copied from the WebDAV plugin with only its name, package id and provider changed. That crate keeps its provider private and exports the component entry points itself, so a dependency could not wrap it without a fork. The README credits the source commit, signing lands in a follow-up, and a workflow lets the AI bot review pull requests here.

Verified: the release build for wasm32-wasip2, clippy with warnings denied, rustfmt, and the eight unit tests carried over all pass.

Build and checks Reference
Build output WebDAV PUT, RFC 4918
Memona filesystem behavior Memona manifest
WASI

References: Memona filesystem behavior, Memona package format, RFC 4918 PUT, WASI, md-ens-signature, this pull request: #1

🤖 Generated with Claude Code

The signature plugin starts as a WebDAV folder, copied from the [WebDAV plugin](https://git.capsulizers.com/commons/memona-plugin-webdav) with only its name, package id and provider changed. That crate keeps its provider private and exports the component entry points itself, so a dependency could not wrap it without a fork. The README credits the source commit, signing lands in a follow-up, and a workflow lets the AI bot review pull requests here. Verified: the release build for wasm32-wasip2, clippy with warnings denied, rustfmt, and the eight unit tests carried over all pass. | Build and checks | Reference | | --- | --- | | ![Build output](https://git.capsulizers.com/attachments/c22f00ae-1aeb-4e6d-a950-b07eabd3f79b) | ![WebDAV PUT, RFC 4918](https://git.capsulizers.com/attachments/5a238a22-8956-49df-859f-ce1d7c24d0e5) | | ![Memona filesystem behavior](https://git.capsulizers.com/attachments/a86066ba-b01e-4b15-9e1c-e6dcf91cacf2) | ![Memona manifest](https://git.capsulizers.com/attachments/890ed728-69dd-49ee-845a-4df8ad6dd25b) | | ![WASI](https://git.capsulizers.com/attachments/c0d525f6-a04f-4957-8ea6-9f11829f3262) | | References: [Memona filesystem behavior](https://docs.memona.io/extensions/filesystem.html), [Memona package format](https://docs.memona.io/extensions/package.html), [RFC 4918 PUT](https://www.rfc-editor.org/rfc/rfc4918.html#section-9.7), [WASI](https://wasi.dev/), [md-ens-signature](https://github.com/capsulizers/md-ens-signature), this pull request: https://git.capsulizers.com/commons/memona-plugin-signature/pulls/1 🤖 Generated with [Claude Code](https://claude.com/claude-code)
build-scaffold.png
112 KiB
docs-filesystem.png
125 KiB
docs-package.png
128 KiB
rfc4918-put.png
107 KiB
wasi.png
155 KiB
temeddix added 1 commit 2026-09-25 16:38:43 +00:00
Open a WebDAV server as a folder, starting from the WebDAV plugin's code 57347acdb6
temeddix commented 2026-09-25 16:39:06 +00:00
Author
Owner
Copy Link
Copy Source

@bot please review the head; this is the WebDAV plugin copied under a new package id, so check the renamed manifest and the README attribution.

@bot please review the head; this is the WebDAV plugin copied under a new package id, so check the renamed manifest and the README attribution.
temeddix added 1 commit 2026-09-25 16:40:05 +00:00
Let the AI bot review pull requests
Agents / agent (pull_request) Successful in 4m1s
Details
7f4e4e9719
temeddix requested review from bot 2026-09-25 16:40:10 +00:00
bot requested changes 2026-09-25 16:43:59 +00:00
Dismissed
bot left a comment
Owner
Copy Link
Copy Source

🛑 Changes requested
Correct the README so it does not promise signing before the follow-up implements it.

Strengths

Renamed package and attribution
  • The manifest consistently uses memona/signature, signature, and signed-webdav.
  • The attribution identifies the source repository, MIT license, and verified source commit 3d69750.

Important

README promises signing
  • Anchored below.

Tests

Passed
  • cargo fmt --check
  • cargo test --locked --lib — 8 passed
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo build --locked --release --target wasm32-wasip2
Declined to judge
  • The signing implementation is explicitly deferred by the PR description; only its contradictory present-tense documentation is in scope.

Profile: codex · gpt-5.6-terra

🛑 Changes requested Correct the README so it does not promise signing before the follow-up implements it. ### Strengths <details> <summary>Renamed package and attribution</summary> - The manifest consistently uses `memona/signature`, `signature`, and `signed-webdav`. - The attribution identifies the source repository, MIT license, and verified source commit `3d69750`. </details> ### Important <details> <summary>README promises signing</summary> - Anchored below. </details> ### Tests <details> <summary>Passed</summary> - `cargo fmt --check` - `cargo test --locked --lib` — 8 passed - `cargo clippy --locked --all-targets -- -D warnings` - `cargo build --locked --release --target wasm32-wasip2` </details> <details> <summary>Declined to judge</summary> - The signing implementation is explicitly deferred by the PR description; only its contradictory present-tense documentation is in scope. </details> > Profile: `codex` · `gpt-5.6-terra`
README.md Outdated
@@ -1,3 +1,3 @@
# Memona signature plugin
Opens a WebDAV server as a folder inside Memona and signs every Markdown file
bot commented 2026-09-25 16:43:59 +00:00
Owner
Copy Link
Copy Source

This component is still an unchanged WebDAV copy: open_write streams its input directly to PUT and Cargo.toml has no signing dependency or signer configuration. The PR description defers signing, so these present-tense claims will make installed users expect a feature that is not shipped. Describe this PR as the WebDAV foundation (or add the signing hook) before merging.

Profile: codex · gpt-5.6-terra

This component is still an unchanged WebDAV copy: `open_write` streams its input directly to PUT and Cargo.toml has no signing dependency or signer configuration. The PR description defers signing, so these present-tense claims will make installed users expect a feature that is not shipped. Describe this PR as the WebDAV foundation (or add the signing hook) before merging. > Profile: `codex` · `gpt-5.6-terra`
temeddix added 1 commit 2026-09-25 16:45:17 +00:00
Say the scaffold is a WebDAV folder that does not sign yet
Agents / agent (pull_request) Successful in 5m17s
Details
3cd0997156
temeddix requested review from bot 2026-09-25 16:48:46 +00:00
bot approved these changes 2026-09-25 16:53:47 +00:00
bot left a comment
Owner
Copy Link
Copy Source

✅ Approved
Renamed manifest and upstream attribution verified.

Strengths

Manifest and attribution
  • memona/signature, provider signature, and signed-webdav are consistent.
  • README credits the MIT upstream repository and commit 3d69750; copied source matches it except the intended module documentation.

Issues

None.

Tests

Passed
  • cargo fmt --check
  • cargo test --locked --lib — 8 passed
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo build --locked --release --target wasm32-wasip2
Declined to judge
  • Signing is explicitly deferred by the pull request and does not block this WebDAV scaffold.
Compliance
  • Repository-wide code-rule scan found no violations.
  • The only pending status is this bot review workflow, which is not a project check.

Profile: codex · gpt-5.6-terra

✅ Approved Renamed manifest and upstream attribution verified. ### Strengths <details> <summary>Manifest and attribution</summary> - `memona/signature`, provider `signature`, and `signed-webdav` are consistent. - README credits the MIT upstream repository and commit `3d69750`; copied source matches it except the intended module documentation. </details> ### Issues None. ### Tests <details> <summary>Passed</summary> - `cargo fmt --check` - `cargo test --locked --lib` — 8 passed - `cargo clippy --locked --all-targets -- -D warnings` - `cargo build --locked --release --target wasm32-wasip2` </details> <details> <summary>Declined to judge</summary> - Signing is explicitly deferred by the pull request and does not block this WebDAV scaffold. </details> <details> <summary>Compliance</summary> - Repository-wide code-rule scan found no violations. - The only pending status is this bot review workflow, which is not a project check. </details> > Profile: `codex` · `gpt-5.6-terra`
temeddix merged commit a4d1fae1d3 into main 2026-09-25 16:54:16 +00:00
temeddix deleted branch scaffold 2026-09-25 16:54:16 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
bot
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bot RaymondCho temeddix
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: commons/memona-plugin-signature#1
Delete Branch "scaffold"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?