Signed files keep their signature a string for every YAML parser #4

2026-09-25T19:38:28Z

temeddix commented

2026-09-25 19:38:28 +00:00

Saved Markdown now carries its signature double-quoted, signature: "0x…", because YAML reads a bare 0x… value as an integer and Memona's frontmatter bar would show a number instead of the hex. The md-ens-signature library is pinned to its current main, which writes the quotes and also brings the ENSv2 owner lookup and verify that reads will use next.

Verified: the wasm32-wasip2 release build, clippy with warnings denied, rustfmt, and twelve unit tests, one of them now checking the quoted signature. Library change: https://github.com/capsulizers/md-ens-signature/pull/20

🤖 Generated with Claude Code

Saved Markdown now carries its signature double-quoted, `signature: "0x…"`, because YAML reads a bare `0x…` value as an integer and Memona's frontmatter bar would show a number instead of the hex. The [md-ens-signature](https://github.com/capsulizers/md-ens-signature) library is pinned to its current main, which writes the quotes and also brings the ENSv2 owner lookup and `verify` that reads will use next. Verified: the wasm32-wasip2 release build, clippy with warnings denied, rustfmt, and twelve unit tests, one of them now checking the quoted signature. Library change: https://github.com/capsulizers/md-ens-signature/pull/20 🤖 Generated with [Claude Code](https://claude.com/claude-code)

temeddix added 1 commit 2026-09-25 19:38:28 +00:00

Signed files keep their signature a string for every YAML parser

Agents / agent (pull_request) Has been skipped

Details

47c74a0925

temeddix commented

2026-09-25 19:38:33 +00:00

@bot please review the head; it only moves the pinned md-ens-signature revision to current main, so check the lockfile change and the new quoted-signature assertion.

bot approved these changes 2026-09-25 19:42:48 +00:00

bot left a comment

✅ Approved
Summary: The pin matches upstream main; the lockfile resolves and quoted signatures are covered.

Strengths

Dependency and regression coverage

Cargo.toml and Cargo.lock consistently pin md-ens-signature at 86878b144154c894948c595d2f0d66fbbd36ae4b, the current upstream main.
The signing test verifies the generated frontmatter emits signature as a double-quoted 0x... scalar, then parses and recovers it successfully.

Issues

None

Critical: none.
Important: none.
Minor: none.

Recommendations

None

None.

Assessment

Ready to merge

Ready to merge: Yes.
cargo metadata --locked --no-deps, cargo fmt --check, cargo test --locked --lib, cargo clippy --locked --lib -- -D warnings, and cargo build --locked --release --target wasm32-wasip2 passed.

Declined to judge

None

None.

Profile: codex · gpt-5.6-terra

✅ Approved Summary: The pin matches upstream main; the lockfile resolves and quoted signatures are covered. ## Strengths <details> <summary>Dependency and regression coverage</summary> - `Cargo.toml` and `Cargo.lock` consistently pin `md-ens-signature` at `86878b144154c894948c595d2f0d66fbbd36ae4b`, the current upstream `main`. - The signing test verifies the generated frontmatter emits `signature` as a double-quoted `0x...` scalar, then parses and recovers it successfully. </details> ## Issues <details> <summary>None</summary> - Critical: none. - Important: none. - Minor: none. </details> ## Recommendations <details> <summary>None</summary> - None. </details> ## Assessment <details> <summary>Ready to merge</summary> - Ready to merge: Yes. - `cargo metadata --locked --no-deps`, `cargo fmt --check`, `cargo test --locked --lib`, `cargo clippy --locked --lib -- -D warnings`, and `cargo build --locked --release --target wasm32-wasip2` passed. </details> ## Declined to judge <details> <summary>None</summary> - None. </details> > Profile: `codex` · `gpt-5.6-terra`

temeddix merged commit 1d36760782 into main

2026-09-25 19:43:09 +00:00

temeddix deleted branch bump-library-quoted-signature

2026-09-25 19:43:10 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: commons/memona-plugin-signature#4