WebDAV validates connections and preserves directory listings, with CI checking every change #1

Merged
temeddix merged 10 commits from fix-directory-listing into main 2026-09-30 13:10:15 +00:00
3 changed files with 13 additions and 13 deletions
Showing only changes of commit db4f5999d1 - Show all commits
+2 -2
View File
@@ -17,8 +17,8 @@ This package requires a Memona version that supports plugin manifest schema 2.
| Username | Optional account name for HTTP basic authentication | | Username | Optional account name for HTTP basic authentication |
| Password | Optional password, stored as a secret | | Password | Optional password, stored as a secret |
For localhost or a server on a private network, turn on **Private network** in Public, LAN, VPN, link-local and localhost addresses work directly from the
Outdated
Review

LAN, link-local, and localhost addresses require the private-network grant. Update this guidance so users are prompted for the permission instead of being told none is needed.

Profile: codex · gpt-5.6-terra

LAN, link-local, and localhost addresses require the private-network grant. Update this guidance so users are prompted for the permission instead of being told none is needed. > Profile: `codex` · `gpt-5.6-terra`
the connection settings. Save and reconnect after changing these settings. server address; there is no separate network permission setting.
Listing, reading, writing, creating directories, renaming and deleting are Listing, reading, writing, creating directories, renaming and deleting are
supported. Reads and writes stream in pieces of at most 1 MiB, so a file of any supported. Reads and writes stream in pieces of at most 1 MiB, so a file of any
+1
View File
@@ -441,6 +441,7 @@ impl Guest for Webdav {
} }
} }
#[cfg(not(test))]
sdk::export!(Webdav with_types_in sdk); sdk::export!(Webdav with_types_in sdk);
#[cfg(test)] #[cfg(test)]
+10 -11
View File
@@ -35,11 +35,10 @@ interface host {
/// `respond`. An empty result means the body is complete. /// `respond`. An empty result means the body is complete.
pull: func(limit: u32) -> result<list<u8>, host-error>; pull: func(limit: u32) -> result<list<u8>, host-error>;
} }
/// Begins a request to any public HTTP or HTTPS host. Each redirect and /// Begins a request to any HTTP or HTTPS host, including LAN and loopback
Review

LAN and loopback access still requires the connection's private-network grant. Restore that requirement here; otherwise this copied contract tells plugin authors that private hosts are reachable without consent.

Profile: codex · gpt-5.6-terra

LAN and loopback access still requires the connection's private-network grant. Restore that requirement here; otherwise this copied contract tells plugin authors that private hosts are reachable without consent. > Profile: `codex` · `gpt-5.6-terra`
/// DNS result is checked, and DNS is pinned. Private/LAN addresses require /// addresses. Each redirect and DNS result is checked, and DNS is pinned.
/// the connection's private-network grant. Cross-origin redirects remove /// Cross-origin redirects remove request headers; HTTPS cannot downgrade.
/// request headers; HTTPS cannot /// The host bounds total bytes per exchange, not buffer size.
/// downgrade. The host bounds total bytes per exchange, not buffer size.
http: func(request: request) -> result<exchange, host-error>; http: func(request: request) -> result<exchange, host-error>;
/// One open TCP connection. Dropping the handle closes the socket, and the /// One open TCP connection. Dropping the handle closes the socket, and the
@@ -51,10 +50,10 @@ interface host {
/// Writes at most 1,048,576 bytes and returns how many were accepted. /// Writes at most 1,048,576 bytes and returns how many were accepted.
write: func(data: list<u8>) -> result<u32, host-error>; write: func(data: list<u8>) -> result<u32, host-error>;
} }
/// Opens a socket to any public host on a package-declared port. /// Opens a socket to any host, including LAN and loopback addresses, on a
Outdated
Review

The private-network grant applies to TCP too. Keep that constraint in the socket documentation so it matches HTTP and the host's enforcement.

Profile: codex · gpt-5.6-terra

The private-network grant applies to TCP too. Keep that constraint in the socket documentation so it matches HTTP and the host's enforcement. > Profile: `codex` · `gpt-5.6-terra`
/// The host resolves and pins DNS, applies the same private-address rule /// package-declared port. The host resolves and pins DNS and starts TLS
/// as `http`, and starts TLS when asked. Ports /// when asked. Ports negotiated at runtime, such as an FTP data channel,
/// negotiated at runtime, such as an FTP data channel, must be declared. /// must be declared.
connect: func(host: string, port: u16, tls: bool) -> result<tcp, host-error>; connect: func(host: string, port: u16, tls: bool) -> result<tcp, host-error>;
/// One datagram socket connected to a single peer. /// One datagram socket connected to a single peer.
@@ -65,8 +64,8 @@ interface host {
/// means none arrived inside the host's wait, not that the peer left. /// means none arrived inside the host's wait, not that the peer left.
receive: func(limit: u32) -> result<list<u8>, host-error>; receive: func(limit: u32) -> result<list<u8>, host-error>;
} }
/// Connects a datagram socket under the same port and private-network rules /// Connects a datagram socket under the same port rules as `connect`, for
Outdated
Review

UDP uses the same private-network grant as TCP and HTTP. Restore the grant rule here instead of reducing it to a port-only constraint.

Profile: codex · gpt-5.6-terra

UDP uses the same private-network grant as TCP and HTTP. Restore the grant rule here instead of reducing it to a port-only constraint. > Profile: `codex` · `gpt-5.6-terra`
/// as `connect`, for the few filesystem protocols that still need one. /// the few filesystem protocols that still need one.
bind: func(host: string, port: u16) -> result<udp, host-error>; bind: func(host: string, port: u16) -> result<udp, host-error>;
/// A configuration value, typed as the package's manifest declared it. /// A configuration value, typed as the package's manifest declared it.