Danny Kim
32806120b3
Groups the flat `src/` into cohesive modules and turns on the published lint plugins. No behavior change. ## Module layout Each module is a direct `src/` subfolder with an `index.ts` barrel and a `#` alias in `package.json` `imports` (layer order, top first): | Alias | Files | | --- | --- | | `#prepare` | `index.ts` (the prepare phase entry point) | | `#run` | `index.ts` (the run phase entry point) | | `#post` | `index.ts` (the post phase entry point), `post.ts`, `post.test.ts` | | `#agents` | `auth.ts`, `opencode.ts` (Codex / Claude Code sign-in, OpenCode args and output) | | `#processes` | `child.ts`, `isolation.ts` | | `#runtime` | `runtime.ts`, `credentials.ts` | | `#profiles` | `profiles.ts` | | `#common` | `errors.ts`, `json.ts` | | `#testing` | `index.ts` (unchanged) | Every top-level entry of `src/` is an aliased module folder. Tests stay next to their code as `*.test.ts`. Each phase's `index.ts` is its entry point, and `action.yml` now runs `node src/<phase>/index.ts`. The post phase's logic moved to `src/post/post.ts` so its test can import it; `index.ts` keeps the env reading and the `import.meta.main` call. `run`'s prompt URL is now `../../prompt.md`. `scripts/protect-source.sh` now copies `src/` recursively (it used to copy `src/*.ts` only), and the workflow test checks that module files get staged too. ## Lint plugins - New devDependencies: `eslint-plugin-explicit-types@^0.6.1` and `eslint-plugin-import-structure@^0.10.2`, both in `jsPlugins`. The lockfile comes from a real `npm install`. - Enabled configs: `importStructure.configs.modules`, `explicitTypes.configs.concrete`, `explicitTypes.configs.absence`. - **explicit-types `naming` is off** (the other app repos turn it on). Its `upper-snake-string-unions` and `no-upper-snake-object-keys` rules fire on wire tokens this repo doesn't choose: profile types `"claude" | "codex" | "opencode"` from `profiles.json`, failure reasons posted to Gitea, Gitea's `"new" | "old"` side, and environment variable names such as `PATH`. Satisfying them would change behavior or need opt-outs. This is logged as an open question for the user. Lint fixes, all type-level: - `Pick<BotProfile, "type" | "model">` became a named `ProfileIdentity` interface that `BotProfile`, `ProfileFailure`, and `RuntimeProfile` extend. `RuntimeOutcome` is now `RuntimeSuccess | RuntimeFailure`. - Inline object types became named interfaces. - `Record<string, string>` env maps became `NodeJS.ProcessEnv`. `JsonObject` and the verdict table became `NodeJS.Dict<…>`. - `T | undefined` locals and returns became `T | null` with matching checks. `typeof fetch` became a `Fetcher` type. - Claude's result fields are held in camelCase (`isError`, `apiErrorStatus`) after parsing, because `id-match` rejects snake_case interface members. - Duplicate import sources are merged (`import-structure/no-duplicate-import-source`). ## Verification - `vp check`: clean. - `vp test`: 61 passed and 5 skipped as a normal user. All 66 passed as root in `node:24-bookworm`. - Each phase (`node src/<phase>/index.ts`) run from a `protect-source.sh` copy loads its full alias graph under Node. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Reviewed-on: #23 Reviewed-by: bot <noreply@capsulizers.com> Co-authored-by: Danny Kim <temeddix@gmail.com> Co-committed-by: Danny Kim <temeddix@gmail.com>
32 lines
2.0 KiB
Markdown
32 lines
2.0 KiB
Markdown
---
|
|
description: The action runs src/<phase>.ts directly with node on node:24-bookworm (no build); protect-source.sh copies only src/*.ts, package.json, profiles.json, prompt.md
|
|
---
|
|
|
|
`action.yml` is a composite action running three phases as
|
|
`node "<source>/src/{prepare,run,post}.ts"`. Node's built-in type stripping
|
|
runs the TypeScript; there is **no build step, no bundle, and no runtime
|
|
dependency**. Hence `tsconfig.json` has `erasableSyntaxOnly` and
|
|
`allowImportingTsExtensions`: only erasable syntax (no `enum`, no parameter
|
|
properties, no decorators) and relative `.ts` imports.
|
|
|
|
- **Image:** the steps assume the `node:24-bookworm` job container. Node must
|
|
be 24.2+ for `import.meta.main` in `src/post/index.ts`. That image is the only Node
|
|
pin (`package.json` has no `engines`); `check.yml` prints `node --version`
|
|
to confirm the cached image's minor.
|
|
- **Root-owned source copy:** `scripts/protect-source.sh` copies the action
|
|
into `$RUNNER_TEMP` so an agent editing the checkout can't swap a later
|
|
phase. It copies exactly `src/*.ts`, `package.json` (`"type": "module"`
|
|
makes Node load the sources as ES modules), `profiles.json`, and
|
|
`prompt.md`. **A new runtime file or subdirectory must be added there**, or
|
|
it is missing at run time. Runtime code in `src/` is flat; a subfolder would
|
|
not be copied. The only subfolder, `src/testing/`, is test-only.
|
|
- `tests/entrypoints.test.ts` runs each phase under real Node with a cleared
|
|
environment and expects its first "X is not set" error, which proves the
|
|
whole import graph loads without a build. Keep it in sync with the phases.
|
|
- **None of the app build conventions apply here:** no `vp build`, no
|
|
frontend or Rust/Tauri output paths, no Containerfile, no decorators
|
|
plugin, no lit-check, no generated JS. Don't add any of them.
|
|
- **CI** (`.gitea/workflows/check.yml`) runs on the self-hosted runner's
|
|
default image as root: `npm ci`, `npx vp check`, `npx vp test`. It does not
|
|
use `setup-vp`. YAML stays declarative ([[yaml-stays-declarative]]).
|