Tests use the README's example drive id instead of a real drive's #5

Merged
RaymondCho merged 1 commits from placeholder-drive-id into main 2026-10-15 14:28:48 +00:00
Owner

The address and session tests now use AbCdEf123456, the example drive id the README and the connection form already show, instead of the id of a real test drive. This comes before the repository is made public, like the other plugins in commons. Nothing on screen changes, so there are no screenshots.

Verified: rustfmt, clippy and the 40 unit tests pass; the real id no longer appears anywhere in the tree. The id gives no access on its own: without a token aindrive answers 401.

🤖 Generated with Claude Code

The address and session tests now use `AbCdEf123456`, the example drive id the README and the connection form already show, instead of the id of a real test drive. This comes before the repository is made public, like the other plugins in commons. Nothing on screen changes, so there are no screenshots. Verified: rustfmt, clippy and the 40 unit tests pass; the real id no longer appears anywhere in the tree. The id gives no access on its own: without a token aindrive answers 401. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
RaymondCho added 1 commit 2026-10-15 14:22:54 +00:00
Tests use the README's example drive id instead of a real drive's
CI / checks (pull_request) Successful in 42s
Agents / bot (pull_request) Successful in 4m29s
7304ac15d9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RaymondCho requested review from bot 2026-10-15 14:23:04 +00:00
bot approved these changes 2026-10-15 14:27:21 +00:00
bot left a comment
Owner

✅ Approved
The documented placeholder drive ID is used consistently; no blocking findings.

Checks

Verification
  • cargo fmt --check
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo test --locked --lib — 40 passed
  • cargo build --locked --release --target wasm32-wasip2
  • Required CI / checks (pull_request) status: successful

Findings

Strengths
  • Endpoint and session tests now match the README and manifest example without changing coverage.
Declined to judge
  • None.

Profile: codex · gpt-5.6-terra

✅ Approved The documented placeholder drive ID is used consistently; no blocking findings. ## Checks <details> <summary>Verification</summary> - `cargo fmt --check` - `cargo clippy --locked --all-targets -- -D warnings` - `cargo test --locked --lib` — 40 passed - `cargo build --locked --release --target wasm32-wasip2` - Required `CI / checks (pull_request)` status: successful </details> ## Findings <details> <summary>Strengths</summary> - Endpoint and session tests now match the README and manifest example without changing coverage. </details> <details> <summary>Declined to judge</summary> - None. </details> > Profile: `codex` · `gpt-5.6-terra`
RaymondCho merged commit 8fea308580 into main 2026-10-15 14:28:48 +00:00
RaymondCho deleted branch placeholder-drive-id 2026-10-15 14:28:48 +00:00
Sign in to join this conversation.
No Reviewers
No Label
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: commons/memona-plugin-aindrive#5